From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Subject: Re: [PATCH] Device tree binding for Avago APDS990X light sensor Date: Wed, 27 Dec 2017 20:00:01 +0200 Message-ID: <20171227180000.6ejpbqmr736nqx5i@kekkonen.localdomain> References: <20171227091828.GA3307@amd> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20171227091828.GA3307@amd> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Pavel Machek Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, aaro.koskinen-X3B1VOXEql0@public.gmane.org, ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, abcloriens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, clayton-fehKsxFhGzZIf6P1QZMOBw@public.gmane.org, martijn-28JJ9oSIdodmR6Xm/wNWPw@public.gmane.org, Filip =?utf-8?Q?Matijevi=C4=87?= List-Id: devicetree@vger.kernel.org Hi Pavel, Thanks for the patch. Please see my comments below. On Wed, Dec 27, 2017 at 10:18:28AM +0100, Pavel Machek wrote: > From: Filip Matijević > > This prepares binding for light sensor used in Nokia N9. > > Signed-off-by: Filip Matijević > Signed-off-by: Pavel machek > > --- > > Patches to convert APDS990X driver to device tree and to switch to iio > are available. > > diff --git a/Documentation/devicetree/bindings/misc/avago-apds990x.txt b/Documentation/devicetree/bindings/misc/avago-apds990x.txt > new file mode 100644 > index 0000000..e038146 > --- /dev/null > +++ b/Documentation/devicetree/bindings/misc/avago-apds990x.txt > @@ -0,0 +1,39 @@ > +Avago APDS990X driver > + > +Required properties: > +- compatible: "avago,apds990x" > +- reg: address on the I2C bus > +- interrupts: external interrupt line number > +- Vdd-supply: power supply for VDD > +- Vled-supply: power supply for LEDA AFAIK the custom is to use lower case letters for regulator supplies. > +- ga: Glass attenuation > +- cf1: Clear channel factor 1 > +- irf1: IR channel factor 1 > +- cf2: Clear channel factor 2 > +- irf2: IR channel factor 2 > +- df: Device factor > +- pdrive: IR current, one of APDS_IRLED_CURR_XXXmA values > +- ppcount: Proximity pulse count Are these device specific? If so, please add the vendor prefix to them. I might not use short abbreviations such as "df" either. I wonder what others think. > + > +Example (Nokia N9): > + > + als_ps@39 { > + compatible = "avago,apds990x"; > + reg = <0x39>; > + > + interrupt-parent = <&gpio3>; > + interrupts = <19 10>; /* gpio_83, IRQF_TRIGGER_FALLING | IRQF_TRIGGER_LOW */ > + > + Vdd-supply = <&vaux1>; > + Vled-supply = <&vbat>; > + > + ga = <168834>; > + cf1 = <4096>; > + irf1 = <7824>; > + cf2 = <877>; > + irf2 = <1575>; > + df = <52>; > + > + pdrive = <0x2>; /* APDS_IRLED_CURR_25mA */ > + ppcount = <5>; > + }; > -- Kind regards, Sakari Ailus sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html