From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Kevin Hilman <khilman@kernel.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Rafael Wysocki <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
Sudeep Holla <sudeep.holla@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values
Date: Thu, 28 Dec 2017 10:07:25 +0530 [thread overview]
Message-ID: <20171228043725.GB8652@vireshk-i7> (raw)
In-Reply-To: <CAL_JsqJzMfNhHK=6Wt4dzBRS9BVGMZ-f7uk3OnUupudTfwuyUA@mail.gmail.com>
On 27-12-17, 15:54, Rob Herring wrote:
> On Wed, Dec 27, 2017 at 2:56 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> > On 26-12-17, 14:29, Rob Herring wrote:
> >> On Mon, Dec 18, 2017 at 03:51:30PM +0530, Viresh Kumar wrote:
> >
> >> > +On some platforms the exact frequency or voltage may be hidden from the OS by
> >> > +the firmware and the "opp-hz" or the "opp-microvolt" properties may contain
> >> > +magic values that represent the frequency or voltage in a firmware dependent
> >> > +way, for example an index of an array in the firmware.
> >>
> >> I'm still not convinced this is a good idea.
> >
> > You were kind-of a few days back :)
> >
> > lkml.kernel.org/r/CAL_JsqK-qtAaM_Ou5NtxcWR3F_q=8rMPJUm-VqGtKhbtWe5SAQ@mail.gmail.com
>
> Yeah, well that was before Stephen said anything.
>
> > So here is the deal:
> >
> > - I proposed "domain-performance-state" property for this stuff
> > initially.
> > - But Kevin didn't like that and proposed reusing "opp-hz" and
> > "opp-microvolt", which we all agreed to multiple times..
> > - And we are back to the same discussion now and its painful and time
> > killing for all of us.
>
> There's bigger issues than where we put magic values as I raised in
> the other patch.
>
> > TBH, I don't have too strong preferences about any of the suggestions
> > you guys have and I need you guys to tell me what binding changes to
> > do here and I will do that.
> >
> >> If you have firmware
> >> partially managing things, then I think we should have platform specific
> >> bindings or drivers.
> >
> > What about the initial idea then, like "performance-state" for the
> > power domains ? All platforms will anyway replicate that binding only.
>
> I don't really know. I don't really care either. I'll probably go
> along with what everyone agrees to, but the only one I see any
> agreement from is Ulf. Also, it is pretty vague as to what platforms
> will use this. You claimed you can support QCom scenarios, but there's
> really no evidence that that is true.
Well, I sent out the code few days back based on these bindings and everyone can
see how these bindings will get used now.
> What I don't want to see is this
> merged and then we need something more yet again in a few months for
> another platform.
Sure, I get your concerns.
So what we need now is:
- Stephen to start responding and clarify all the doubts he had as being silent
isn't helping.
- Or Rajendra to post patches which can prove that this is usable. The last time
I had a chat with him, he confirmed that he will post patches after 4.15-rc1
and he should have posted them by now, but he didn't :(
--
viresh
next prev parent reply other threads:[~2017-12-28 4:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 10:21 [PATCH V8 0/3] OPP: Allow OPP table to be used for power-domains Viresh Kumar
2017-12-18 10:21 ` [PATCH V8 1/3] " Viresh Kumar
[not found] ` <9cd1e90c782a8569d098adb63bee7dd1387528c4.1513591822.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-21 22:06 ` Rob Herring
2017-12-18 10:21 ` [PATCH V8 3/3] OPP: Allow "opp-hz" and "opp-microvolt" to contain magic values Viresh Kumar
[not found] ` <476d7ae69184d787ccc6d99f8df6069007fd0a91.1513591822.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-26 20:29 ` Rob Herring
2017-12-27 8:56 ` Viresh Kumar
2017-12-27 21:54 ` Rob Herring
2017-12-28 4:37 ` Viresh Kumar [this message]
2017-12-29 0:32 ` Stephen Boyd
2017-12-29 4:58 ` Viresh Kumar
2018-01-05 22:19 ` Stephen Boyd
2018-01-08 4:16 ` Viresh Kumar
2018-01-10 2:54 ` Stephen Boyd
2018-01-10 5:37 ` Viresh Kumar
2018-01-13 0:46 ` Stephen Boyd
2018-01-02 6:05 ` Rajendra Nayak
[not found] ` <3721988e-fa13-c5dc-9ee6-490ed9b4b767-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-02 6:33 ` Viresh Kumar
[not found] ` <cover.1513591822.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-18 10:21 ` [PATCH V8 2/3] OPP: Introduce "required-opp" property Viresh Kumar
2017-12-20 8:23 ` Ulf Hansson
2017-12-20 8:26 ` Viresh Kumar
[not found] ` <6615035f294a64a4c17e5b44ac6690d1c2ac127c.1513591822.git.viresh.kumar-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2017-12-21 22:26 ` Rob Herring
2017-12-22 5:28 ` Viresh Kumar
2018-01-03 7:20 ` [PATCH V8 0/3] OPP: Allow OPP table to be used for power-domains Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171228043725.GB8652@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=robh@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sudeep.holla@arm.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).