From: Pavel Machek <pavel@ucw.cz>
To: Rob Herring <robh@kernel.org>
Cc: "Sakari Ailus" <sakari.ailus@linux.intel.com>,
mark.rutland@arm.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, pali.rohar@gmail.com,
sre@kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
clayton@craftyguy.net, martijn@brixit.nl,
"Filip Matijević" <filip.matijevic.pz@gmail.com>
Subject: [PATCHv3] dt-bindings: Avago APDS990X light sensor
Date: Mon, 8 Jan 2018 23:20:54 +0100 [thread overview]
Message-ID: <20180108222054.GA17452@amd> (raw)
In-Reply-To: <20180105160137.nr7oqvpbp2oao5fm@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]
Hi!
> > From: Filip Matijević <filip.matijevic.pz@gmail.com>
> >
> > This prepares binding for light sensor used in Nokia N9.
>
> "dt-bindings: ..." is the preferred subject prefix.
Ok.
> > +++ b/Documentation/devicetree/bindings/misc/avago-apds990x.txt
>
> Put this with other light sensors whether you use IIO or not:
>
> bindings/iio/light/
Makes sense. Patches to convert to IIO are available.
> > @@ -0,0 +1,41 @@
> > +Avago APDS990X driver
>
> Bindings aren't drivers.
Ok.
> > +https://docs.broadcom.com/docs/AV02-2867EN
> > +
> > +Required properties:
> > +- compatible: "avago,apds990x"
> > +- reg: address on the I2C bus
> > +- interrupts: external interrupt line number
> > +- vdd-supply: power supply for VDD
> > +- vled-supply: power supply for LEDA
> > +- avago,ga: Glass attenuation
>
> We already have "upisemi,glass-coef". Can we align on something
> common.
upisemi seems to have different units (1/1000 vs. 1/4096). Do you want
me to do change to avago,glass-coef or ....?
> > +- avago,cf1: Clear channel factor 1
> > +- avago,irf1: IR channel factor 1
> > +- avago,cf2: Clear channel factor 2
> > +- avago,irf2: IR channel factor 2
>
> Perhaps 2 properties with 2 cells for factor 1 and 2.
This is obviously easier to keep, but I can change.
> > +- avago,df: Device factor
>
> Units/range for all these?
Fixed point, with 4096 == 1.00.
> > +- avago,pdrive: IR current, one of APDS_IRLED_CURR_XXXmA values
>
> Don't we have standard current property for LEDs?
We do have "led-max-microamp"; which is not quite what this is. I
guess we can do "led-microamp" if you prefer?
> > +- avago,ppcount: Proximity pulse count
>
> Is this standard for prox sensors?
I don't know many proximity sensors. Seems like way to raise sensitivity.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-01-08 22:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-27 9:18 [PATCH] Device tree binding for Avago APDS990X light sensor Pavel Machek
2017-12-27 18:00 ` Sakari Ailus
[not found] ` <20171227180000.6ejpbqmr736nqx5i-sGAanXTfQ4777SC2UrCW1FMQynFLKtET@public.gmane.org>
2017-12-27 18:50 ` Filip Matijević
[not found] ` <7a5d43a9-27f5-bdbd-780f-6c6bc47fb987-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-12-27 21:15 ` Sakari Ailus
2017-12-27 20:01 ` Pavel Machek
2017-12-27 21:16 ` Sakari Ailus
2018-01-02 12:44 ` [PATCHv2] " Pavel Machek
2018-01-05 16:01 ` Rob Herring
2018-01-08 22:20 ` Pavel Machek [this message]
2018-01-10 8:53 ` [PATCH] dt-bindings: Nokia N9 audio support Pavel Machek
2018-01-10 9:39 ` Sakari Ailus
2018-01-10 11:31 ` Pavel Machek
2018-01-19 20:15 ` Rob Herring
2018-01-29 21:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180108222054.GA17452@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=clayton@craftyguy.net \
--cc=devicetree@vger.kernel.org \
--cc=filip.matijevic.pz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martijn@brixit.nl \
--cc=pali.rohar@gmail.com \
--cc=patrikbachan@gmail.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).