From: Simon Shields <simon@lineageos.org>
To: Andi Shyti <andi.shyti@samsung.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2] Input: mms114 - drop platform data and use generic APIs
Date: Tue, 16 Jan 2018 19:52:06 +1100 [thread overview]
Message-ID: <20180116085206.GA18232@lineageos.org> (raw)
In-Reply-To: <20180116075611.GC30945@gangnam.samsung>
Hi Andi,
Thanks for the review!
On Tue, Jan 16, 2018 at 04:56:11PM +0900, Andi Shyti wrote:
> Hi Simon,
>
> On Sat, Jan 13, 2018 at 01:04:56PM +1100, Simon Shields wrote:
> > The MMS114 platform data has no in-tree users, so drop it,
> > and make the driver depend on CONFIG_OF.
> >
> > Switch to using the standard touchscreen properties via
> > touchscreen_parse_properties(), and move the old DT parsing code
> > to use device_property_*() APIs.
> >
> > Finally, use touchscreen_report_pos to report x/y coordinates
> > and drop the custom x/y inversion code.
> >
> > Signed-off-by: Simon Shields <simon@lineageos.org>
> > ---
> > .../bindings/input/touchscreen/mms114.txt | 29 ++--
> > drivers/input/touchscreen/Kconfig | 1 +
> > drivers/input/touchscreen/mms114.c | 152 +++++++++------------
> > include/linux/platform_data/mms114.h | 24 ----
> > 4 files changed, 83 insertions(+), 123 deletions(-)
> > delete mode 100644 include/linux/platform_data/mms114.h
> >
>
> The patch looks good, but you would also need to update the dtsi
> files in this same patch:
>
> ./arch/arm/boot/dts/exynos4412-trats2.dts
> ./arch/arm/boot/dts/exynos4210-trats.dts
>
> and Cc the Samsung-soc mailing list.
>
> For now it's a nack because the touchscreen would not work
> anymore with the trats boards.
This patch keeps support for the old bindings. I've verified that both
the old and new bindings work on a GT-I9300 (trats2 with a different
bootloader/partition layout).
>
> One more thing, you forgot Rob's ACK.
I wasn't sure whether or not to keep the Reviewed-By tag, since
this is a new version of the patch. In the future, I'll keep it.
>
> Andi
Cheers,
Simon
next prev parent reply other threads:[~2018-01-16 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180113020518epcas1p3987c04ac42714710204aca5a800a4f5b@epcas1p3.samsung.com>
2018-01-13 2:04 ` [PATCH v2] Input: mms114 - drop platform data and use generic APIs Simon Shields
[not found] ` <20180113020456.12391-1-simon-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2018-01-16 7:56 ` Andi Shyti
2018-01-16 8:52 ` Simon Shields [this message]
2018-01-19 18:42 ` Rob Herring
[not found] ` <20180116085206.GA18232-WP75azK+jQYgsBAKwltoeQ@public.gmane.org>
2018-01-23 11:15 ` Andi Shyti
2018-01-24 19:37 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180116085206.GA18232@lineageos.org \
--to=simon@lineageos.org \
--cc=andi.shyti@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).