* [PATCH] ARM: dts: sun9i: Enable USB support on Cubieboard4
@ 2017-12-16 20:58 Mark Kettenis
[not found] ` <20171216205809.5485-1-kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2017-12-16 20:58 UTC (permalink / raw)
To: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
devicetree-u79uwXL29TY76Z2rM5mHXA
Cc: Mark Kettenis
On the Cubieboard4 HCI0 is directly connected to a USB connector,
and HCI2 is connected to a USB hub on the board. HCI1 is available
with HSIC throug 2 pins on the GPIO expansion header, but left
disabled just like on the Optimus board.
This patch also adds the VBUS regulators.
Signed-off-by: Mark Kettenis <kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org>
---
arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 36 +++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
index 4024639aa005..e38623265695 100644
--- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
+++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
@@ -74,6 +74,24 @@
};
};
+ reg_usb1_vbus: usb1-vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb2-drvbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ gpio = <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */
+ };
+
+ reg_usb3_vbus: usb3-vbus {
+ compatible = "regulator-fixed";
+ regulator-name = "usb1-drvbus";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ enable-active-high;
+ gpio = <&pio 7 14 GPIO_ACTIVE_HIGH>; /* PH14 */
+ };
+
wifi_pwrseq: wifi-pwrseq {
compatible = "mmc-pwrseq-simple";
clocks = <&ac100_rtc 1>;
@@ -83,6 +101,14 @@
};
};
+&ehci0 {
+ status = "okay";
+};
+
+&ehci2 {
+ status = "okay";
+};
+
&mmc0 {
pinctrl-names = "default";
pinctrl-0 = <&mmc0_pins>;
@@ -408,3 +434,13 @@
pinctrl-0 = <&uart0_ph_pins>;
status = "okay";
};
+
+&usbphy1 {
+ phy-supply = <®_usb1_vbus>;
+ status = "okay";
+};
+
+&usbphy3 {
+ phy-supply = <®_usb3_vbus>;
+ status = "okay";
+};
--
2.15.1
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: sun9i: Enable USB support on Cubieboard4
[not found] ` <20171216205809.5485-1-kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org>
@ 2018-01-20 6:12 ` Chen-Yu Tsai
[not found] ` <CAGb2v66XNAHwAU1eosYjGKgYKkh9YiVEooE9e45RSVvPOvhYLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2018-01-20 6:12 UTC (permalink / raw)
To: Maxime Ripard; +Cc: Mark Kettenis, linux-arm-kernel, devicetree
Maxime,
On Sun, Dec 17, 2017 at 4:58 AM, Mark Kettenis <kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org> wrote:
> On the Cubieboard4 HCI0 is directly connected to a USB connector,
> and HCI2 is connected to a USB hub on the board. HCI1 is available
> with HSIC throug 2 pins on the GPIO expansion header, but left
> disabled just like on the Optimus board.
>
> This patch also adds the VBUS regulators.
>
> Signed-off-by: Mark Kettenis <kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org>
Any thoughts on this patch?
It's similar to what I sent a few years back:
https://patchwork.kernel.org/patch/6359461/
ChenYu
> ---
> arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 36 +++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
> index 4024639aa005..e38623265695 100644
> --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
> +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
> @@ -74,6 +74,24 @@
> };
> };
>
> + reg_usb1_vbus: usb1-vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb2-drvbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + enable-active-high;
> + gpio = <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */
> + };
> +
> + reg_usb3_vbus: usb3-vbus {
> + compatible = "regulator-fixed";
> + regulator-name = "usb1-drvbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + enable-active-high;
> + gpio = <&pio 7 14 GPIO_ACTIVE_HIGH>; /* PH14 */
> + };
> +
> wifi_pwrseq: wifi-pwrseq {
> compatible = "mmc-pwrseq-simple";
> clocks = <&ac100_rtc 1>;
> @@ -83,6 +101,14 @@
> };
> };
>
> +&ehci0 {
> + status = "okay";
> +};
> +
> +&ehci2 {
> + status = "okay";
> +};
> +
> &mmc0 {
> pinctrl-names = "default";
> pinctrl-0 = <&mmc0_pins>;
> @@ -408,3 +434,13 @@
> pinctrl-0 = <&uart0_ph_pins>;
> status = "okay";
> };
> +
> +&usbphy1 {
> + phy-supply = <®_usb1_vbus>;
> + status = "okay";
> +};
> +
> +&usbphy3 {
> + phy-supply = <®_usb3_vbus>;
> + status = "okay";
> +};
> --
> 2.15.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: dts: sun9i: Enable USB support on Cubieboard4
[not found] ` <CAGb2v66XNAHwAU1eosYjGKgYKkh9YiVEooE9e45RSVvPOvhYLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2018-01-22 8:38 ` Maxime Ripard
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Ripard @ 2018-01-22 8:38 UTC (permalink / raw)
To: Chen-Yu Tsai; +Cc: Mark Kettenis, linux-arm-kernel, devicetree
[-- Attachment #1: Type: text/plain, Size: 2526 bytes --]
On Sat, Jan 20, 2018 at 02:12:04PM +0800, Chen-Yu Tsai wrote:
> Maxime,
>
> On Sun, Dec 17, 2017 at 4:58 AM, Mark Kettenis <kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org> wrote:
> > On the Cubieboard4 HCI0 is directly connected to a USB connector,
> > and HCI2 is connected to a USB hub on the board. HCI1 is available
> > with HSIC throug 2 pins on the GPIO expansion header, but left
> > disabled just like on the Optimus board.
> >
> > This patch also adds the VBUS regulators.
> >
> > Signed-off-by: Mark Kettenis <kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org>
>
> Any thoughts on this patch?
>
> It's similar to what I sent a few years back:
>
> https://patchwork.kernel.org/patch/6359461/
Given the previous discussion, I guess we should have much more
comments on how it is designed.
There was some effort to have power sequence for USB devices described
in the DT here:
https://patchwork.kernel.org/patch/9800887/
I guess pinging Peter to know the current state would be a good way
forward.
> > arch/arm/boot/dts/sun9i-a80-cubieboard4.dts | 36 +++++++++++++++++++++++++++++
> > 1 file changed, 36 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
> > index 4024639aa005..e38623265695 100644
> > --- a/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
> > +++ b/arch/arm/boot/dts/sun9i-a80-cubieboard4.dts
> > @@ -74,6 +74,24 @@
> > };
> > };
> >
> > + reg_usb1_vbus: usb1-vbus {
> > + compatible = "regulator-fixed";
> > + regulator-name = "usb2-drvbus";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + enable-active-high;
> > + gpio = <&pio 7 15 GPIO_ACTIVE_HIGH>; /* PH15 */
> > + };
> > +
> > + reg_usb3_vbus: usb3-vbus {
> > + compatible = "regulator-fixed";
> > + regulator-name = "usb1-drvbus";
> > + regulator-min-microvolt = <5000000>;
> > + regulator-max-microvolt = <5000000>;
> > + enable-active-high;
> > + gpio = <&pio 7 14 GPIO_ACTIVE_HIGH>; /* PH14 */
> > + };
You should also have a proper parenthood relationship here, and not
just leave these two regulators hanging around.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-22 8:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-16 20:58 [PATCH] ARM: dts: sun9i: Enable USB support on Cubieboard4 Mark Kettenis
[not found] ` <20171216205809.5485-1-kettenis-7YlrpqBBQ3VAfugRpC6u6w@public.gmane.org>
2018-01-20 6:12 ` Chen-Yu Tsai
[not found] ` <CAGb2v66XNAHwAU1eosYjGKgYKkh9YiVEooE9e45RSVvPOvhYLg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-22 8:38 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).