From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes
Date: Wed, 24 Jan 2018 12:02:22 +0100 [thread overview]
Message-ID: <20180124110222.cdglyg5m7644xiem@flea.lan> (raw)
In-Reply-To: <20180124103943.2062-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
Hi,
On Wed, Jan 24, 2018 at 11:39:43AM +0100, codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
> From: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Add the DAI blocks to the device tree. I2S0 and I2S1 are for
> connecting to an external codec.
>
> Signed-off-by: Marcus Cooper <codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 26 ++++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> index f060a58f374c..f3354f8c2026 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> @@ -419,6 +419,32 @@
> status = "disabled";
> };
>
> + i2s0: i2s@1c22000 {
> + #sound-dai-cells = <0>;
> + compatible = "allwinner,sun8i-h3-i2s";
Same remark than for the spdif, please add a soc-specific compatible.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-01-24 11:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 10:39 [PATCH 0/5] Add tested digital audio blocks to A64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20180124103943.2062-1-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 10:39 ` [linux-sunxi][PATCH 1/5] arm64: allwinner: a64: Add the SPDIF block codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20180124103943.2062-2-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 10:59 ` [PATCH " Maxime Ripard
2018-01-24 10:39 ` [PATCH 2/5] arm64: allwinner: a64: Add SPDIF TX pin to the A64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20180124103943.2062-3-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 11:00 ` [linux-sunxi][PATCH " Maxime Ripard
[not found] ` <20180124110031.kksmh56krinaivh7-ZC1Zs529Oq4@public.gmane.org>
2018-01-24 11:02 ` [PATCH " Chen-Yu Tsai
[not found] ` <CAGb2v67oFc0LRAcdvh-2F3HRkOui34ANp_-frB9exdvFBAirqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-24 11:40 ` Code Kipper
2018-01-24 10:39 ` [PATCH 3/5] arm64: allwinner: a64: Add SPDIF " codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20180124103943.2062-4-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 11:01 ` Maxime Ripard
[not found] ` <20180124110124.pgvk7bwesftgbjtj-ZC1Zs529Oq4@public.gmane.org>
2018-01-24 11:40 ` [linux-sunxi][PATCH " Code Kipper
2018-01-24 10:39 ` [linux-sunxi][PATCH 4/5] arm64: allwinner: a64: Add SPDIF to the Pine64 codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20180124103943.2062-5-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 12:10 ` Code Kipper
2018-01-24 10:39 ` [linux-sunxi][PATCH 5/5] arm64: allwinner: a64: Add DAI nodes codekipper-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <20180124103943.2062-6-codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-24 11:02 ` Maxime Ripard [this message]
[not found] ` <20180124110222.cdglyg5m7644xiem-ZC1Zs529Oq4@public.gmane.org>
2018-01-24 11:39 ` Code Kipper
[not found] ` <CAEKpxBk8NXJn4KxEGXx7UddqpUMC65kdEgx1phZDWyUd3ER_3Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25 8:29 ` [PATCH " Maxime Ripard
[not found] ` <20180125082904.t4sqob626kyzw4ga-ZC1Zs529Oq4@public.gmane.org>
2018-01-25 9:07 ` [linux-sunxi][PATCH " Code Kipper
[not found] ` <CAEKpxBmbz-dwF77PDs-mREHwDfXG3juXz7zUKcaMQKjz=1b+Fg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25 15:13 ` [PATCH " Maxime Ripard
2018-01-25 9:46 ` Code Kipper
[not found] ` <CAEKpxBmbhtGxk7hZMt3h7M_ih9njrwbtR7ooP4PT2kRD6xf=rw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-25 15:31 ` [linux-sunxi][PATCH " Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124110222.cdglyg5m7644xiem@flea.lan \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=codekipper-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).