devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
       [not found] ` <1516725734-32745-1-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
@ 2018-01-23 13:47   ` Lucas Stach
  2018-01-23 16:42   ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
                     ` (2 subsequent siblings)
  3 siblings, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-01-23 13:47 UTC (permalink / raw)
  To: Anson Huang, shawnguo-DgEjT+Ai2ygdnm+yROfE0A,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ, fabio.estevam-3arQi8VN3Tc,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, aisheng.dong-3arQi8VN3Tc,
	mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-imx-3arQi8VN3Tc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Am Mittwoch, den 24.01.2018, 00:42 +0800 schrieb Anson Huang:
> ARM power domain does NOT support runtime off, always-on
> flag should be set to avoid incorrect power state in
> pm_genpd_summary:
> 
> Before:
> 
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain                          status          slaves
>     /device                                             runtime status
> ----------------------------------------------------------------------
> ARM                             off-0
> 
> After:
> 
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain                          status          slaves
>     /device                                             runtime status
> ----------------------------------------------------------------------
> ARM                             on
> 
> Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>

Reviewed-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

> ---
>  drivers/soc/imx/gpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
> index 53f7275..6cafa9b 100644
> --- a/drivers/soc/imx/gpc.c
> +++ b/drivers/soc/imx/gpc.c
> @@ -254,6 +254,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
> >  	{
> >  		.base = {
> >  			.name = "ARM",
> > +			.flags = GENPD_FLAG_ALWAYS_ON,
> >  		},
> >  	}, {
> >  		.base = {
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
       [not found]     ` <1516725734-32745-2-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
@ 2018-01-23 13:48       ` Lucas Stach
  2018-01-25 10:33       ` Dong Aisheng
  1 sibling, 0 replies; 7+ messages in thread
From: Lucas Stach @ 2018-01-23 13:48 UTC (permalink / raw)
  To: Anson Huang, shawnguo-DgEjT+Ai2ygdnm+yROfE0A,
	kernel-bIcnvbaLZ9MEGnE8C9+IrQ, fabio.estevam-3arQi8VN3Tc,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, aisheng.dong-3arQi8VN3Tc,
	mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, Linux-imx-3arQi8VN3Tc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Am Mittwoch, den 24.01.2018, 00:42 +0800 schrieb Anson Huang:
> Add ARM power domain in PGC.
> 
> Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>

Reviewed-by: Lucas Stach <l.stach-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>

> ---
> this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
>  arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 42ef4c6..aa29ca6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -768,6 +768,11 @@
> >  					#address-cells = <1>;
> >  					#size-cells = <0>;
>  
> > +					power-domain@0 {
> > +						reg = <0>;
> > +						#power-domain-cells = <0>;
> > +					};
> +
> > >  					pd_pu: power-domain@1 {
> >  						reg = <1>;
> >  						#power-domain-cells = <0>;
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
@ 2018-01-23 16:42 Anson Huang
       [not found] ` <1516725734-32745-1-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
  0 siblings, 1 reply; 7+ messages in thread
From: Anson Huang @ 2018-01-23 16:42 UTC (permalink / raw)
  To: shawnguo, kernel, fabio.estevam, robh+dt, aisheng.dong,
	mark.rutland, linux
  Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel

ARM power domain does NOT support runtime off, always-on
flag should be set to avoid incorrect power state in
pm_genpd_summary:

Before:

root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain                          status          slaves
    /device                                             runtime status
----------------------------------------------------------------------
ARM                             off-0

After:

root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
domain                          status          slaves
    /device                                             runtime status
----------------------------------------------------------------------
ARM                             on

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
 drivers/soc/imx/gpc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/imx/gpc.c b/drivers/soc/imx/gpc.c
index 53f7275..6cafa9b 100644
--- a/drivers/soc/imx/gpc.c
+++ b/drivers/soc/imx/gpc.c
@@ -254,6 +254,7 @@ static struct imx_pm_domain imx_gpc_domains[] = {
 	{
 		.base = {
 			.name = "ARM",
+			.flags = GENPD_FLAG_ALWAYS_ON,
 		},
 	}, {
 		.base = {
-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
       [not found] ` <1516725734-32745-1-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
  2018-01-23 13:47   ` Lucas Stach
@ 2018-01-23 16:42   ` Anson Huang
       [not found]     ` <1516725734-32745-2-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
  2018-01-25 10:29   ` [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Dong Aisheng
  2018-02-05  6:33   ` Shawn Guo
  3 siblings, 1 reply; 7+ messages in thread
From: Anson Huang @ 2018-01-23 16:42 UTC (permalink / raw)
  To: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	fabio.estevam-3arQi8VN3Tc, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	aisheng.dong-3arQi8VN3Tc, mark.rutland-5wv7dgnIgG8,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw
  Cc: Linux-imx-3arQi8VN3Tc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Add ARM power domain in PGC.

Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>
---
this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
 arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
index 42ef4c6..aa29ca6 100644
--- a/arch/arm/boot/dts/imx6sx.dtsi
+++ b/arch/arm/boot/dts/imx6sx.dtsi
@@ -768,6 +768,11 @@
 					#address-cells = <1>;
 					#size-cells = <0>;
 
+					power-domain@0 {
+						reg = <0>;
+						#power-domain-cells = <0>;
+					};
+
 					pd_pu: power-domain@1 {
 						reg = <1>;
 						#power-domain-cells = <0>;
-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
       [not found] ` <1516725734-32745-1-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
  2018-01-23 13:47   ` Lucas Stach
  2018-01-23 16:42   ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
@ 2018-01-25 10:29   ` Dong Aisheng
  2018-02-05  6:33   ` Shawn Guo
  3 siblings, 0 replies; 7+ messages in thread
From: Dong Aisheng @ 2018-01-25 10:29 UTC (permalink / raw)
  To: Anson Huang
  Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	fabio.estevam-3arQi8VN3Tc, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	aisheng.dong-3arQi8VN3Tc, mark.rutland-5wv7dgnIgG8,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw, Linux-imx-3arQi8VN3Tc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Wed, Jan 24, 2018 at 12:42:13AM +0800, Anson Huang wrote:
> ARM power domain does NOT support runtime off, always-on
> flag should be set to avoid incorrect power state in
> pm_genpd_summary:
> 
> Before:
> 
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain                          status          slaves
>     /device                                             runtime status
> ----------------------------------------------------------------------
> ARM                             off-0
> 
> After:
> 
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain                          status          slaves
>     /device                                             runtime status
> ----------------------------------------------------------------------
> ARM                             on
> 
> Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>

Acked-by: Dong Aisheng <aisheng.dong-3arQi8VN3Tc@public.gmane.org>

Regards
Dong Aisheng
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support
       [not found]     ` <1516725734-32745-2-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
  2018-01-23 13:48       ` Lucas Stach
@ 2018-01-25 10:33       ` Dong Aisheng
  1 sibling, 0 replies; 7+ messages in thread
From: Dong Aisheng @ 2018-01-25 10:33 UTC (permalink / raw)
  To: Anson Huang
  Cc: shawnguo-DgEjT+Ai2ygdnm+yROfE0A, kernel-bIcnvbaLZ9MEGnE8C9+IrQ,
	fabio.estevam-3arQi8VN3Tc, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	aisheng.dong-3arQi8VN3Tc, mark.rutland-5wv7dgnIgG8,
	linux-I+IVW8TIWO2tmTQ+vhA3Yw, Linux-imx-3arQi8VN3Tc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Wed, Jan 24, 2018 at 12:42:14AM +0800, Anson Huang wrote:
> Add ARM power domain in PGC.
> 
> Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>
> ---
> this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
>  arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 42ef4c6..aa29ca6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -768,6 +768,11 @@
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> +					power-domain@0 {

Nitpick: probably an 'arm' prefix is better:
arm: power-domain@0

Anyway, it's minor depends on maintainer's perference.

Otherwise, looks fine

Acked-by: Dong Aisheng <aisheng.dong-3arQi8VN3Tc@public.gmane.org>

Regards
Dong Aisheng

> +						reg = <0>;
> +						#power-domain-cells = <0>;
> +					};
> +
>  					pd_pu: power-domain@1 {
>  						reg = <1>;
>  						#power-domain-cells = <0>;
> -- 
> 2.7.4
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on
       [not found] ` <1516725734-32745-1-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
                     ` (2 preceding siblings ...)
  2018-01-25 10:29   ` [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Dong Aisheng
@ 2018-02-05  6:33   ` Shawn Guo
  3 siblings, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2018-02-05  6:33 UTC (permalink / raw)
  To: Anson Huang
  Cc: kernel-bIcnvbaLZ9MEGnE8C9+IrQ, fabio.estevam-3arQi8VN3Tc,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A, aisheng.dong-3arQi8VN3Tc,
	mark.rutland-5wv7dgnIgG8, linux-I+IVW8TIWO2tmTQ+vhA3Yw,
	Linux-imx-3arQi8VN3Tc,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Wed, Jan 24, 2018 at 12:42:13AM +0800, Anson Huang wrote:
> ARM power domain does NOT support runtime off, always-on
> flag should be set to avoid incorrect power state in
> pm_genpd_summary:
> 
> Before:
> 
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain                          status          slaves
>     /device                                             runtime status
> ----------------------------------------------------------------------
> ARM                             off-0
> 
> After:
> 
> root@imx6qpdlsolox:~# cat /sys/kernel/debug/pm_genpd/pm_genpd_summary
> domain                          status          slaves
>     /device                                             runtime status
> ----------------------------------------------------------------------
> ARM                             on
> 
> Signed-off-by: Anson Huang <Anson.Huang-3arQi8VN3Tc@public.gmane.org>

Applied both, thanks.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-02-05  6:33 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23 16:42 [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Anson Huang
     [not found] ` <1516725734-32745-1-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
2018-01-23 13:47   ` Lucas Stach
2018-01-23 16:42   ` [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support Anson Huang
     [not found]     ` <1516725734-32745-2-git-send-email-Anson.Huang-3arQi8VN3Tc@public.gmane.org>
2018-01-23 13:48       ` Lucas Stach
2018-01-25 10:33       ` Dong Aisheng
2018-01-25 10:29   ` [PATCH 1/2] soc: imx: gpc: ARM power domain should be always-on Dong Aisheng
2018-02-05  6:33   ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).