From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH 08/10] ARM: dts: exynos: Use camera label in exynos4412-odroid-common Date: Sun, 4 Feb 2018 18:07:45 +0100 Message-ID: <20180204170745.qd5k7engoo22ktv2@kozik-lap> References: <1517586235-16603-1-git-send-email-m.purski@samsung.com> <1517586235-16603-9-git-send-email-m.purski@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <1517586235-16603-9-git-send-email-m.purski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Maciej Purski Cc: linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Kukjin Kim , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, m.szyprowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org, b.zolnierkie-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Fri, Feb 02, 2018 at 04:43:53PM +0100, Maciej Purski wrote: > Camera label has been defined in exynos4.dtsi. Use it in odroid-common > instead of defining a new node. > > Signed-off-by: Maciej Purski > --- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > index 556ea78..34f4e89 100644 > --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi > @@ -61,12 +61,6 @@ > reset-gpios = <&gpk1 2 GPIO_ACTIVE_LOW>; > }; > > - camera { > - status = "okay"; > - pinctrl-names = "default"; > - pinctrl-0 = <>; > - }; > - > fixed-rate-clocks { > xxti { > compatible = "samsung,clock-xxti"; > @@ -473,6 +467,12 @@ > }; > }; > > +&camera { Can you put it before &clock_audss? Not all entries are ordered already but at least this will keep a little bit of consistency. Best regards, Krzysztof > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <>; > +}; > + > &i2c_1 { > status = "okay"; > max98090: max98090@10 { > -- > 2.7.4 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html