Re: [PATCH v4 1/2] dt-bindings: ad5272: Add bindings for Analog Devices digital potentiometers

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Mon, Jan 29, 2018 at 09:12:53PM +0800, Phil Reid wrote:
> Add binding documentation for Analog Devices AD5272 and AD5274 digital
> potentiometer devices.
> 
> Signed-off-by: Phil Reid <preid-qgqNFa1JUf/o2iN0hyhwsIdd74u8MsAO@public.gmane.org>
> ---
>  .../bindings/iio/potentiometer/ad5272.txt          | 27 ++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt
> new file mode 100644
> index 0000000..11e804c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/potentiometer/ad5272.txt
> @@ -0,0 +1,27 @@
> +* Analog Devices AD5272 digital potentiometer driver

Bindings describe h/w not drivers.

> +
> +The node for this driver must be a child node of a I2C controller, hence
> +all mandatory properties for your controller must be specified. See directory:
> +
> +        Documentation/devicetree/bindings/i2c
> +
> +for more details.
> +
> +Required properties:
> +	- compatible:  	Must be one of the following, depending on the model:
> +			adi,ad5272-020
> +			adi,ad5272-050
> +			adi,ad5272-100
> +			adi,ad5274-020
> +			adi,ad5274-100
> +
> +Optional properties:
> + - reset-gpios: GPIO specification for the RESET input. This is an
> +		active low signal to the PCA953x.
> +
> +Example:
> +ad5272: ad5272@2f {

potentiometer@2f

Probably a node name we need to add to the spec.

> +	reg = <0x2F>;
> +	compatible = "adi,ad5272-020";
> +	reset-gpios = <&gpio3 6 GPIO_ACTIVE_HIGH>;
> +};
> -- 
> 1.8.3.1
>