From: Maxime Ripard <maxime.ripard@bootlin.com>
To: Emmanuel Vadot <manu@bidouilliste.com>
Cc: Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Revert "ARM: dts: sunxi: Add regulators for Sinovoip BPI-M2"
Date: Tue, 13 Feb 2018 11:30:13 +0100 [thread overview]
Message-ID: <20180213103013.37q3pg6cedxur4qp@flea.lan> (raw)
In-Reply-To: <c59ee4bd3246172ec62705967bb8f751@megadrive.org>
[-- Attachment #1: Type: text/plain, Size: 868 bytes --]
On Fri, Feb 09, 2018 at 10:20:57PM +0100, Emmanuel Vadot wrote:
> > P.S. a proper device tree with AXP shouldn't use
> > reg_vcc3v0/3v3/1v8/etc. They're dummy
> > regulator nodes for
> > not implemented or not controllable regulators.
> >
> > >
> > > > This indicates that this patch should be not tested at all.
> > >
> > > This have indeed not been tested with linux.
> > > I think that this commit should not be reverted, I'll send a proper
> > > patch tonight or tomorow night max.
> >
> > Please test patches sent to Linux on Linux :-)
>
> If my patches adhere to the bindings I don't see why.
Adhering to a binding and being functional is a completely different
story.
And the latter is the most important.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-02-13 10:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-03 11:23 [PATCH] Revert "ARM: dts: sunxi: Add regulators for Sinovoip BPI-M2" Icenowy Zheng
[not found] ` <20180203112353.13497-1-icenowy-h8G6r0blFSE@public.gmane.org>
2018-02-05 8:55 ` Emmanuel Vadot
[not found] ` <20180205095558.2e713c24cdb7c3232943db52-xXdDKFdH5B3kFDPD4ZthVA@public.gmane.org>
2018-02-05 9:05 ` Icenowy Zheng
2018-02-09 21:20 ` Emmanuel Vadot
2018-02-13 10:30 ` Maxime Ripard [this message]
[not found] ` <c59ee4bd3246172ec62705967bb8f751-/Q/jCV+WVIbNLxjTenLetw@public.gmane.org>
2018-02-13 10:36 ` Chen-Yu Tsai
2018-02-14 19:16 ` Emmanuel Vadot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213103013.37q3pg6cedxur4qp@flea.lan \
--to=maxime.ripard@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=manu@bidouilliste.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).