From: Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Denis OSTERLAND
<denis.osterland-85mDkmTllUAAvxtiuMwx3w@public.gmane.org>
Cc: "m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org"
<linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>,
"linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org"
<a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"jdelvare-IBi9RG/b67k@public.gmane.org"
<jdelvare-IBi9RG/b67k@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org"
<kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Subject: Re: [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits
Date: Thu, 15 Feb 2018 09:30:28 +0100 [thread overview]
Message-ID: <20180215083028.GH8219@piout.net> (raw)
In-Reply-To: <1518679666.5448.4.camel-85mDkmTllUAAvxtiuMwx3w@public.gmane.org>
On 15/02/2018 at 07:27:47 +0000, Denis OSTERLAND wrote:
> Am Mittwoch, den 14.02.2018, 21:26 +0100 schrieb Alexandre Belloni:
> > On 23/01/2018 at 13:17:58 +0100, Michael Grzeschik wrote:
> > >
> > > From: Denis Osterland <Denis.Osterland-85mDkmTllUAAvxtiuMwx3w@public.gmane.org>
> > >
> > > After successful
> > > sr = isl1208_i2c_set_regs(client, 0, regs, ISL1208_RTC_SECTION_LEN);
> > > sr will be 0.
> > > As a result
> > > sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR,
> > > sr & ~ISL1208_REG_SR_WRTC);
> > > is equal to
> > > sr = i2c_smbus_write_byte_data(client, ISL1208_REG_SR, 0);
> > > which clears all flags in SR.
> > >
> > > Add an additional read of SR, to have value of SR in sr again.
> > >
> > > Signed-off-by: Denis Osterland <Denis.Osterland-85mDkmTllUAAvxtiuMwx3w@public.gmane.org>
> > > Signed-off-by: Michael Grzeschik <m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > ---
> > > drivers/rtc/rtc-isl1208.c | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > Applied, thanks.
> >
> You are welcome.
>
> One question, shall we avoid resent this patch in v2 of this series?
> I ask because we are pretty far with the suggested changes.
>
No need to resend. If necessary, you can base v2 on top of rtc-next.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-02-15 8:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 12:17 [PATCH 0/4] rtc: isl1208: fixes, documentation and isl1219 support Michael Grzeschik
[not found] ` <20180123121801.4214-1-m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-01-23 12:17 ` [PATCH 1/4] rtc: isl1208: Fix unintended clear of SR bits Michael Grzeschik
[not found] ` <20180123121801.4214-2-m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-02-14 20:26 ` Alexandre Belloni
2018-02-15 7:27 ` Denis OSTERLAND
[not found] ` <1518679666.5448.4.camel-85mDkmTllUAAvxtiuMwx3w@public.gmane.org>
2018-02-15 8:30 ` Alexandre Belloni [this message]
2018-01-23 12:17 ` [PATCH 2/4] rtc: isl1208: Add device tree binding documentation Michael Grzeschik
2018-01-29 23:34 ` Rob Herring
2018-01-30 10:06 ` Alexandre Belloni
2018-01-23 12:18 ` [PATCH 4/4] rtc: isl1208: add support for isl1219 with hwmon for tamper detection Michael Grzeschik
[not found] ` <20180123121801.4214-5-m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-01-23 18:22 ` Guenter Roeck
2018-01-24 9:03 ` Michael Grzeschik
2018-01-24 12:10 ` Michael Grzeschik
[not found] ` <20180124090333.r5o2mzpm4q536w4r-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2018-01-29 21:59 ` Guenter Roeck
2018-01-30 10:27 ` Alexandre Belloni
[not found] ` <20180130102740.GD2809-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org>
2018-01-30 11:40 ` Denis OSTERLAND
[not found] ` <1517312409.5307.22.camel-85mDkmTllUAAvxtiuMwx3w@public.gmane.org>
2018-01-30 14:15 ` Guenter Roeck
2018-01-31 10:54 ` Alexandre Belloni
2018-01-29 23:41 ` Rob Herring
2018-01-30 8:56 ` Denis OSTERLAND
2018-01-30 14:41 ` Rob Herring
[not found] ` <CAL_JsqKEXtL0hvEgFALKaCgW2Go==wj14_dDomdK_hPU23oXLQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-01-30 14:44 ` Rob Herring
2018-01-23 12:18 ` [PATCH 3/4] rtc: isl1208: enable interrupt after context preparation Michael Grzeschik
2018-01-30 10:34 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180215083028.GH8219@piout.net \
--to=alexandre.belloni-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=a.zummo-BfzFCNDTiLLj+vYz1yj4TQ@public.gmane.org \
--cc=denis.osterland-85mDkmTllUAAvxtiuMwx3w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jdelvare-IBi9RG/b67k@public.gmane.org \
--cc=kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rtc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m.grzeschik-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).