From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [PATCH v2 19/19] ARM64: dts: r8a77965: Add EtherAVB device node Date: Wed, 21 Feb 2018 19:23:40 +0100 Message-ID: <20180221182340.wvdvgtv5pw7pvd3v@verge.net.au> References: <1519139541-18783-1-git-send-email-jacopo+renesas@jmondi.org> <1519139541-18783-20-git-send-email-jacopo+renesas@jmondi.org> <20180221100716.GF7203@w540> <20180221173106.vgyshbz3kkc4p3cu@verge.net.au> <321c6c8c-8853-ac00-7567-c0be82b510f4@cogentembedded.com> <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <35959135-cb3b-040a-1944-26845e0c07b0@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sergei Shtylyov Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jacopo mondi , magnus.damm@gmail.com, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, robh+dt@kernel.org, geert@linux-m68k.org, Jacopo Mondi , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, Feb 21, 2018 at 08:53:53PM +0300, Sergei Shtylyov wrote: > On 02/21/2018 08:38 PM, Sergei Shtylyov wrote: ... > >>>>>> + clocks = <&cpg CPG_MOD 812>; > >>>>>> + power-domains = <&sysc 32>; > >>>>>> + resets = <&cpg 812>; > >>>>>> + phy-mode = "rgmii-txid"; > >>>>> > >>>>> Why not just "rgmii"? TX delay is a board specific detail, no? > >>>>> > >>>> I admit I took this one straight from r8a7796 dtsi. > >>>> Would you like to me resend and change this? > >>> > >>> Yes, unless Simon would fix it while merging... > >> > >> Can I confirm the desired change is s/rgmii-txid/rgmii/ ? > > > > Yes. > > Apparently that means that this prop should be overridden in the board file > (which may not be an easy task given the board is Salvator-XS again). > > [...] Can we override it in r8a77965-salvator-x.dts or r8a77965-salvator-xs.dts? I feel that I'm missing an important point here.