From: kbuild test robot <lkp@intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Maxime Ripard <maxime.ripard@bootlin.com>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
kbuild-all@01.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Daniel Vetter <daniel.vetter@intel.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 05/10] drm/sun4i: Add Allwinner A31 MIPI-DSI controller support
Date: Wed, 21 Feb 2018 22:48:22 +0800 [thread overview]
Message-ID: <201802212257.bepJa57u%fengguang.wu@intel.com> (raw)
In-Reply-To: <60ecb81e876f2c41584e5ccc55005cf12da5dc94.1519204731.git-series.maxime.ripard@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 2612 bytes --]
Hi Maxime,
I love your patch! Perhaps something to improve:
[auto build test WARNING on ]
url: https://github.com/0day-ci/linux/commits/Maxime-Ripard/drm-sun4i-Allwinner-MIPI-DSI-support/20180221-203150
base:
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm
All warnings (new ones prefixed by >>):
drivers/gpu/drm/sun4i/sun4i_tcon.c: In function 'sun4i_tcon_mode_set':
>> drivers/gpu/drm/sun4i/sun4i_tcon.c:606:30: warning: passing argument 1 of 'encoder_to_sun6i_dsi' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
dsi = encoder_to_sun6i_dsi(encoder);
^~~~~~~
In file included from drivers/gpu/drm/sun4i/sun4i_tcon.c:37:0:
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h:54:33: note: expected 'struct drm_encoder *' but argument is of type 'const struct drm_encoder *'
static inline struct sun6i_dsi *encoder_to_sun6i_dsi(struct drm_encoder *encoder)
^~~~~~~~~~~~~~~~~~~~
vim +606 drivers/gpu/drm/sun4i/sun4i_tcon.c
593
594 void sun4i_tcon_mode_set(struct sun4i_tcon *tcon,
595 const struct drm_encoder *encoder,
596 const struct drm_display_mode *mode)
597 {
598 struct sun6i_dsi *dsi;
599
600 switch (encoder->encoder_type) {
601 case DRM_MODE_ENCODER_DSI:
602 /*
603 * This is not really elegant, but it's the "cleaner"
604 * way I could think of...
605 */
> 606 dsi = encoder_to_sun6i_dsi(encoder);
607 sun4i_tcon0_mode_set_cpu(tcon, dsi->device, mode);
608 break;
609 case DRM_MODE_ENCODER_LVDS:
610 sun4i_tcon0_mode_set_lvds(tcon, encoder, mode);
611 break;
612 case DRM_MODE_ENCODER_NONE:
613 sun4i_tcon0_mode_set_rgb(tcon, mode);
614 sun4i_tcon_set_mux(tcon, 0, encoder);
615 break;
616 case DRM_MODE_ENCODER_TVDAC:
617 case DRM_MODE_ENCODER_TMDS:
618 sun4i_tcon1_mode_set(tcon, mode);
619 sun4i_tcon_set_mux(tcon, 1, encoder);
620 break;
621 default:
622 DRM_DEBUG_DRIVER("Unknown encoder type, doing nothing...\n");
623 }
624 }
625 EXPORT_SYMBOL(sun4i_tcon_mode_set);
626
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65152 bytes --]
[-- Attachment #3: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-02-21 14:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 9:20 [PATCH v2 00/10] drm/sun4i: Allwinner MIPI-DSI support Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 01/10] regmap: mmio: Add function to attach a clock Maxime Ripard
2018-02-26 11:17 ` Applied "regmap: mmio: Add function to attach a clock" to the regmap tree Mark Brown
2018-02-26 13:12 ` [PATCH v2 01/10] regmap: mmio: Add function to attach a clock Mark Brown
2018-02-21 9:20 ` [PATCH v2 02/10] drm/sun4i: tcon: Add TRI finish interrupt for vblank Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 03/10] drm/sun4i: Protect the TCON pixel clocks Maxime Ripard
2018-02-23 14:05 ` [v2,03/10] " Giulio Benetti
2018-02-23 23:31 ` Giulio Benetti
2018-02-26 11:15 ` Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 04/10] dt-bindings: display: Add Allwinner MIPI-DSI bindings Maxime Ripard
2018-03-01 22:15 ` Rob Herring
2018-03-06 13:23 ` Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 05/10] drm/sun4i: Add Allwinner A31 MIPI-DSI controller support Maxime Ripard
2018-02-21 14:48 ` kbuild test robot [this message]
2018-02-21 9:20 ` [PATCH v2 06/10] dt-bindings: vendor: Add Huarui Lighting Maxime Ripard
2018-03-01 22:38 ` Rob Herring
2018-02-21 9:20 ` [PATCH v2 07/10] dt-bindings: panel: Add Huarui LHR050H41 panel documentation Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 08/10] drm/panel: Add Huarui LHR050H41 panel driver Maxime Ripard
2018-02-21 15:05 ` [RFC PATCH] drm/panel: lhr050h41_init[] can be static kbuild test robot
2018-02-21 15:05 ` [PATCH v2 08/10] drm/panel: Add Huarui LHR050H41 panel driver kbuild test robot
2018-02-21 15:36 ` Chen-Yu Tsai
2018-03-02 9:52 ` Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 09/10] arm: dts: sun8i: a33: Add the DSI-related nodes Maxime Ripard
2018-02-21 9:20 ` [PATCH v2 10/10] [DO NOT MERGE] arm: dts: sun8i: bpi-m2m: Add DSI display Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201802212257.bepJa57u%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=broonie@kernel.org \
--cc=daniel.vetter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=kbuild-all@01.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).