From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH v1 1/3] mtd: physmap: add dual die entry in devicetree binding Date: Fri, 23 Feb 2018 16:53:40 +0100 Message-ID: <20180223165340.24bb2c6c@bbrezillon> References: <1519241514-6466-1-git-send-email-beanhuo@outlook.com> <20180222140542.47340842@bbrezillon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Bean Huo Cc: "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "boris.brezillon@free-electrons.com" , "richard@nod.at" , "marek.vasut@gmail.com" , "robh+dt@kernel.org" , "linux-mtd@lists.infradead.org" , "cyrille.pitchen@wedev4u.fr" , "computersforpeace@gmail.com" , "dwmw2@infradead.org" , beanhuo List-Id: devicetree@vger.kernel.org On Fri, 23 Feb 2018 11:07:17 +0000 Bean Huo wrote: > Boris, > thanks for the review. > > >> + - dual-die-stack: boolean to enable support for the devices with the > >> + two dies in stack. > > >How about making that more future proof and adding a property that > >directly contains the number of dies (num-dies)? > > Exactly, I also thought here should add a property, through which it can be compatible > with all kinds of PNOR for the future more dies stacked device. > But currently, it doesn't exist PNOR device with more than two dies, and we > have no idea about 4/6 dies stacked device operation sequence. so I simply add a boolean > entry and try to only enable dual-die stacked PNOR firstly. Actually, I think it's better to think about future evolutions now than adding a new property every time a vendor decides to add more dies (I guess the number of dies will always be a power-of-2). > > Maybe I can try to do that in next version patch. the software implementation is so flexible. > > >> > >> For JEDEC compatible devices, the following additional properties > >> are defined: > -- Boris Brezillon, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering https://bootlin.com ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/