From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH v2 2/4] arm64: add basic DTS for i.MX8MQ Date: Mon, 26 Feb 2018 15:09:58 +0800 Message-ID: <20180226070957.GU3217@dragon> References: <20180201183126.32384-1-l.stach@pengutronix.de> <20180201183126.32384-2-l.stach@pengutronix.de> <20180226031700.GS3217@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "A.s. Dong" Cc: Mark Rutland , "devicetree@vger.kernel.org" , Baruch Siach , Catalin Marinas , Will Deacon , "patchwork-lst@pengutronix.de" , Rob Herring , dl-linux-imx , "kernel@pengutronix.de" , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , Lucas Stach List-Id: devicetree@vger.kernel.org On Mon, Feb 26, 2018 at 06:52:15AM +0000, A.s. Dong wrote: > Hi Shawn, > > > -----Original Message----- > > From: Shawn Guo [mailto:shawnguo@kernel.org] > > Sent: Monday, February 26, 2018 11:17 AM > > To: A.s. Dong > > Cc: Lucas Stach ; Mark Rutland > > ; devicetree@vger.kernel.org; Baruch Siach > > ; Catalin Marinas ; Will > > Deacon ; patchwork-lst@pengutronix.de; Rob > > Herring ; dl-linux-imx ; > > kernel@pengutronix.de; Fabio Estevam ; linux- > > arm-kernel@lists.infradead.org > > Subject: Re: [PATCH v2 2/4] arm64: add basic DTS for i.MX8MQ > > > > On Sun, Feb 25, 2018 at 10:47:11AM +0000, A.s. Dong wrote: > > > > Documentation/devicetree/bindings/arm/fsl.txt | 4 + > > > > arch/arm64/boot/dts/freescale/imx8mq-pinfunc.h | 623 > > > > +++++++++++++++++++++++++ > > > > > > Should this belongs to pinctrl part? > > > > No. Those pinfunc defines are used by device tree rather than pinctrl driver. > > > > I had this question because we have below info in the patch > "dt-bindings: add binding for i.MX8MQ IOMUXC": > > diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > new file mode 100644 > index 0000000..5c5d2d8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > @@ -0,0 +1,39 @@ > ... > + Refer to imx8mq-pinfunc.h in device tree source folder for all available > + imx8mq PIN_FUNC_ID. This is just a cross reference in document, and should be okay on different tree during development cycle. If we have the pinfunc header go via pinctrl tree, we will have a more serious dependency between DT and pinctrl tree. Shawn