From: Tony Lindgren <tony@atomide.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: "Kishon Vijay Abraham I" <kishon@ti.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Russell King" <linux@armlinux.org.uk>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node
Date: Wed, 28 Feb 2018 14:34:21 -0800 [thread overview]
Message-ID: <20180228223421.GM5448@atomide.com> (raw)
In-Reply-To: <4f18dab9-aee3-1023-d301-f142c6e2d358@ti.com>
* Sekhar Nori <nsekhar@ti.com> [180213 11:11]:
> On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote:
> > Hi,
> >
> > On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote:
> >> Kishon,
> >>
> >> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote:
> >>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes.
> >>>
> >>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> >>
> >> Along with this, dont we need to have
> >>
> >> /delete-property/ mmc-hs200-1_8v;
> >>
> >> for eMMC on Beagle x15 which does not support HS200?
> >>
> >> Or are you planning to depend on lack of pinctrl entries for HS200 to
> >> take care of that?
> >
> > right now it relies on lack of pinctrl entries but I think adding delete
> > property is appropriate. Actually I missed porting the patch that adds
> > /delete-property/.
>
> Actually, thinking more, this should be probably be handled using
> "no-1-8-v" property. Reading the comment above SDHCI_QUIRK2_NO_1_8_V, it
> is specifically meant for the case when system (board) does not support
> 1.8V even when host (controller) does. Which is exactly the case with
> Beagle x15.
OK so that seems to be related to the last patch. I've applied
the first two defconfig patches into omap-for-v4.17/defconfig
and patches up to patch 13/15 into omap-for-v4.17/dt-sdhci.
Kishon, please repost the missing changes or ping me when
the driver dependencies have cleared for further patches to
be applied to enable sdhci.
Regards,
Tony
next prev parent reply other threads:[~2018-02-28 22:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-06 12:57 [PATCH v2 00/15] dra7: mmc: Update mmc dt node Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 01/15] ARM: multi_v7_defconfig: Enable CONFIG_MMC_SDHCI_OMAP Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 02/15] ARM: omap2plus_defconfig: " Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 03/15] ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 04/15] ARM: dts: dra76-evm: Shift to using common " Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 05/15] ARM: dts: dra76-evm: Add pinctrl data for higher speed MMC/SD modes Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 06/15] ARM: dts: am57xx-beagle-x15: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2018-02-06 12:57 ` [PATCH v2 07/15] ARM: dts: dra7-evm: Remove mmc specific pinmux Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 09/15] ARM: dts: am57xx-idk: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 10/15] ARM: dts: dra76-evm: " Kishon Vijay Abraham I
[not found] ` <20180206125806.19350-1-kishon-l0cyMroinI0@public.gmane.org>
2018-02-06 12:57 ` [PATCH v2 08/15] ARM: dts: dra7-evm: " Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 11/15] ARM: dts: dra71-evm: Correct evm_sd regulator max voltage Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 12/15] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 13/15] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 14/15] ARM: dts: dra7: Use sdhci-omap programming model Kishon Vijay Abraham I
2018-02-06 12:58 ` [PATCH v2 15/15] ARM: dts: dra7: Add high speed modes capability to MMC1/MMC2 dt node Kishon Vijay Abraham I
[not found] ` <20180206125806.19350-16-kishon-l0cyMroinI0@public.gmane.org>
2018-02-07 9:11 ` Sekhar Nori
2018-02-07 9:21 ` Kishon Vijay Abraham I
[not found] ` <b411cf11-61e9-e688-6f04-e624fe52ac66-l0cyMroinI0@public.gmane.org>
2018-02-07 9:27 ` Sekhar Nori
2018-02-13 11:10 ` Sekhar Nori
2018-02-28 22:34 ` Tony Lindgren [this message]
2018-03-01 5:18 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180228223421.GM5448@atomide.com \
--to=tony@atomide.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).