From: Bjorn Helgaas <helgaas@kernel.org>
To: Shawn Guo <shawn.guo@linaro.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Rob Herring <robh+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Jianguo Sun <sunjianguo1@huawei.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
Jiancheng Xue <xuejiancheng@hisilicon.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH v2 0/2] Add power control for pcie-histb driver
Date: Thu, 1 Mar 2018 09:08:22 -0600 [thread overview]
Message-ID: <20180301150822.GA13722@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20180301012241.GA28619@dragon>
[+cc Lorenzo]
On Thu, Mar 01, 2018 at 09:22:46AM +0800, Shawn Guo wrote:
> On Tue, Jan 23, 2018 at 11:45:35PM +0800, Shawn Guo wrote:
> > The first patch is a small fix which is useful for the second one.
> > This version basically follows Fabio's suggestion to reimplement the
> > first version patch, using a regulator that can be backed by GPIO to
> > control the power to PCIe port.
> >
> > Shawn Guo (2):
> > PCI: histb: fix error path of histb_pcie_host_enable()
> > PCI: histb: add an optional regulator for PCIe port power control
> >
> > .../bindings/pci/hisilicon-histb-pcie.txt | 1 +
> > drivers/pci/dwc/pcie-histb.c | 28 ++++++++++++++++++----
> > 2 files changed, 25 insertions(+), 4 deletions(-)
>
> Hi Bjorn,
>
> Did you get a chance to look at the series?
I cc'd Lorenzo, who is now taking care of this area.
If/when you repost this, please incorporate Rob's ack and capitalize
the first word of your summary ("Fix", "Add") to match the drivers/pci
convention.
Also, the original post used "PCI: hisi:", but here you use
"PCI: histb:". It probably does make sense to distinguish
"hisi" from "histb", but I want it to be a conscious choice
so future patches can be consistent with it.
Bjorn
next prev parent reply other threads:[~2018-03-01 15:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 15:45 [PATCH v2 0/2] Add power control for pcie-histb driver Shawn Guo
[not found] ` <1516722337-1533-1-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-23 15:45 ` [PATCH v2 1/2] PCI: histb: fix error path of histb_pcie_host_enable() Shawn Guo
2018-01-23 15:45 ` [PATCH v2 2/2] PCI: histb: add an optional regulator for PCIe port power control Shawn Guo
[not found] ` <1516722337-1533-3-git-send-email-shawn.guo-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-30 0:07 ` Rob Herring
2018-03-01 15:09 ` Bjorn Helgaas
2018-03-01 1:22 ` [PATCH v2 0/2] Add power control for pcie-histb driver Shawn Guo
2018-03-01 15:08 ` Bjorn Helgaas [this message]
2018-03-01 18:11 ` Lorenzo Pieralisi
2018-03-02 0:43 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301150822.GA13722@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawn.guo@linaro.org \
--cc=sunjianguo1@huawei.com \
--cc=xuejiancheng@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).