From: Rob Herring <robh@kernel.org>
To: Oleh Kravchenko <oleg@kaa.org.ua>
Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v3] leds: add LED driver for CR0014114 board
Date: Sun, 18 Mar 2018 07:49:25 -0500 [thread overview]
Message-ID: <20180318124925.i4yuxigkfu6spv26@rob-hp-laptop> (raw)
In-Reply-To: <20180313124548.12074-1-oleg@kaa.org.ua>
On Tue, Mar 13, 2018 at 02:45:48PM +0200, Oleh Kravchenko wrote:
> This patch adds a LED class driver for the RGB LEDs found on
> the Crane Merchandising System CR0014114 LEDs board.
>
> Signed-off-by: Oleh Kravchenko <oleg@kaa.org.ua>
> ---
> .../devicetree/bindings/leds/leds-cr0014114.txt | 46 ++++
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
Please split to separate patch.
> drivers/leds/Kconfig | 13 +
> drivers/leds/Makefile | 1 +
> drivers/leds/leds-cr0014114.c | 292 +++++++++++++++++++++
> 5 files changed, 353 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/leds-cr0014114.txt
> create mode 100644 drivers/leds/leds-cr0014114.c
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-cr0014114.txt b/Documentation/devicetree/bindings/leds/leds-cr0014114.txt
> new file mode 100644
> index 000000000000..977a9929b04f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/leds-cr0014114.txt
> @@ -0,0 +1,46 @@
> +Crane Merchandising System - cr0014114 LED driver
> +-------------------------------------------------
> +
> +This LED Board is widely used in vending machines produced
> +by Crane Merchandising Systems.
> +
> +Required properties:
> +- compatible: "cms,cr0014114"
> +- reg: chip select address for the device
> +- spi-cpha: shifted clock phase mode is required
> +
> +LED sub-node properties:
> +- label : (optional)
> + see Documentation/devicetree/bindings/leds/common.txt
> +- linux,default-trigger : (optional)
> + see Documentation/devicetree/bindings/leds/common.txt
> +
> +Example
> +-------
> +
> +cr0014114@0 {
leds@...
> + compatible = "crane,cr0014114";
> + reg = <0>;
> + spi-max-frequency = <50000>;
> + spi-cpha;
> +
> + led0 {
Is '0' meaningful to the controller as an address/channel. If so, use
reg.
> + label = "cr0:red:";
> + };
> + led1 {
> + label = "cr0:green:";
> + };
> + led2 {
> + label = "cr0:blue:";
> + };
> + led3 {
> + label = "cr1:red:";
> + };
> + led4 {
> + label = "cr1:green:";
> + };
> + led5 {
> + label = "cr1:blue:";
> + };
> + ...
> +};
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index ae850d6c0ad3..f17949c365f5 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -75,6 +75,7 @@ cnxt Conexant Systems, Inc.
> compulab CompuLab Ltd.
> cortina Cortina Systems, Inc.
> cosmic Cosmic Circuits
> +crane Crane Connectivity Solutions
> creative Creative Technology Ltd
> crystalfontz Crystalfontz America, Inc.
> cubietech Cubietech, Ltd.
next prev parent reply other threads:[~2018-03-18 12:49 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <026d9ec2-f2bd-18b9-d5fa-f593d40e2f57@kaa.org.ua>
2018-03-12 15:33 ` [PATCH] leds: add LED driver for CR0014114 board Oleh Kravchenko
2018-03-12 15:45 ` Peter Meerwald-Stadler
2018-03-12 15:54 ` Oleh Kravchenko
2018-03-17 8:19 ` Jacek Anaszewski
2018-03-12 15:58 ` [PATCH v2] " Oleh Kravchenko
2018-03-13 12:45 ` [PATCH v3] " Oleh Kravchenko
2018-03-16 21:14 ` Pavel Machek
2018-03-16 21:29 ` Oleh Kravchenko
2018-03-16 21:33 ` Pavel Machek
2018-03-16 21:40 ` Oleh Kravchenko
2018-03-16 22:10 ` Pavel Machek
2018-03-26 12:15 ` [PATCH v4 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Oleh Kravchenko
2018-03-26 12:15 ` [PATCH v4 2/2] leds: add LED driver for CR0014114 board Oleh Kravchenko
2018-03-27 16:14 ` [PATCH v4 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Rob Herring
2018-03-27 16:49 ` [PATCH " Oleh Kravchenko
2018-03-27 16:49 ` [PATCH 2/2] leds: add LED driver for CR0014114 board Oleh Kravchenko
2018-03-27 20:58 ` Jacek Anaszewski
2018-03-28 6:53 ` [PATCH v6 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Oleh Kravchenko
2018-03-28 6:53 ` [PATCH v6 2/2] leds: add LED driver for CR0014114 board Oleh Kravchenko
2018-03-28 15:43 ` [PATCH v6 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Rob Herring
2018-03-28 18:56 ` [PATCH v7 " Oleh Kravchenko
2018-03-28 18:56 ` [PATCH v7 2/2] leds: add LED driver for CR0014114 board Oleh Kravchenko
2018-04-02 12:53 ` [PATCH v8 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Oleh Kravchenko
2018-04-02 12:53 ` [PATCH v8 2/2] leds: add LED driver for CR0014114 board Oleh Kravchenko
2018-04-03 10:48 ` Pavel Machek
2018-04-10 18:59 ` Jacek Anaszewski
2018-04-10 20:24 ` Oleh Kravchenko
2018-04-09 19:18 ` [PATCH v8 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Jacek Anaszewski
2018-04-09 21:10 ` Rob Herring
2018-03-27 20:58 ` [PATCH " Jacek Anaszewski
2018-03-28 6:36 ` Oleh Kravchenko
2018-03-28 19:21 ` Jacek Anaszewski
2018-03-28 19:48 ` Oleh Kravchenko
2018-03-28 20:23 ` Jacek Anaszewski
2018-03-29 18:56 ` Oleh Kravchenko
2018-03-30 10:10 ` Jacek Anaszewski
2018-03-18 12:49 ` Rob Herring [this message]
2018-03-18 20:03 ` [PATCH v3] leds: add LED driver for CR0014114 board Jacek Anaszewski
2018-03-18 23:38 ` Rob Herring
2018-03-19 21:18 ` Standardized LED function names [was: Re: [PATCH v3] leds: add LED driver for CR0014114 board] Jacek Anaszewski
2018-03-27 15:31 ` Rob Herring
2018-03-30 10:53 ` Jacek Anaszewski
2018-03-30 20:59 ` Rob Herring
2018-04-15 16:15 ` Pavel Machek
2018-04-15 18:30 ` Jacek Anaszewski
2018-04-15 16:15 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180318124925.i4yuxigkfu6spv26@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=oleg@kaa.org.ua \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).