From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 27 Mar 2018 11:14:46 -0500 From: Rob Herring Subject: Re: [PATCH v4 1/2] dt-bindings: Add vendor prefix and docs for CR0014114 Message-ID: <20180327161446.cyay3rmpjbin5mu6@rob-hp-laptop> References: <20180326121506.9528-1-oleg@kaa.org.ua> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180326121506.9528-1-oleg@kaa.org.ua> To: Oleh Kravchenko Cc: devicetree@vger.kernel.org, linux-leds@vger.kernel.org List-ID: On Mon, Mar 26, 2018 at 03:15:05PM +0300, Oleh Kravchenko wrote: > Signed-off-by: Oleh Kravchenko Commit message? > --- > .../devicetree/bindings/leds/leds-cr0014114.txt | 49 ++++++++++++++++++++++ > .../devicetree/bindings/vendor-prefixes.txt | 1 + > 2 files changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/leds/leds-cr0014114.txt > > diff --git a/Documentation/devicetree/bindings/leds/leds-cr0014114.txt b/Documentation/devicetree/bindings/leds/leds-cr0014114.txt > new file mode 100644 > index 000000000000..0818ac6c6ffa > --- /dev/null > +++ b/Documentation/devicetree/bindings/leds/leds-cr0014114.txt > @@ -0,0 +1,49 @@ > +Crane Merchandising System - cr0014114 LED driver > +------------------------------------------------- > + > +This LED Board is widely used in vending machines produced > +by Crane Merchandising Systems. > + > +Required properties: > +- compatible: "crane,cr0014114" > + > +LED sub-node properties: > +- label : > + see Documentation/devicetree/bindings/leds/common.txt > +- linux,default-trigger : (optional) > + see Documentation/devicetree/bindings/leds/common.txt > + > +Example > +------- > + > +led-controller@0 { A unit-address needs a matching reg property. What happened to the SPI related properties? I think Jacek's comment was just about dropping spi-cpha. > + compatible = "crane,cr0014114"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@0 { > + reg = <0>; > + label = "cr0:red:coin"; > + }; > + led@1 { > + reg = <1>; > + label = "cr0:green:coin"; > + }; > + led@2 { > + reg = <2>; > + label = "cr0:blue:coin"; > + }; > + led@3 { > + reg = <3>; > + label = "cr1:red:bill"; > + }; > + led@4 { > + reg = <4>; > + label = "cr1:green:bill"; > + }; > + led@5 { > + reg = <5>; > + label = "cr1:blue:bill"; > + }; > + ... > +}; > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt > index ae850d6c0ad3..f17949c365f5 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.txt > +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt > @@ -75,6 +75,7 @@ cnxt Conexant Systems, Inc. > compulab CompuLab Ltd. > cortina Cortina Systems, Inc. > cosmic Cosmic Circuits > +crane Crane Connectivity Solutions > creative Creative Technology Ltd > crystalfontz Crystalfontz America, Inc. > cubietech Cubietech, Ltd. > -- > 2.16.1 > > -- > To unsubscribe from this list: send the line "unsubscribe devicetree" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html