From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Gregory Clement <gregory.clement@bootlin.com>,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Antoine Tenart <antoine.tenart@bootlin.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
Nadav Haklai <nadavh@marvell.com>,
David Sniatkiwicz <davidsn@marvell.com>,
Rob Herring <robh+dt@kernel.org>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 01/27] thermal: armada: add a function that sanitizes the thermal zone name
Date: Sat, 21 Apr 2018 17:12:29 +0200 [thread overview]
Message-ID: <20180421151255.29929-2-miquel.raynal@bootlin.com> (raw)
In-Reply-To: <20180421151255.29929-1-miquel.raynal@bootlin.com>
Thermal zone names must follow certain rules imposed by the framework.
They are limited in length and shall not have any hyphen '-'.
This is done in a separate function for future use in another location.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
---
drivers/thermal/armada_thermal.c | 36 +++++++++++++++++++++++++++++++++++-
1 file changed, 35 insertions(+), 1 deletion(-)
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 4c275ec10ac5..077e8e562306 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -70,6 +70,7 @@ struct armada_thermal_priv {
void __iomem *status;
void __iomem *control0;
void __iomem *control1;
+ char zone_name[THERMAL_NAME_LENGTH];
struct armada_thermal_data *data;
};
@@ -353,6 +354,36 @@ static const struct of_device_id armada_thermal_id_table[] = {
};
MODULE_DEVICE_TABLE(of, armada_thermal_id_table);
+static void armada_set_sane_name(struct platform_device *pdev,
+ struct armada_thermal_priv *priv)
+{
+ const char *name = dev_name(&pdev->dev);
+ char *insane_char;
+
+ if (strlen(name) > THERMAL_NAME_LENGTH) {
+ /*
+ * When inside a system controller, the device name has the
+ * form: f06f8000.system-controller:ap-thermal so stripping
+ * after the ':' should give us a shorter but meaningful name.
+ */
+ name = strrchr(name, ':');
+ if (!name)
+ name = "armada_thermal";
+ else
+ name++;
+ }
+
+ /* Save the name locally */
+ strncpy(priv->zone_name, name, THERMAL_NAME_LENGTH);
+
+ /* Then check there are no '-' or hwmon core will complain */
+ do {
+ insane_char = strpbrk(priv->zone_name, "-");
+ if (insane_char)
+ *insane_char = '_';
+ } while (insane_char);
+}
+
static int armada_thermal_probe(struct platform_device *pdev)
{
void __iomem *control = NULL;
@@ -381,6 +412,9 @@ static int armada_thermal_probe(struct platform_device *pdev)
priv->data = (struct armada_thermal_data *)match->data;
+ /* Ensure device name is correct for the thermal core */
+ armada_set_sane_name(pdev, priv);
+
/*
* Legacy DT bindings only described "control1" register (also referred
* as "control MSB" on old documentation). New bindings cover
@@ -402,7 +436,7 @@ static int armada_thermal_probe(struct platform_device *pdev)
priv->data->init_sensor(pdev, priv);
- thermal = thermal_zone_device_register(dev_name(&pdev->dev), 0, 0, priv,
+ thermal = thermal_zone_device_register(priv->zone_name, 0, 0, priv,
&ops, NULL, 0, 0);
if (IS_ERR(thermal)) {
dev_err(&pdev->dev,
--
2.14.1
next prev parent reply other threads:[~2018-04-21 15:12 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 15:12 [PATCH 00/27] Add multi-channel and overheat IRQ support to Armada thermal driver Miquel Raynal
2018-04-21 15:12 ` Miquel Raynal [this message]
2018-04-21 15:12 ` [PATCH 02/27] thermal: armada: remove useless register accesses Miquel Raynal
2018-04-21 15:12 ` [PATCH 03/27] thermal: armada: remove misleading comments Miquel Raynal
2018-04-21 15:12 ` [PATCH 04/27] thermal: armada: rename the initialization routine Miquel Raynal
2018-04-21 15:12 ` [PATCH 05/27] thermal: armada: dissociate a380 and cp110 ->init() hooks Miquel Raynal
2018-04-21 15:12 ` [PATCH 06/27] thermal: armada: average over samples to avoid glitches Miquel Raynal
2018-04-21 15:12 ` [PATCH 07/27] thermal: armada: convert driver to syscon register accesses Miquel Raynal
2018-04-21 15:12 ` [PATCH 08/27] thermal: armada: use the resource managed registration helper alternative Miquel Raynal
2018-04-21 15:12 ` [PATCH 09/27] thermal: armada: add multi-channel sensors support Miquel Raynal
2018-04-21 15:12 ` [PATCH 10/27] thermal: armada: remove sensors validity from the IP initialization Miquel Raynal
2018-04-21 15:12 ` [PATCH 11/27] thermal: armada: move validity check out of the read function Miquel Raynal
2018-04-21 15:12 ` [PATCH 12/27] thermal: armada: get rid of the ->is_valid() pointer Miquel Raynal
2018-04-21 15:12 ` [PATCH 13/27] thermal: armada: add overheat interrupt support Miquel Raynal
2018-04-21 15:12 ` [PATCH 14/27] dt-bindings: cp110: rename cp110 syscon file Miquel Raynal
2018-04-27 20:51 ` Rob Herring
2018-04-21 15:12 ` [PATCH 15/27] dt-bindings: ap806: prepare the syscon file to list other syscons nodes Miquel Raynal
2018-04-21 15:12 ` [PATCH 16/27] dt-bindings: cp110: " Miquel Raynal
2018-04-27 21:06 ` Rob Herring
2018-04-28 11:20 ` Miquel Raynal
2018-04-21 15:12 ` [PATCH 17/27] dt-bindings: ap806: add the thermal node in the syscon file Miquel Raynal
2018-04-27 21:07 ` Rob Herring
2018-04-28 11:07 ` Miquel Raynal
2018-05-18 9:56 ` Miquel Raynal
2018-04-21 15:12 ` [PATCH 18/27] dt-bindings: cp110: update documentation since DT de-duplication Miquel Raynal
2018-04-27 21:08 ` Rob Herring
2018-04-21 15:12 ` [PATCH 19/27] dt-bindings: cp110: add the thermal node in the syscon file Miquel Raynal
2018-04-21 15:12 ` [PATCH 20/27] dt-bindings: thermal: armada: add reference to new bindings Miquel Raynal
2018-04-21 15:12 ` [PATCH 21/27] arm64: dts: marvell: rename ap806 syscon node Miquel Raynal
2018-04-21 15:12 ` [PATCH 22/27] arm64: dts: marvell: move AP806/CP110 thermal nodes into a new syscon Miquel Raynal
2018-04-21 15:12 ` [PATCH 23/27] arm64: dts: marvell: add thermal-zone node in ap806 DTSI file Miquel Raynal
2018-04-21 15:12 ` [PATCH 24/27] arm64: dts: marvell: add macro to make distinction between node names Miquel Raynal
2018-04-21 15:12 ` [PATCH 25/27] arm64: dts: marvell: add thermal-zone node in cp110 DTSI file Miquel Raynal
2018-04-21 15:12 ` [PATCH 26/27] arm64: dts: marvell: add interrupt support to ap806 thermal node Miquel Raynal
2018-04-21 15:12 ` [PATCH 27/27] arm64: dts: marvell: add interrupt support to cp110 " Miquel Raynal
2018-05-16 17:28 ` [PATCH 00/27] Add multi-channel and overheat IRQ support to Armada thermal driver Gregory CLEMENT
2018-05-18 9:49 ` Miquel Raynal
2018-05-21 13:01 ` Zhang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180421151255.29929-2-miquel.raynal@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=andrew@lunn.ch \
--cc=antoine.tenart@bootlin.com \
--cc=catalin.marinas@arm.com \
--cc=davidsn@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.chevallier@bootlin.com \
--cc=nadavh@marvell.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sebastian.hesselbarth@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).