From: Rob Herring <robh@kernel.org>
To: Li Wei <liwei213@huawei.com>
Cc: mark.rutland@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, vinholikatti@gmail.com,
jejb@linux.vnet.ibm.com, martin.petersen@oracle.com,
khilman@baylibre.com, arnd@arndb.de,
gregory.clement@free-electrons.com,
thomas.petazzoni@free-electrons.com,
yamada.masahiro@socionext.com, riku.voipio@linaro.org,
treding@nvidia.com, krzk@kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
zangleigang@hisilicon.com, gengjianfeng@hisilicon.com,
guodong.xu@linaro.org
Subject: Re: [PATCH v9 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs
Date: Tue, 24 Apr 2018 07:58:27 -0500 [thread overview]
Message-ID: <20180424125827.k2dgeu6uon75wzni@rob-hp-laptop> (raw)
In-Reply-To: <20180417140814.38098-3-liwei213@huawei.com>
On Tue, Apr 17, 2018 at 10:08:11PM +0800, Li Wei wrote:
> add ufs node document for Hisilicon.
>
> Signed-off-by: Li Wei <liwei213@huawei.com>
> ---
> Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 29 ++++++++++++++++++++++
> .../devicetree/bindings/ufs/ufshcd-pltfrm.txt | 10 +++++---
> 2 files changed, 36 insertions(+), 3 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/ufs/ufs-hisi.txt
>
> diff --git a/Documentation/devicetree/bindings/ufs/ufs-hisi.txt b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> new file mode 100644
> index 000000000000..d49ab7d8f31d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/ufs/ufs-hisi.txt
> @@ -0,0 +1,29 @@
> +* Hisilicon Universal Flash Storage (UFS) Host Controller
> +
> +UFS nodes are defined to describe on-chip UFS hardware macro.
> +Each UFS Host Controller should have its own node.
> +
> +Required properties:
> +- compatible : compatible list, contains one of the following -
> + "hisilicon,hi3660-ufs", "jedec,ufs-1.1" for hisi ufs
> + host controller present on Hi36xx chipset.
> +- reg : should contain UFS register address space & UFS SYS CTRL register address,
> +- interrupt-parent : interrupt device
> +- interrupts : interrupt number
> +- resets : reset node register, the "arst" corresponds to reset the APB/AXI bus.
arst belongs in reset-names.
> +- reset-names : describe reset node register
What happened to clocks? You still have to list which ones apply even if
documented in the common binding.
> +
> +Example:
> +
> + ufs: ufs@ff3b0000 {
> + compatible = "hisilicon,hi3660-ufs", "jedec,ufs-1.1";
> + /* 0: HCI standard */
> + /* 1: UFS SYS CTRL */
> + reg = <0x0 0xff3b0000 0x0 0x1000>,
> + <0x0 0xff3b1000 0x0 0x1000>;
> + interrupt-parent = <&gic>;
> + interrupts = <GIC_SPI 278 IRQ_TYPE_LEVEL_HIGH>;
> + /* offset: 0x84; bit: 7 */
> + resets = <&crg_rst 0x84 7>;
> + reset-names = "arst";
> + };
> diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> index c39dfef76a18..adcfb79f63f5 100644
> --- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> +++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
> @@ -41,6 +41,8 @@ Optional properties:
> -lanes-per-direction : number of lanes available per direction - either 1 or 2.
> Note that it is assume same number of lanes is used both
> directions at once. If not specified, default is 2 lanes per direction.
> +- resets : reset node register, the "rst" corresponds to reset the whole UFS IP.
> +- reset-names : describe reset node register
Does your controller have 1 or 2 resets? There's no point in adding this
here if it doesn't apply to your controller.
> Note: If above properties are not defined it can be assumed that the supply
> regulators or clocks are always on.
> @@ -61,9 +63,11 @@ Example:
> vccq-max-microamp = 200000;
> vccq2-max-microamp = 200000;
>
> - clocks = <&core 0>, <&ref 0>, <&iface 0>;
> - clock-names = "core_clk", "ref_clk", "iface_clk";
> - freq-table-hz = <100000000 200000000>, <0 0>, <0 0>;
> + clocks = <&core 0>, <&ref 0>, <&phy 0>, <&iface 0>;
> + clock-names = "core_clk", "ref_clk", "phy_clk", "iface_clk";
> + freq-table-hz = <100000000 200000000>, <0 0>, <0 0>, <0 0>;
> + resets = <&reset 0 1>;
> + reset-names = "rst";
> phys = <&ufsphy1>;
> phy-names = "ufsphy";
> };
> --
> 2.15.0
>
next prev parent reply other threads:[~2018-04-24 12:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-17 14:08 [PATCH v9 0/5] scsi: ufs: add ufs driver code for Hisilicon Hi3660 SoC Li Wei
2018-04-17 14:08 ` [PATCH v9 1/5] scsi: ufs: add Hisilicon ufs driver code Li Wei
2018-04-17 14:08 ` [PATCH v9 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs Li Wei
2018-04-24 12:58 ` Rob Herring [this message]
2018-04-24 13:54 ` 答复: " liwei (CM)
2018-05-16 13:16 ` Rob Herring
2018-05-17 0:50 ` 答复: " liwei (CM)
2018-05-16 7:18 ` liwei (CM)
2018-04-17 14:08 ` [PATCH v9 3/5] arm64: dts: add ufs dts node Li Wei
2018-04-17 14:08 ` [PATCH v9 4/5] arm64: defconfig: enable configs for Hisilicon ufs Li Wei
2018-04-17 14:08 ` [PATCH v9 5/5] arm64: defconfig: enable f2fs and squashfs Li Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424125827.k2dgeu6uon75wzni@rob-hp-laptop \
--to=robh@kernel.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=gengjianfeng@hisilicon.com \
--cc=gregory.clement@free-electrons.com \
--cc=guodong.xu@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=khilman@baylibre.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liwei213@huawei.com \
--cc=mark.rutland@arm.com \
--cc=martin.petersen@oracle.com \
--cc=riku.voipio@linaro.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=treding@nvidia.com \
--cc=vinholikatti@gmail.com \
--cc=will.deacon@arm.com \
--cc=yamada.masahiro@socionext.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).