From: Marco Felsch <m.felsch@pengutronix.de>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
robh+dt@kernel.org, broonie@kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] ASoC: ssm2305: Add amplifier driver
Date: Thu, 17 May 2018 15:38:53 +0200 [thread overview]
Message-ID: <20180517133853.6vnqtnqo6x5mvkz5@pengutronix.de> (raw)
In-Reply-To: <6c7a72fc-f086-78e5-c920-809aeb738528@metafoo.de>
On 18-05-17 15:11, Lars-Peter Clausen wrote:
> On 05/17/2018 03:00 PM, Marco Felsch wrote:
> [...]
> > + if (IS_ERR(priv->gpiod_shutdown)) {
> > + err = PTR_ERR(priv->gpiod_shutdown);
> > + if (err != -EPROBE_DEFER) {
> > + dev_err(dev, "Failed to get 'shutdown' gpio: %d\n",
> > + err);
> > + return err;
>
> You also want to return the error in the EPROBE_DEFER case, so the driver
> tries to probe again later.
>
Yes, you're right.
> > + }
> > + }
> > +
> > + return devm_snd_soc_register_component(dev, &ssm2305_component_driver,
> > + NULL, 0);
> > +}
> [...]
>
prev parent reply other threads:[~2018-05-17 13:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:00 [PATCH v2] ASoC: ssm2305: Add amplifier driver Marco Felsch
2018-05-17 13:11 ` Lars-Peter Clausen
2018-05-17 13:38 ` Marco Felsch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180517133853.6vnqtnqo6x5mvkz5@pengutronix.de \
--to=m.felsch@pengutronix.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).