From: Mark Brown <broonie@kernel.org>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, lars@metafoo.de,
lgirdwood@gmail.com, robh+dt@kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v3] ASoC: ssm2305: Add amplifier driver
Date: Fri, 18 May 2018 09:31:30 +0100 [thread overview]
Message-ID: <20180518083130.GA24209@sirena.org.uk> (raw)
In-Reply-To: <20180518080711.asgrisdqxgzm3ziw@pengutronix.de>
[-- Attachment #1.1: Type: text/plain, Size: 867 bytes --]
On Fri, May 18, 2018 at 10:07:11AM +0200, Marco Felsch wrote:
> On 18-05-17 18:08, Mark Brown wrote:
> >
> > Please submit a followup patch which makes the entire comment a C++ one
> > rather than mixing them in the same comment block, it makes things look
> > more intentional.
> I'm a bit confused. As documented by the
> Documentation/process/license-rules.rst the license header should be a C++
> comment but for all block comments the 'normal' coding style should be
> applied. I can seperate the license header and the comment to make it
> more intentional.
> // SPDX-License-Identifier: GPL-2.0
>
> /*
> * Analog Devices SSM2305 Amplifier Driver
> *
> * Copyright (C) 2018 Pengutronix, Marco Felsch <kernel@pengutronix.de>
> */
> Is that better?
No, that still looks like a mess. Just make the whole thing a C++
comment.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
prev parent reply other threads:[~2018-05-18 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 13:55 [PATCH v3] ASoC: ssm2305: Add amplifier driver Marco Felsch
2018-05-17 14:44 ` Lars-Peter Clausen
2018-05-17 17:08 ` Mark Brown
2018-05-18 8:07 ` Marco Felsch
2018-05-18 8:31 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180518083130.GA24209@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).