From: Rob Herring <robh@kernel.org>
To: Daniel Mack <daniel@zonque.org>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
dmitry.torokhov@gmail.com, kernel@pengutronix.de,
linux-input@vger.kernel.org, fabio.estevam@nxp.com,
shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/3] input: touchscreen: edt-ft5x06: don't make device a wakeup source by default
Date: Tue, 22 May 2018 12:54:13 -0500 [thread overview]
Message-ID: <20180522175413.GA24850@rob-hp-laptop> (raw)
In-Reply-To: <20180517090552.5704-2-daniel@zonque.org>
On Thu, May 17, 2018 at 11:05:50AM +0200, Daniel Mack wrote:
> Allow configuring the device as wakeup source through device properties, as
> not all platforms want to wake up on touch screen activity.
>
> The I2C core automatically reads the "wakeup-source" DT property to
> configure a device's wakeup capability, and board supports files can set
> I2C_CLIENT_WAKE in the flags.
This will break wake-up on working systems. Looks like mostly i.MX, but
there's one AM437x board. If that board doesn't care, then it is up to
Shawn.
Rob
next prev parent reply other threads:[~2018-05-22 17:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-17 9:05 [PATCH v2 0/3] input: touchscreen: edt-ft5x06: make wakeup source behavior configurable Daniel Mack
2018-05-17 9:05 ` [PATCH v2 1/3] input: touchscreen: edt-ft5x06: don't make device a wakeup source by default Daniel Mack
2018-05-22 17:54 ` Rob Herring [this message]
2018-05-23 8:27 ` Daniel Mack
2018-05-23 14:45 ` Rob Herring
2018-05-24 23:17 ` Dmitry Torokhov
2018-05-25 15:52 ` Rob Herring
2018-05-17 9:05 ` [PATCH v2 2/3] input: touchscreen: edt-ft5x06: assert reset during suspend Daniel Mack
2018-05-17 9:05 ` [PATCH v2 3/3] ARM: dts: imx28/imx53: enable edt-ft5x06 wakeup source Daniel Mack
2018-05-20 13:05 ` Shawn Guo
2018-05-22 18:20 ` Dmitry Torokhov
2018-05-23 8:26 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180522175413.GA24850@rob-hp-laptop \
--to=robh@kernel.org \
--cc=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).