From: Rob Herring <robh@kernel.org>
To: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
ckadabi@codeaurora.org, tsoni@codeaurora.org,
rnayak@codeaurora.org, bryanh@codeaurora.org,
psodagud@codeaurora.org,
Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: Documentation for qcom,eud
Date: Tue, 25 Sep 2018 14:25:07 -0500 [thread overview]
Message-ID: <20180925192507.GA19360@bogus> (raw)
In-Reply-To: <1536096853-30473-2-git-send-email-pheragu@codeaurora.org>
On Tue, Sep 04, 2018 at 02:34:12PM -0700, Prakruthi Deepak Heragu wrote:
> Documentation for Embedded USB Debugger (EUD) device tree bindings.
>
> Signed-off-by: Satya Durga Srinivasu Prabhala <satyap@codeaurora.org>
> Signed-off-by: Prakruthi Deepak Heragu <pheragu@codeaurora.org>
> ---
> .../devicetree/bindings/soc/qcom/qcom,msm-eud.txt | 41 ++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
>
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
> new file mode 100644
> index 0000000..a03021a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,msm-eud.txt
> @@ -0,0 +1,41 @@
> +* Qualcomm Technologies Inc Embedded USB Debugger (EUD)
> +
> +The EUD (Embedded USB Debugger) is a mini-USB hub implemented
> +on chip to support the USB-based debug and trace capabilities.
Is it just for debug and normally bypassed?
> +
> +Required properties:
> +
> + - compatible: Should be "qcom,msm-eud"
Needs to be SoC specific (though a fallback is fine).
> + - interrupts: Interrupt number
> + - reg: Should be address and size of EUD register space
> +
> +Driver notifies clients for VBUS attach/detach and charger enable/disable
Bindings are for h/w blocks, not drivers.
> +events. The link between client and EUD is established via a directed
> +graph. EUD driver has one endpoint of the graph link mentioning EUD as an
> +output link and clients registered for these notifications from the EUD
> +should have the other endpoint of the graph link as an input link.
OF graph is for describing data flows (i.e. h/w connections), not
clients wanting some event.
> Each of
> +these endpoints should contain a 'remote-endpoint' phandle property that
> +points to the corresponding endpoint in the port of the remote device.
You don't need to describe how the graph binding works. Just what the
port assignments are.
I worry this is going to collide with using the graph binding for USB
connectors.
> +
> +An example for EUD device node:
> +
> + eud: qcom,msm-eud@88e0000 {
> + compatible = "qcom,msm-eud";
> + interrupts = <GIC_SPI 492 IRQ_TYPE_LEVEL_HIGH>;
> + reg = <0x88e0000 0x4000>;
> + port {
> + eud_output: endpoint {
> + remote-endpoint = <&usb3_input>;
> + };
> + };
> + };
> +
> +An example for EUD client:
What are possible clients? Could we want to switch clients at runtime?
> +
> + usb3 {
> + port {
> + usb3_input: endpoint {
> + remote-endpoint = <&eud_output>;
> + };
> + };
> + };
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2018-09-25 19:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-04 21:34 [PATCH v2 0/2] Add Embedded USB Debugger (EUD) driver Prakruthi Deepak Heragu
2018-09-04 21:34 ` [PATCH v2 1/2] dt-bindings: Documentation for qcom,eud Prakruthi Deepak Heragu
2018-09-25 19:25 ` Rob Herring [this message]
2019-12-27 13:00 ` Dwivedi, Avaneesh Kumar (avani)
2018-09-04 21:34 ` [PATCH v2 2/2] Embedded USB Debugger (EUD) driver Prakruthi Deepak Heragu
2018-09-05 9:31 ` Manu Gautam
2018-09-05 11:18 ` Greg KH
2018-09-11 20:40 ` pheragu
2018-09-12 6:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925192507.GA19360@bogus \
--to=robh@kernel.org \
--cc=bryanh@codeaurora.org \
--cc=ckadabi@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pheragu@codeaurora.org \
--cc=psodagud@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=satyap@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).