From: Thierry Reding <thierry.reding@gmail.com>
To: Douglas Anderson <dianders@chromium.org>
Cc: "Heiko Stuebner" <heiko@sntech.de>,
"Sean Paul" <seanpaul@chromium.org>,
linux-rockchip@lists.infradead.org,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
dri-devel@lists.freedesktop.org,
"Boris Brezillon" <boris.brezillon@collabora.com>,
"Ezequiel Garcia" <ezequiel@collabora.com>,
"Enric Balletbò" <enric.balletbo@collabora.com>,
"Rob Herring" <robh+dt@kernel.org>,
mka@chromium.org, "Eric Anholt" <eric@anholt.net>,
"Jeffy Chen" <jeffy.chen@rock-chips.com>,
"Stéphane Marchesin" <marcheu@chromium.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
"David Airlie" <airlied@linux.ie>,
"Mark Rutland" <mark.rutland@arm.com>,
"Daniel Vetter" <daniel@ffwll.ch>
Subject: Re: [PATCH v5 1/7] dt-bindings: Add panel-timing subnode to simple-panel
Date: Mon, 8 Apr 2019 12:32:40 +0200 [thread overview]
Message-ID: <20190408103240.GF6644@ulmo> (raw)
In-Reply-To: <20190401171724.215780-2-dianders@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 2215 bytes --]
On Mon, Apr 01, 2019 at 10:17:18AM -0700, Douglas Anderson wrote:
> From: Sean Paul <seanpaul@chromium.org>
>
> This patch adds a new subnode to simple-panel allowing us to override
> the typical timing expressed in the panel's display_timing.
>
> Changes in v2:
> - Split out the binding into a new patch (Rob)
> - display-timings is a new section (Rob)
> - Use the full display-timings subnode instead of picking the timing
> out (Rob/Thierry)
> Changes in v3:
> - Go back to using the timing subnode directly, but rename to
> panel-timing (Rob)
> Changes in v4:
> - Simplify desc. for when override should be used (Thierry/Laurent)
> - Removed Rob H review since it's been a year and wording changed
> Changes in v5:
> - Removed bit about OS may ignore (Rob/Ezequiel)
>
> Cc: Doug Anderson <dianders@chromium.org>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Stéphane Marchesin <marcheu@chromium.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: devicetree@vger.kernel.org
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Sean Paul <seanpaul@chromium.org>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
>
> .../bindings/display/panel/simple-panel.txt | 22 +++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> index b2b872c710f2..93882268c0b9 100644
> --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt
> @@ -15,6 +15,16 @@ Optional properties:
> (hot plug detect) signal, but the signal isn't hooked up so we should
> hardcode the max delay from the panel spec when powering up the panel.
>
> +panel-timing subnode
Is there any reason why we need the panel- prefix? This is already part
of a panel definition, so it's completely redundant. Why not just name
the subnode "timing"?
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-04-08 10:32 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 17:17 [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree Douglas Anderson
2019-04-01 17:17 ` [PATCH v5 1/7] dt-bindings: Add panel-timing subnode to simple-panel Douglas Anderson
2019-04-06 6:06 ` Rob Herring
2019-04-08 9:10 ` Boris Brezillon
2019-04-08 10:32 ` Thierry Reding [this message]
2019-04-08 14:39 ` Doug Anderson
2019-05-20 18:35 ` Doug Anderson
2019-06-28 23:47 ` Thierry Reding
2019-06-30 20:02 ` Sam Ravnborg
2019-07-01 16:59 ` Doug Anderson
[not found] ` <20190401171724.215780-1-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2019-04-01 17:17 ` [PATCH v5 2/7] drm/panel: simple: Add ability to override typical timing Douglas Anderson
2019-04-08 9:10 ` Boris Brezillon
2019-06-28 23:49 ` Thierry Reding
2019-06-30 20:22 ` Sam Ravnborg
2019-06-30 20:55 ` Sam Ravnborg
2019-07-01 16:39 ` Doug Anderson
2019-07-08 17:56 ` Sam Ravnborg
2019-07-10 22:56 ` Doug Anderson
2019-07-11 19:16 ` Sean Paul
2019-07-01 16:39 ` Doug Anderson
2019-07-08 17:50 ` Sam Ravnborg
2019-07-10 22:39 ` Doug Anderson
2019-07-11 19:38 ` Sam Ravnborg
2019-04-01 17:17 ` [PATCH v5 3/7] arm64: dts: rockchip: Specify override mode for kevin panel Douglas Anderson
2019-07-11 21:30 ` Heiko Stübner
2019-04-01 17:17 ` [PATCH v5 6/7] ARM: dts: rockchip: Specify rk3288-veyron-chromebook's display timings Douglas Anderson
2019-04-07 1:15 ` Urja Rannikko
2019-04-08 15:21 ` Doug Anderson
2019-04-08 16:26 ` Urja Rannikko
2019-04-13 0:07 ` Doug Anderson
2019-07-11 21:27 ` Heiko Stübner
2019-07-11 21:52 ` Heiko Stübner
2019-04-01 17:17 ` [PATCH v5 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's " Douglas Anderson
2019-07-11 21:28 ` Heiko Stübner
2019-06-14 10:39 ` [PATCH v5 0/7] drm/panel: simple: Add mode support to devicetree Heiko Stuebner
2019-06-26 13:00 ` Sam Ravnborg
2019-06-26 14:41 ` Doug Anderson
2019-06-28 15:55 ` Doug Anderson
2019-06-28 16:10 ` Rob Herring
2019-06-28 17:13 ` Sam Ravnborg
2019-06-29 14:09 ` Heiko Stübner
2019-07-08 15:58 ` Doug Anderson
2019-07-11 19:35 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408103240.GF6644@ulmo \
--to=thierry.reding@gmail.com \
--cc=airlied@linux.ie \
--cc=boris.brezillon@collabora.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=enric.balletbo@collabora.com \
--cc=eric@anholt.net \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=jeffy.chen@rock-chips.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=marcheu@chromium.org \
--cc=mark.rutland@arm.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).