From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Rob Herring <robh@kernel.org>
Cc: "Angus Ainslie (Purism)" <angus@akkea.ca>,
angus.ainslie@puri.sm, Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: power: supply: Add documentation for the VINDPM properties
Date: Wed, 26 Jun 2019 00:13:08 +0200 [thread overview]
Message-ID: <20190625221308.youac2n3wr7ojvyk@earth.universe> (raw)
In-Reply-To: <20190613230906.GA10492@bogus>
[-- Attachment #1: Type: text/plain, Size: 2273 bytes --]
Hi,
On Thu, Jun 13, 2019 at 05:09:06PM -0600, Rob Herring wrote:
> On Mon, May 20, 2019 at 11:07:12AM -0700, Angus Ainslie (Purism) wrote:
> > Add documentation on how to control VINDPM from the devicetree.
> >
> > Signed-off-by: Angus Ainslie (Purism) <angus@akkea.ca>
> > ---
> > .../devicetree/bindings/power/supply/bq25890.txt | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/power/supply/bq25890.txt b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> > index dc0568933359..fe8b709dd666 100644
> > --- a/Documentation/devicetree/bindings/power/supply/bq25890.txt
> > +++ b/Documentation/devicetree/bindings/power/supply/bq25890.txt
> > @@ -26,9 +26,15 @@ Optional properties:
> > - ti,use-ilim-pin: boolean, if present the ILIM resistor will be used and the
> > input current will be the lower between the resistor setting and the IINLIM
> > register setting;
> > +- ti,use-vinmin-threshold: boolean, if present the FORCE_VINDPM bit will be set
> > + and the input voltage limit will be configured based on "ti,vinmin-threshold"
>
> Isn't presence of ti,vinmin-threshold enough to determine whether to set
> FORCE_VINDPM or not? Just get rid of the default being 4.4V.
>
> > - ti,thermal-regulation-threshold: integer, temperature above which the charge
> > current is lowered, to avoid overheating (in degrees Celsius). If omitted,
> > the default setting will be used (120 degrees);
> > +- ti,vinmin-threshold: integer, lower absolute threshold for VINDPM. If the
> > + voltage falls below this threshold the charge current is reduced until the
> > + input voltage rises above the input voltage limit. If omitted, the default
> > + setting will be used (4.4V);
We already have a "input-voltage-min-microvolt" property used by
Maxim chargers, please resuse that for the bq25890 instead of
creating a new property name.
-- Sebastian
> >
> > Example:
> >
> > @@ -46,4 +52,6 @@ bq25890 {
> >
> > ti,use-ilim-pin;
> > ti,thermal-regulation-threshold = <120>;
> > + ti,use-vinmin-threshold;
> > + ti,vinmin-threshold = <3900000>;
> > };
> > --
> > 2.17.1
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-06-25 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 18:07 [PATCH 0/2] Allow VINDPM to be set in the device tree Angus Ainslie (Purism)
2019-05-20 18:07 ` [PATCH 1/2] power: supply: bq25890: Add support for setting bq25890 and bq25896's VINDPM Angus Ainslie (Purism)
2019-05-20 18:07 ` [PATCH 2/2] dt-bindings: power: supply: Add documentation for the VINDPM properties Angus Ainslie (Purism)
2019-06-13 23:09 ` Rob Herring
2019-06-25 22:13 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625221308.youac2n3wr7ojvyk@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=angus.ainslie@puri.sm \
--cc=angus@akkea.ca \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).