From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Cc: Linux Doc Mailing List <linux-doc@vger.kernel.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-kernel@vger.kernel.org, Jonathan Corbet <corbet@lwn.net>,
Peter Rosin <peda@axentia.se>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Andreas Werner <andreas.werner@men.de>,
Wolfram Sang <wsa@the-dreams.de>,
Rudolf Marek <r.marek@assembler.cz>,
Seth Heasley <seth.heasley@intel.com>,
Neil Horman <nhorman@tuxdriver.com>,
Vadim Pasternak <vadimp@mellanox.com>,
Michael Shych <michaelsh@mellanox.com>,
Ajay Gupta <ajayg@nvidia.com>,
Peter Korsgaard <peter@korsgaard.com>,
Andrew Lunn <andrew@lunn.ch>,
Jim Cromie <jim.cromie@gmail.com>Mark
Subject: Re: [PATCH 3/5] docs: i2c: convert to ReST and add to driver-api bookset
Date: Sat, 29 Jun 2019 00:10:10 +0200 [thread overview]
Message-ID: <20190628221010.GV3692@piout.net> (raw)
In-Reply-To: <20190628185445.71eb824b@coco.lan>
On 28/06/2019 18:54:45-0300, Mauro Carvalho Chehab wrote:
> Em Fri, 28 Jun 2019 23:41:38 +0200
> Alexandre Belloni <alexandre.belloni@bootlin.com> escreveu:
>
> > On 28/06/2019 18:23:14-0300, Mauro Carvalho Chehab wrote:
> > > diff --git a/drivers/rtc/rtc-ds1374.c b/drivers/rtc/rtc-ds1374.c
> > > index 225a8df1d4e9..1803f3cab39f 100644
> > > --- a/drivers/rtc/rtc-ds1374.c
> > > +++ b/drivers/rtc/rtc-ds1374.c
> > > @@ -14,7 +14,7 @@
> > > */
> > > /*
> > > * It would be more efficient to use i2c msgs/i2c_transfer directly but, as
> > > - * recommened in .../Documentation/i2c/writing-clients section
> > > + * recommened in .../Documentation/i2c/writing-clients.rst section
> > > * "Sending and receiving", using SMBus level communication is preferred.
> > > */
> > >
> >
> > Honestly, the whole comment could be removed. The current trend is to
> > move everything to regmap anyway.
> >
> > However, I'm fine with that change if you want to keep it that way (and
> > probably scripted).
>
> While the conversion was manually made, the renames were scripted,
> and checked with:
>
> ./scripts/documentation-file-ref-check
>
> Otherwise I would very likely fix the typo:
>
> recommened -> recommended
>
> :-)
>
> I can certainly add new patch at this (before or after patch 3/5 - as you
> prefer) in order to get rid of the comment, but I would avoid doing a
> somewhat unrelated changes at the same documentation patch.
>
I'm okay with that.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-06-28 22:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 21:23 [PATCH 0/5] Convert misc-devices, i2c, w1, spi and some markdown files to ReST Mauro Carvalho Chehab
2019-06-28 21:23 ` [PATCH 1/5] docs: convert markdown documents " Mauro Carvalho Chehab
2019-06-28 22:38 ` Rob Herring
2019-06-28 21:23 ` [PATCH 3/5] docs: i2c: convert to ReST and add to driver-api bookset Mauro Carvalho Chehab
2019-06-28 21:41 ` Alexandre Belloni
2019-06-28 21:54 ` Mauro Carvalho Chehab
2019-06-28 22:10 ` Alexandre Belloni [this message]
2019-06-29 10:57 ` Wolfram Sang
2019-06-29 11:37 ` Alexandre Belloni
2019-07-14 16:23 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628221010.GV3692@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=ajayg@nvidia.com \
--cc=andreas.werner@men.de \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=jdelvare@suse.com \
--cc=jim.cromie@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab+samsung@kernel.org \
--cc=mchehab@infradead.org \
--cc=michaelsh@mellanox.com \
--cc=nhorman@tuxdriver.com \
--cc=peda@axentia.se \
--cc=peter@korsgaard.com \
--cc=r.marek@assembler.cz \
--cc=robh+dt@kernel.org \
--cc=seth.heasley@intel.com \
--cc=vadimp@mellanox.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).