From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 7/7] arm64: dts: allwinner: a64: enable ANX6345 bridge on Teres-I Date: Fri, 12 Jul 2019 22:15:43 +0200 Message-ID: <20190712201543.krhsfjepd3cqndla@flea> References: <20190607094030.GA12373@lst.de> <66707fcc-b48e-02d3-5ed7-6b7e77d53266@samsung.com> <20190612152022.c3cfhp4cauhzhfyr@flea> <20190701095842.fvganvycce2cy7jn@flea> <20190709085532.cdqv7whuesrjs64c@flea> <20190710114042.ybgavnxb4hgqrtor@flea> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Vasily Khoruzhick Cc: Andrzej Hajda , Torsten Duwe , Harald Geyer , Chen-Yu Tsai , Rob Herring , Mark Rutland , Thierry Reding , David Airlie , Daniel Vetter , Laurent Pinchart , Icenowy Zheng , Sean Paul , Greg Kroah-Hartman , Thomas Gleixner , dri-devel , devicetree , arm-linux , linux-kernel List-Id: devicetree@vger.kernel.org On Wed, Jul 10, 2019 at 03:11:04PM -0700, Vasily Khoruzhick wrote: > On Wed, Jul 10, 2019 at 4:40 AM Maxime Ripard wrote: > > > > > There's another issue: if we introduce edp-connector we'll have to > > > > > specify power up delays somewhere (in dts? or in platform driver?), so > > > > > edp-connector doesn't really solve the issue of multiple panels with > > > > > same motherboard. > > > > > > > > And that's what that compatible is about :) > > > > > > Sorry, I fail to see how it would be different from using existing > > > panels infrastructure and different panels compatibles. I think Rob's > > > idea was to introduce generic edp-connector. > > > > Again, there's no such thing as a generic edp-connector. The spec > > doesn't define anything related to the power sequence for example. > > > > > If we can't make it generic then let's use panel infrastructure. > > > > Which uses a device specific compatible. Really, I'm not sure what > > your objection and / or argument is here. > > > > In addition, when that was brought up in the discussion, you rejected > > it because it was inconvenient: > > https://patchwork.freedesktop.org/patch/283012/?series=56163&rev=1#comment_535206 > > It is inconvenient, but I don't understand how having board-specific > connectors fixes it. How it would not fix it? You'll have one connector, without the need to describe each and every panel in the device tree and rely on the EDID instead, and you'll have the option to power up the regulator you need. I really don't understand what's the issue here, so let's take a step back. What are is the issue , what are your requirements, and how would you like that to be described ? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com