From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: David Dai <daidavid1@codeaurora.org>
Cc: georgi.djakov@linaro.org, robh+dt@kernel.org, evgreen@google.com,
ilina@codeaurora.org, seansw@qti.qualcomm.com, elder@linaro.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes
Date: Sun, 21 Jul 2019 12:13:05 -0700 [thread overview]
Message-ID: <20190721191305.GI7234@tuxbook-pro> (raw)
In-Reply-To: <1563568344-1274-3-git-send-email-daidavid1@codeaurora.org>
On Fri 19 Jul 13:32 PDT 2019, David Dai wrote:
> Add the DT nodes for each of the Network-On-Chip interconnect
> buses found on SDM845 based platform and redefine the rsc_hlos
> child node as a bcm-voter device to better represent the hardware.
>
> Signed-off-by: David Dai <daidavid1@codeaurora.org>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 ++++++++++++++++++++++++++++++++++--
> 1 file changed, 58 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index e7d78bc..204222e 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -610,6 +610,62 @@
> #power-domain-cells = <1>;
> };
>
> + aggre1_noc: interconnect@16e0000 {
> + compatible = "qcom,sdm845-aggre1_noc";
> + reg = <0 0x16e0000 0 0xd080>;
Please pad the address to 8 digits and keep nodes sorted by address.
> + #interconnect-cells = <1>;
> + qcom,bcm-voter = <&apps_bcm_voter>;
> + };
> +
> + aggre2_noc: interconnect@1700000 {
> + compatible = "qcom,sdm845-aggre2_noc";
> + reg = <0 0x1700000 0 0x3b100>;
> + #interconnect-cells = <1>;
> + qcom,bcm-voter = <&apps_bcm_voter>;
> + };
> +
> + config_noc: interconnect@1500000 {
> + compatible = "qcom,sdm845-config_noc";
> + reg = <0 0x1500000 0 0x5080>;
> + #interconnect-cells = <1>;
> + qcom,bcm-voter = <&apps_bcm_voter>;
> + };
[..]
> qfprom@784000 {
> compatible = "qcom,qfprom";
> reg = <0 0x00784000 0 0x8ff>;
> @@ -2801,9 +2857,8 @@
> };
> };
>
> - rsc_hlos: interconnect {
> - compatible = "qcom,sdm845-rsc-hlos";
> - #interconnect-cells = <1>;
> + apps_bcm_voter: bcm_voter {
No '_' in node names, so bcm-voter.
Apart from this nits this looks good.
Regards,
Bjorn
> + compatible = "qcom,sdm845-bcm-voter";
> };
> };
>
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2019-07-21 19:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 20:32 [PATCH 0/2] Redefine interconnect provider DT nodes for SDM845 David Dai
2019-07-19 20:32 ` [PATCH 1/2] dt-bindings: interconnect: Update Qualcomm SDM845 DT bindings David Dai
2019-07-21 19:10 ` Bjorn Andersson
2019-07-23 14:42 ` Stephen Boyd
2019-07-23 21:48 ` David Dai
2019-07-24 14:18 ` Stephen Boyd
2019-07-24 17:22 ` David Dai
2019-07-24 18:27 ` Stephen Boyd
2019-07-24 20:42 ` David Dai
2019-07-19 20:32 ` [PATCH 2/2] arm64: dts: sdm845: Redefine interconnect provider DT nodes David Dai
2019-07-21 19:13 ` Bjorn Andersson [this message]
2019-07-23 18:24 ` David Dai
2019-12-12 19:36 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190721191305.GI7234@tuxbook-pro \
--to=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=evgreen@google.com \
--cc=georgi.djakov@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=seansw@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).