* [PATCH 0/3] arm64: dts: qcom: qcs404: Fix DTS warnings
@ 2019-07-25 13:51 Vinod Koul
2019-07-25 13:51 ` [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes Vinod Koul
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Vinod Koul @ 2019-07-25 13:51 UTC (permalink / raw)
To: Andy Gross
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Rob Herring,
Mark Rutland, devicetree, linux-kernel
So this is second installment of my work to fix warns on qcom DTS, this time
the traget is qcs404 platform.
Vinod Koul (3):
arm64: dts: qcom: pms405: add unit name adc nodes
arm64: dts: qcom: pms405: remove reduandant properties
arm64: dts: qcom: qcs404: remove unit name for thermal trip points
arch/arm64/boot/dts/qcom/pms405.dtsi | 16 +++++++--------
arch/arm64/boot/dts/qcom/qcs404.dtsi | 30 ++++++++++++++--------------
2 files changed, 22 insertions(+), 24 deletions(-)
--
2.20.1
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes
2019-07-25 13:51 [PATCH 0/3] arm64: dts: qcom: qcs404: Fix DTS warnings Vinod Koul
@ 2019-07-25 13:51 ` Vinod Koul
2019-07-30 16:35 ` Amit Kucheria
2019-07-25 13:51 ` [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties Vinod Koul
2019-07-25 13:51 ` [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points Vinod Koul
2 siblings, 1 reply; 8+ messages in thread
From: Vinod Koul @ 2019-07-25 13:51 UTC (permalink / raw)
To: Andy Gross
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Rob Herring,
Mark Rutland, devicetree, linux-kernel
The adc nodes have reg property but were missing the unit name, so add
that to fix these warnings:
arch/arm64/boot/dts/qcom/pms405.dtsi:91.12-94.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/ref_gnd: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/pms405.dtsi:96.14-99.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vref_1p25: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/pms405.dtsi:101.19-104.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vph_pwr: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/pms405.dtsi:106.13-109.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/die_temp: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/pms405.dtsi:111.27-116.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor1: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/pms405.dtsi:118.27-123.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor3: node has a reg or ranges property, but no unit name
arch/arm64/boot/dts/qcom/pms405.dtsi:125.22-130.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/xo_temp: node has a reg or ranges property, but no unit name
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/pms405.dtsi | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
index 14240fedd916..3c10cf04d26e 100644
--- a/arch/arm64/boot/dts/qcom/pms405.dtsi
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -88,41 +88,41 @@
#size-cells = <0>;
#io-channel-cells = <1>;
- ref_gnd {
+ ref_gnd@0 {
reg = <ADC5_REF_GND>;
qcom,pre-scaling = <1 1>;
};
- vref_1p25 {
+ vref_1p25@1 {
reg = <ADC5_1P25VREF>;
qcom,pre-scaling = <1 1>;
};
- pon_1: vph_pwr {
+ pon_1: vph_pwr@131 {
reg = <ADC5_VPH_PWR>;
qcom,pre-scaling = <1 3>;
};
- die_temp {
+ die_temp@6 {
reg = <ADC5_DIE_TEMP>;
qcom,pre-scaling = <1 1>;
};
- pa_therm1: thermistor1 {
+ pa_therm1: thermistor1@115 {
reg = <ADC5_AMUX_THM1_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
qcom,pre-scaling = <1 1>;
};
- pa_therm3: thermistor3 {
+ pa_therm3: thermistor3@117 {
reg = <ADC5_AMUX_THM3_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
qcom,pre-scaling = <1 1>;
};
- xo_therm: xo_temp {
+ xo_therm: xo_temp@114 {
reg = <ADC5_XO_THERM_100K_PU>;
qcom,ratiometric;
qcom,hw-settle-time = <200>;
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties
2019-07-25 13:51 [PATCH 0/3] arm64: dts: qcom: qcs404: Fix DTS warnings Vinod Koul
2019-07-25 13:51 ` [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes Vinod Koul
@ 2019-07-25 13:51 ` Vinod Koul
2019-07-30 16:36 ` Amit Kucheria
2019-07-25 13:51 ` [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points Vinod Koul
2 siblings, 1 reply; 8+ messages in thread
From: Vinod Koul @ 2019-07-25 13:51 UTC (permalink / raw)
To: Andy Gross
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Rob Herring,
Mark Rutland, devicetree, linux-kernel
pms405@1 nodes specified unnecessary #address-cells/#size-cells but the
subnodes dont have "ranges" or "reg" so remove it
arch/arm64/boot/dts/qcom/pms405.dtsi:141.21-150.4: Warning (avoid_unnecessary_addr_size): /soc@0/spmi@200f000/pms405@1: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/pms405.dtsi | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
index 3c10cf04d26e..32678f7ce90d 100644
--- a/arch/arm64/boot/dts/qcom/pms405.dtsi
+++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
@@ -141,8 +141,6 @@
pms405_1: pms405@1 {
compatible = "qcom,spmi-pmic";
reg = <0x1 SPMI_USID>;
- #address-cells = <1>;
- #size-cells = <0>;
pms405_spmi_regulators: regulators {
compatible = "qcom,pms405-regulators";
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points
2019-07-25 13:51 [PATCH 0/3] arm64: dts: qcom: qcs404: Fix DTS warnings Vinod Koul
2019-07-25 13:51 ` [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes Vinod Koul
2019-07-25 13:51 ` [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties Vinod Koul
@ 2019-07-25 13:51 ` Vinod Koul
2019-07-30 16:36 ` Amit Kucheria
2 siblings, 1 reply; 8+ messages in thread
From: Vinod Koul @ 2019-07-25 13:51 UTC (permalink / raw)
To: Andy Gross
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Rob Herring,
Mark Rutland, devicetree, linux-kernel
The thermal trip points have unit name but no reg property, so we can
remove them
arch/arm64/boot/dts/qcom/qcs404.dtsi:1080.31-1084.7: Warning (unit_address_vs_reg): /thermal-zones/aoss-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1095.33-1099.7: Warning (unit_address_vs_reg): /thermal-zones/q6-hvx-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1110.32-1114.7: Warning (unit_address_vs_reg): /thermal-zones/lpass-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1125.31-1129.7: Warning (unit_address_vs_reg): /thermal-zones/wlan-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1140.34-1144.7: Warning (unit_address_vs_reg): /thermal-zones/cluster-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1145.34-1149.7: Warning (unit_address_vs_reg): /thermal-zones/cluster-thermal/trips/trip-point@1: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1174.31-1178.7: Warning (unit_address_vs_reg): /thermal-zones/cpu0-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1179.31-1183.7: Warning (unit_address_vs_reg): /thermal-zones/cpu0-thermal/trips/trip-point@1: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1208.31-1212.7: Warning (unit_address_vs_reg): /thermal-zones/cpu1-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1213.31-1217.7: Warning (unit_address_vs_reg): /thermal-zones/cpu1-thermal/trips/trip-point@1: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1242.31-1246.7: Warning (unit_address_vs_reg): /thermal-zones/cpu2-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1247.31-1251.7: Warning (unit_address_vs_reg): /thermal-zones/cpu2-thermal/trips/trip-point@1: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1276.31-1280.7: Warning (unit_address_vs_reg): /thermal-zones/cpu3-thermal/trips/trip-point@0: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1281.31-1285.7: Warning (unit_address_vs_reg): /thermal-zones/cpu3-thermal/trips/trip-point@1: node has a unit name, but no reg property
arch/arm64/boot/dts/qcom/qcs404.dtsi:1310.30-1314.7: Warning (unit_address_vs_reg): /thermal-zones/gpu-thermal/trips/trip-point@0: node has a unit name, but no reg property
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 30 ++++++++++++++--------------
1 file changed, 15 insertions(+), 15 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 3d0789775009..6d91dae5aee0 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -1077,7 +1077,7 @@
thermal-sensors = <&tsens 0>;
trips {
- aoss_alert0: trip-point@0 {
+ aoss_alert0: trip-point0 {
temperature = <105000>;
hysteresis = <2000>;
type = "hot";
@@ -1092,7 +1092,7 @@
thermal-sensors = <&tsens 1>;
trips {
- q6_hvx_alert0: trip-point@0 {
+ q6_hvx_alert0: trip-point0 {
temperature = <105000>;
hysteresis = <2000>;
type = "hot";
@@ -1107,7 +1107,7 @@
thermal-sensors = <&tsens 2>;
trips {
- lpass_alert0: trip-point@0 {
+ lpass_alert0: trip-point0 {
temperature = <105000>;
hysteresis = <2000>;
type = "hot";
@@ -1122,7 +1122,7 @@
thermal-sensors = <&tsens 3>;
trips {
- wlan_alert0: trip-point@0 {
+ wlan_alert0: trip-point0 {
temperature = <105000>;
hysteresis = <2000>;
type = "hot";
@@ -1137,12 +1137,12 @@
thermal-sensors = <&tsens 4>;
trips {
- cluster_alert0: trip-point@0 {
+ cluster_alert0: trip-point0 {
temperature = <95000>;
hysteresis = <2000>;
type = "hot";
};
- cluster_alert1: trip-point@1 {
+ cluster_alert1: trip-point1 {
temperature = <105000>;
hysteresis = <2000>;
type = "passive";
@@ -1171,12 +1171,12 @@
thermal-sensors = <&tsens 5>;
trips {
- cpu0_alert0: trip-point@0 {
+ cpu0_alert0: trip-point0 {
temperature = <95000>;
hysteresis = <2000>;
type = "hot";
};
- cpu0_alert1: trip-point@1 {
+ cpu0_alert1: trip-point1 {
temperature = <105000>;
hysteresis = <2000>;
type = "passive";
@@ -1205,12 +1205,12 @@
thermal-sensors = <&tsens 6>;
trips {
- cpu1_alert0: trip-point@0 {
+ cpu1_alert0: trip-point0 {
temperature = <95000>;
hysteresis = <2000>;
type = "hot";
};
- cpu1_alert1: trip-point@1 {
+ cpu1_alert1: trip-point1 {
temperature = <105000>;
hysteresis = <2000>;
type = "passive";
@@ -1239,12 +1239,12 @@
thermal-sensors = <&tsens 7>;
trips {
- cpu2_alert0: trip-point@0 {
+ cpu2_alert0: trip-point0 {
temperature = <95000>;
hysteresis = <2000>;
type = "hot";
};
- cpu2_alert1: trip-point@1 {
+ cpu2_alert1: trip-point1 {
temperature = <105000>;
hysteresis = <2000>;
type = "passive";
@@ -1273,12 +1273,12 @@
thermal-sensors = <&tsens 8>;
trips {
- cpu3_alert0: trip-point@0 {
+ cpu3_alert0: trip-point0 {
temperature = <95000>;
hysteresis = <2000>;
type = "hot";
};
- cpu3_alert1: trip-point@1 {
+ cpu3_alert1: trip-point1 {
temperature = <105000>;
hysteresis = <2000>;
type = "passive";
@@ -1307,7 +1307,7 @@
thermal-sensors = <&tsens 9>;
trips {
- gpu_alert0: trip-point@0 {
+ gpu_alert0: trip-point0 {
temperature = <95000>;
hysteresis = <2000>;
type = "hot";
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes
2019-07-25 13:51 ` [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes Vinod Koul
@ 2019-07-30 16:35 ` Amit Kucheria
2019-07-31 8:15 ` Vinod Koul
0 siblings, 1 reply; 8+ messages in thread
From: Amit Kucheria @ 2019-07-30 16:35 UTC (permalink / raw)
To: Vinod Koul
Cc: Andy Gross, linux-arm-msm, Bjorn Andersson, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
On Thu, Jul 25, 2019 at 7:23 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> The adc nodes have reg property but were missing the unit name, so add
> that to fix these warnings:
>
> arch/arm64/boot/dts/qcom/pms405.dtsi:91.12-94.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/ref_gnd: node has a reg or ranges property, but no unit name
> arch/arm64/boot/dts/qcom/pms405.dtsi:96.14-99.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vref_1p25: node has a reg or ranges property, but no unit name
> arch/arm64/boot/dts/qcom/pms405.dtsi:101.19-104.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vph_pwr: node has a reg or ranges property, but no unit name
> arch/arm64/boot/dts/qcom/pms405.dtsi:106.13-109.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/die_temp: node has a reg or ranges property, but no unit name
> arch/arm64/boot/dts/qcom/pms405.dtsi:111.27-116.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor1: node has a reg or ranges property, but no unit name
> arch/arm64/boot/dts/qcom/pms405.dtsi:118.27-123.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor3: node has a reg or ranges property, but no unit name
> arch/arm64/boot/dts/qcom/pms405.dtsi:125.22-130.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/xo_temp: node has a reg or ranges property, but no unit name
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> arch/arm64/boot/dts/qcom/pms405.dtsi | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
> index 14240fedd916..3c10cf04d26e 100644
> --- a/arch/arm64/boot/dts/qcom/pms405.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> @@ -88,41 +88,41 @@
> #size-cells = <0>;
> #io-channel-cells = <1>;
>
> - ref_gnd {
> + ref_gnd@0 {
> reg = <ADC5_REF_GND>;
> qcom,pre-scaling = <1 1>;
> };
>
> - vref_1p25 {
> + vref_1p25@1 {
> reg = <ADC5_1P25VREF>;
> qcom,pre-scaling = <1 1>;
> };
>
> - pon_1: vph_pwr {
> + pon_1: vph_pwr@131 {
> reg = <ADC5_VPH_PWR>;
> qcom,pre-scaling = <1 3>;
> };
>
> - die_temp {
> + die_temp@6 {
> reg = <ADC5_DIE_TEMP>;
> qcom,pre-scaling = <1 1>;
> };
>
> - pa_therm1: thermistor1 {
> + pa_therm1: thermistor1@115 {
s/115/77 ?
> reg = <ADC5_AMUX_THM1_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> qcom,pre-scaling = <1 1>;
> };
>
> - pa_therm3: thermistor3 {
> + pa_therm3: thermistor3@117 {
s/117/79 ?
> reg = <ADC5_AMUX_THM3_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> qcom,pre-scaling = <1 1>;
> };
>
> - xo_therm: xo_temp {
> + xo_therm: xo_temp@114 {
s/114/76 ?
> reg = <ADC5_XO_THERM_100K_PU>;
> qcom,ratiometric;
> qcom,hw-settle-time = <200>;
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points
2019-07-25 13:51 ` [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points Vinod Koul
@ 2019-07-30 16:36 ` Amit Kucheria
0 siblings, 0 replies; 8+ messages in thread
From: Amit Kucheria @ 2019-07-30 16:36 UTC (permalink / raw)
To: Vinod Koul
Cc: Andy Gross, linux-arm-msm, Bjorn Andersson, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
On Thu, Jul 25, 2019 at 7:23 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> The thermal trip points have unit name but no reg property, so we can
> remove them
>
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1080.31-1084.7: Warning (unit_address_vs_reg): /thermal-zones/aoss-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1095.33-1099.7: Warning (unit_address_vs_reg): /thermal-zones/q6-hvx-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1110.32-1114.7: Warning (unit_address_vs_reg): /thermal-zones/lpass-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1125.31-1129.7: Warning (unit_address_vs_reg): /thermal-zones/wlan-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1140.34-1144.7: Warning (unit_address_vs_reg): /thermal-zones/cluster-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1145.34-1149.7: Warning (unit_address_vs_reg): /thermal-zones/cluster-thermal/trips/trip-point@1: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1174.31-1178.7: Warning (unit_address_vs_reg): /thermal-zones/cpu0-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1179.31-1183.7: Warning (unit_address_vs_reg): /thermal-zones/cpu0-thermal/trips/trip-point@1: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1208.31-1212.7: Warning (unit_address_vs_reg): /thermal-zones/cpu1-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1213.31-1217.7: Warning (unit_address_vs_reg): /thermal-zones/cpu1-thermal/trips/trip-point@1: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1242.31-1246.7: Warning (unit_address_vs_reg): /thermal-zones/cpu2-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1247.31-1251.7: Warning (unit_address_vs_reg): /thermal-zones/cpu2-thermal/trips/trip-point@1: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1276.31-1280.7: Warning (unit_address_vs_reg): /thermal-zones/cpu3-thermal/trips/trip-point@0: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1281.31-1285.7: Warning (unit_address_vs_reg): /thermal-zones/cpu3-thermal/trips/trip-point@1: node has a unit name, but no reg property
> arch/arm64/boot/dts/qcom/qcs404.dtsi:1310.30-1314.7: Warning (unit_address_vs_reg): /thermal-zones/gpu-thermal/trips/trip-point@0: node has a unit name, but no reg property
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/qcs404.dtsi | 30 ++++++++++++++--------------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> index 3d0789775009..6d91dae5aee0 100644
> --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
> +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
> @@ -1077,7 +1077,7 @@
> thermal-sensors = <&tsens 0>;
>
> trips {
> - aoss_alert0: trip-point@0 {
> + aoss_alert0: trip-point0 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "hot";
> @@ -1092,7 +1092,7 @@
> thermal-sensors = <&tsens 1>;
>
> trips {
> - q6_hvx_alert0: trip-point@0 {
> + q6_hvx_alert0: trip-point0 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "hot";
> @@ -1107,7 +1107,7 @@
> thermal-sensors = <&tsens 2>;
>
> trips {
> - lpass_alert0: trip-point@0 {
> + lpass_alert0: trip-point0 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "hot";
> @@ -1122,7 +1122,7 @@
> thermal-sensors = <&tsens 3>;
>
> trips {
> - wlan_alert0: trip-point@0 {
> + wlan_alert0: trip-point0 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "hot";
> @@ -1137,12 +1137,12 @@
> thermal-sensors = <&tsens 4>;
>
> trips {
> - cluster_alert0: trip-point@0 {
> + cluster_alert0: trip-point0 {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "hot";
> };
> - cluster_alert1: trip-point@1 {
> + cluster_alert1: trip-point1 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "passive";
> @@ -1171,12 +1171,12 @@
> thermal-sensors = <&tsens 5>;
>
> trips {
> - cpu0_alert0: trip-point@0 {
> + cpu0_alert0: trip-point0 {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "hot";
> };
> - cpu0_alert1: trip-point@1 {
> + cpu0_alert1: trip-point1 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "passive";
> @@ -1205,12 +1205,12 @@
> thermal-sensors = <&tsens 6>;
>
> trips {
> - cpu1_alert0: trip-point@0 {
> + cpu1_alert0: trip-point0 {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "hot";
> };
> - cpu1_alert1: trip-point@1 {
> + cpu1_alert1: trip-point1 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "passive";
> @@ -1239,12 +1239,12 @@
> thermal-sensors = <&tsens 7>;
>
> trips {
> - cpu2_alert0: trip-point@0 {
> + cpu2_alert0: trip-point0 {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "hot";
> };
> - cpu2_alert1: trip-point@1 {
> + cpu2_alert1: trip-point1 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "passive";
> @@ -1273,12 +1273,12 @@
> thermal-sensors = <&tsens 8>;
>
> trips {
> - cpu3_alert0: trip-point@0 {
> + cpu3_alert0: trip-point0 {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "hot";
> };
> - cpu3_alert1: trip-point@1 {
> + cpu3_alert1: trip-point1 {
> temperature = <105000>;
> hysteresis = <2000>;
> type = "passive";
> @@ -1307,7 +1307,7 @@
> thermal-sensors = <&tsens 9>;
>
> trips {
> - gpu_alert0: trip-point@0 {
> + gpu_alert0: trip-point0 {
> temperature = <95000>;
> hysteresis = <2000>;
> type = "hot";
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties
2019-07-25 13:51 ` [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties Vinod Koul
@ 2019-07-30 16:36 ` Amit Kucheria
0 siblings, 0 replies; 8+ messages in thread
From: Amit Kucheria @ 2019-07-30 16:36 UTC (permalink / raw)
To: Vinod Koul
Cc: Andy Gross, linux-arm-msm, Bjorn Andersson, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
On Thu, Jul 25, 2019 at 7:23 PM Vinod Koul <vkoul@kernel.org> wrote:
>
> pms405@1 nodes specified unnecessary #address-cells/#size-cells but the
> subnodes dont have "ranges" or "reg" so remove it
>
> arch/arm64/boot/dts/qcom/pms405.dtsi:141.21-150.4: Warning (avoid_unnecessary_addr_size): /soc@0/spmi@200f000/pms405@1: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/pms405.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
> index 3c10cf04d26e..32678f7ce90d 100644
> --- a/arch/arm64/boot/dts/qcom/pms405.dtsi
> +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> @@ -141,8 +141,6 @@
> pms405_1: pms405@1 {
> compatible = "qcom,spmi-pmic";
> reg = <0x1 SPMI_USID>;
> - #address-cells = <1>;
> - #size-cells = <0>;
>
> pms405_spmi_regulators: regulators {
> compatible = "qcom,pms405-regulators";
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes
2019-07-30 16:35 ` Amit Kucheria
@ 2019-07-31 8:15 ` Vinod Koul
0 siblings, 0 replies; 8+ messages in thread
From: Vinod Koul @ 2019-07-31 8:15 UTC (permalink / raw)
To: Amit Kucheria
Cc: Andy Gross, linux-arm-msm, Bjorn Andersson, Rob Herring,
Mark Rutland,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML
Thanks for the review Amit!
On 30-07-19, 22:05, Amit Kucheria wrote:
> On Thu, Jul 25, 2019 at 7:23 PM Vinod Koul <vkoul@kernel.org> wrote:
> >
> > The adc nodes have reg property but were missing the unit name, so add
> > that to fix these warnings:
> >
> > arch/arm64/boot/dts/qcom/pms405.dtsi:91.12-94.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/ref_gnd: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:96.14-99.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vref_1p25: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:101.19-104.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vph_pwr: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:106.13-109.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/die_temp: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:111.27-116.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor1: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:118.27-123.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor3: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:125.22-130.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/xo_temp: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/pms405.dtsi | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
> > index 14240fedd916..3c10cf04d26e 100644
> > --- a/arch/arm64/boot/dts/qcom/pms405.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> > @@ -88,41 +88,41 @@
> > #size-cells = <0>;
> > #io-channel-cells = <1>;
> >
> > - ref_gnd {
> > + ref_gnd@0 {
> > reg = <ADC5_REF_GND>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - vref_1p25 {
> > + vref_1p25@1 {
> > reg = <ADC5_1P25VREF>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pon_1: vph_pwr {
> > + pon_1: vph_pwr@131 {
> > reg = <ADC5_VPH_PWR>;
> > qcom,pre-scaling = <1 3>;
> > };
> >
> > - die_temp {
> > + die_temp@6 {
> > reg = <ADC5_DIE_TEMP>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pa_therm1: thermistor1 {
> > + pa_therm1: thermistor1@115 {
>
> s/115/77 ?
>
> > reg = <ADC5_AMUX_THM1_100K_PU>;
> > qcom,ratiometric;
> > qcom,hw-settle-time = <200>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pa_therm3: thermistor3 {
> > + pa_therm3: thermistor3@117 {
>
> s/117/79 ?
>
> > reg = <ADC5_AMUX_THM3_100K_PU>;
> > qcom,ratiometric;
> > qcom,hw-settle-time = <200>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - xo_therm: xo_temp {
> > + xo_therm: xo_temp@114 {
>
> s/114/76 ?
Thanks, will fix these and recheck others.
--
~Vinod
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-07-31 8:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-25 13:51 [PATCH 0/3] arm64: dts: qcom: qcs404: Fix DTS warnings Vinod Koul
2019-07-25 13:51 ` [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes Vinod Koul
2019-07-30 16:35 ` Amit Kucheria
2019-07-31 8:15 ` Vinod Koul
2019-07-25 13:51 ` [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties Vinod Koul
2019-07-30 16:36 ` Amit Kucheria
2019-07-25 13:51 ` [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points Vinod Koul
2019-07-30 16:36 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).