From: Mark Brown <broonie@kernel.org>
To: Thomas Preston <thomas.preston@codethink.co.uk>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
Rob Duncan <rduncan@tesla.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Kirill Marinushkin <kmarinushkin@birdec.tech>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Annaliese McDermond <nh6z@nh6z.net>,
Paul Cercueil <paul@crapouillou.net>,
Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Nate Case <ncase@tesla.com>,
Cheng-Yi Chiang <cychiang@chromium.org>,
Patrick Glaser <pglaser@tesla.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [alsa-devel] [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier
Date: Tue, 30 Jul 2019 15:33:39 +0100 [thread overview]
Message-ID: <20190730143339.GH4264@sirena.org.uk> (raw)
In-Reply-To: <16a99e45-fd5a-2878-acf9-63518f9ca527@codethink.co.uk>
[-- Attachment #1: Type: text/plain, Size: 971 bytes --]
On Tue, Jul 30, 2019 at 03:12:21PM +0100, Thomas Preston wrote:
> On 30/07/2019 14:12, Marco Felsch wrote:
> >>> +- compatible : "st,tda7802"
> >>> +- reg : the I2C address of the device
> >>> +- enable-supply : a regulator spec for the PLLen pin
> > Shouldn't that be a pin called 'pllen-gpios'? IMHO I would not use a
> > regulator for that.
> Hi Marco,
> We have multiple amplifiers hooked up in a chain, and all the PLLens
> are connected to one GPIO. So we need to use a regulator so that
> i2c-TDA7802:00 doesn't turn off the PLLen which i2c-TDA7802:01 still
> requires.
> This is why we use a regulator. Is there GPIO support for this?
If it's a GPIO not a regulator then it should be a GPIO not a regulator
in the device tree. The device tree describes the hardware. There was
some work on helping share GPIOs in the GPIO framework to accomodate
GPIOs for regulator enables, you should be able to do something similar
to what the regulator framework does.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-07-30 14:33 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 12:09 [PATCH v2 0/3] ASoC: Codecs: Add TDA7802 codec Thomas Preston
2019-07-30 12:09 ` [PATCH v2 1/3] dt-bindings: ASoC: Add TDA7802 amplifier Thomas Preston
2019-07-30 12:27 ` Charles Keepax
2019-07-30 13:12 ` Marco Felsch
2019-07-30 14:12 ` [alsa-devel] " Thomas Preston
2019-07-30 14:33 ` Mark Brown [this message]
2019-07-30 14:10 ` Thomas Preston
2019-07-30 12:09 ` [PATCH v2 2/3] ASoC: Add codec driver for ST TDA7802 Thomas Preston
2019-07-30 12:38 ` Charles Keepax
2019-07-30 15:49 ` [alsa-devel] " Thomas Preston
2019-07-30 14:58 ` Mark Brown
2019-07-30 17:26 ` [alsa-devel] " Thomas Preston
2019-07-31 6:06 ` Marco Felsch
2019-07-31 8:57 ` Thomas Preston
2019-07-30 12:09 ` [PATCH v2 3/3] ASoC: TDA7802: Add turn-on diagnostic routine Thomas Preston
2019-07-30 12:41 ` Charles Keepax
2019-07-30 14:04 ` [alsa-devel] " Thomas Preston
2019-07-30 14:18 ` Charles Keepax
2019-07-30 14:20 ` [alsa-devel] " Mark Brown
2019-07-30 15:27 ` Thomas Preston
2019-07-30 14:19 ` Mark Brown
2019-07-30 15:25 ` [alsa-devel] " Thomas Preston
2019-07-30 15:50 ` Mark Brown
2019-07-30 16:28 ` Thomas Preston
2019-07-31 8:03 ` Charles Keepax
2019-08-01 23:42 ` Mark Brown
2019-08-02 8:32 ` Thomas Preston
2019-08-02 11:10 ` Mark Brown
2019-08-02 14:51 ` Thomas Preston
2019-08-02 17:27 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190730143339.GH4264@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kmarinushkin@birdec.tech \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.rutland@arm.com \
--cc=ncase@tesla.com \
--cc=nh6z@nh6z.net \
--cc=paul@crapouillou.net \
--cc=pglaser@tesla.com \
--cc=rduncan@tesla.com \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.preston@codethink.co.uk \
--cc=tiwai@suse.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).