From: Vinod Koul <vkoul@kernel.org>
To: Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Andy Gross <agross@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes
Date: Wed, 31 Jul 2019 13:45:18 +0530 [thread overview]
Message-ID: <20190731081518.GS12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <CAHLCerNsAX4raauTjogOpwqAjEWfd+jpaZYsFnC10tcmvnD5cg@mail.gmail.com>
Thanks for the review Amit!
On 30-07-19, 22:05, Amit Kucheria wrote:
> On Thu, Jul 25, 2019 at 7:23 PM Vinod Koul <vkoul@kernel.org> wrote:
> >
> > The adc nodes have reg property but were missing the unit name, so add
> > that to fix these warnings:
> >
> > arch/arm64/boot/dts/qcom/pms405.dtsi:91.12-94.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/ref_gnd: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:96.14-99.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vref_1p25: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:101.19-104.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/vph_pwr: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:106.13-109.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/die_temp: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:111.27-116.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor1: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:118.27-123.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/thermistor3: node has a reg or ranges property, but no unit name
> > arch/arm64/boot/dts/qcom/pms405.dtsi:125.22-130.6: Warning (unit_address_vs_reg): /soc@0/spmi@200f000/pms405@0/adc@3100/xo_temp: node has a reg or ranges property, but no unit name
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > arch/arm64/boot/dts/qcom/pms405.dtsi | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/pms405.dtsi b/arch/arm64/boot/dts/qcom/pms405.dtsi
> > index 14240fedd916..3c10cf04d26e 100644
> > --- a/arch/arm64/boot/dts/qcom/pms405.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/pms405.dtsi
> > @@ -88,41 +88,41 @@
> > #size-cells = <0>;
> > #io-channel-cells = <1>;
> >
> > - ref_gnd {
> > + ref_gnd@0 {
> > reg = <ADC5_REF_GND>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - vref_1p25 {
> > + vref_1p25@1 {
> > reg = <ADC5_1P25VREF>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pon_1: vph_pwr {
> > + pon_1: vph_pwr@131 {
> > reg = <ADC5_VPH_PWR>;
> > qcom,pre-scaling = <1 3>;
> > };
> >
> > - die_temp {
> > + die_temp@6 {
> > reg = <ADC5_DIE_TEMP>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pa_therm1: thermistor1 {
> > + pa_therm1: thermistor1@115 {
>
> s/115/77 ?
>
> > reg = <ADC5_AMUX_THM1_100K_PU>;
> > qcom,ratiometric;
> > qcom,hw-settle-time = <200>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - pa_therm3: thermistor3 {
> > + pa_therm3: thermistor3@117 {
>
> s/117/79 ?
>
> > reg = <ADC5_AMUX_THM3_100K_PU>;
> > qcom,ratiometric;
> > qcom,hw-settle-time = <200>;
> > qcom,pre-scaling = <1 1>;
> > };
> >
> > - xo_therm: xo_temp {
> > + xo_therm: xo_temp@114 {
>
> s/114/76 ?
Thanks, will fix these and recheck others.
--
~Vinod
next prev parent reply other threads:[~2019-07-31 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 13:51 [PATCH 0/3] arm64: dts: qcom: qcs404: Fix DTS warnings Vinod Koul
2019-07-25 13:51 ` [PATCH 1/3] arm64: dts: qcom: pms405: add unit name adc nodes Vinod Koul
2019-07-30 16:35 ` Amit Kucheria
2019-07-31 8:15 ` Vinod Koul [this message]
2019-07-25 13:51 ` [PATCH 2/3] arm64: dts: qcom: pms405: remove reduandant properties Vinod Koul
2019-07-30 16:36 ` Amit Kucheria
2019-07-25 13:51 ` [PATCH 3/3] arm64: dts: qcom: qcs404: remove unit name for thermal trip points Vinod Koul
2019-07-30 16:36 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190731081518.GS12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@verdurent.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).