From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v2 2/6] pwm: jz4740: Remove unused devicetree compatible strings Date: Thu, 8 Aug 2019 10:24:44 +0200 Message-ID: <20190808082444.y4pnl5gofmeftpe6@pengutronix.de> References: <20190607154410.10633-1-paul@crapouillou.net> <20190607154410.10633-3-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20190607154410.10633-3-paul@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org To: Paul Cercueil Cc: Thierry Reding , Rob Herring , Mark Rutland , od@zcrc.me, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Fri, Jun 07, 2019 at 05:44:06PM +0200, Paul Cercueil wrote: > Right now none of the Ingenic-based boards probe this driver from > devicetree. This driver defined three compatible strings for the exact > same behaviour. Before these strings are used, we can remove two of > them. > > Signed-off-by: Paul Cercueil No hard opinion on my side on this one. Keeping the unused compatibles around (maybe with a comment to prefer ingenic,jz4740-pwm) is what I would have done. If you're really sure nobody used the two removed ones this is fine. The binding already requests that ingenic,jz4740-pwm is to be used. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |