From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mark Brown <broonie@kernel.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: qcom-rpmh: Add support for SM8150
Date: Fri, 9 Aug 2019 10:14:35 +0530 [thread overview]
Message-ID: <20190809044435.GE12733@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20190809033255.GL26807@tuxbook-pro>
On 08-08-19, 20:32, Bjorn Andersson wrote:
> On Thu 08 Aug 02:33 PDT 2019, Vinod Koul wrote:
> > diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> [..]
> > +static const struct rpmh_vreg_hw_data pmic5_bob = {
> > + .regulator_type = VRM,
> > + .ops = &rpmh_regulator_vrm_bypass_ops,
> > + .voltage_range = REGULATOR_LINEAR_RANGE(300000, 0, 135, 32000),
> > + .n_voltages = 135,
>
> There are 136 voltages in [0,135]
Oops, will send an update
>
> > + .pmic_mode_map = pmic_mode_map_pmic4_bob,
> > + .of_map_mode = rpmh_regulator_pmic4_bob_of_map_mode,
> > +};
> > +
> [..]
> > @@ -755,6 +890,18 @@ static const struct of_device_id rpmh_regulator_match_table[] = {
> > .compatible = "qcom,pm8005-rpmh-regulators",
> > .data = pm8005_vreg_data,
> > },
> > + {
> > + .compatible = "qcom,pm8150-rpmh-regulators",
> > + .data = pm8150_vreg_data,
> > + },
> > + {
> > + .compatible = "qcom,pm8150l-rpmh-regulators",
> > + .data = pm8150l_vreg_data,
> > + },
> > + {
> > + .compatible = "qcom,pm8009-rpmh-regulators",
> > + .data = pm8009_vreg_data,
> > + },
>
> Sort order...
Yes will sort all entries.
> > {}
> > };
> > MODULE_DEVICE_TABLE(of, rpmh_regulator_match_table);
>
> Apart from these nits this looks good.
Thanks :)
--
~Vinod
next prev parent reply other threads:[~2019-08-09 4:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 9:33 [PATCH 1/2] regulator: dt-bindings: Add PM8150x compatibles Vinod Koul
2019-08-08 9:33 ` [PATCH 2/2] regulator: qcom-rpmh: Add support for SM8150 Vinod Koul
2019-08-08 20:33 ` Applied "regulator: qcom-rpmh: Add support for SM8150" to the regulator tree Mark Brown
2019-08-09 3:32 ` [PATCH 2/2] regulator: qcom-rpmh: Add support for SM8150 Bjorn Andersson
2019-08-09 4:44 ` Vinod Koul [this message]
2019-08-08 20:33 ` Applied "regulator: dt-bindings: Add PM8150x compatibles" to the regulator tree Mark Brown
2019-08-09 3:29 ` [PATCH 1/2] regulator: dt-bindings: Add PM8150x compatibles Bjorn Andersson
2019-08-09 4:43 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190809044435.GE12733@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).