From: Rob Herring <robh@kernel.org>
To: Srinath Mannam <srinath.mannam@broadcom.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mathias Nyman <mathias.nyman@intel.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH v2 2/5] dt-bindings: phy: Modify Stingray USB PHY #phy-cells
Date: Wed, 21 Aug 2019 13:21:19 -0500 [thread overview]
Message-ID: <20190821182119.GA27408@bogus> (raw)
In-Reply-To: <1564568395-9980-3-git-send-email-srinath.mannam@broadcom.com>
On Wed, Jul 31, 2019 at 03:49:52PM +0530, Srinath Mannam wrote:
> Increase #phy-cells from 1 to 2 to have bitmask of PHY enabled ports.
And from 0 to 1...
Are you going to update all the dts files so when we convert this to
schema we don't get a bunch of warnings? (Feel free to convert this
to schema too).
>
> Signed-off-by: Srinath Mannam <srinath.mannam@broadcom.com>
> ---
> .../devicetree/bindings/phy/brcm,stingray-usb-phy.txt | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt b/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
> index 4ba2989..aeb0568 100644
> --- a/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
> +++ b/Documentation/devicetree/bindings/phy/brcm,stingray-usb-phy.txt
> @@ -6,9 +6,11 @@ Required properties:
> - "brcm,sr-usb-hs-phy" is a single HS PHY.
> - reg: offset and length of the PHY blocks registers
> - #phy-cells:
> - - Must be 1 for brcm,sr-usb-combo-phy as it expects one argument to indicate
> - the PHY number of two PHYs. 0 for HS PHY and 1 for SS PHY.
> - - Must be 0 for brcm,sr-usb-hs-phy.
> + - Must be 2 for brcm,sr-usb-combo-phy.
> + - Cell 1 - PHY Number, 0 for HS PHY and 1 for SS PHY.
> + - Cell 2 - Bitmask of enabled ports connected to USB Host controller.
> + - Must be 1 for brcm,sr-usb-hs-phy to indicate Bit mask of ports connected
> + to USB Host controller.
>
> Refer to phy/phy-bindings.txt for the generic PHY binding properties
>
> @@ -16,17 +18,17 @@ Example:
> usbphy0: usb-phy@0 {
> compatible = "brcm,sr-usb-combo-phy";
> reg = <0x00000000 0x100>;
> - #phy-cells = <1>;
> + #phy-cells = <2>;
> };
>
> usbphy1: usb-phy@10000 {
> compatible = "brcm,sr-usb-combo-phy";
> reg = <0x00010000 0x100>,
> - #phy-cells = <1>;
> + #phy-cells = <2>;
> };
>
> usbphy2: usb-phy@20000 {
> compatible = "brcm,sr-usb-hs-phy";
> reg = <0x00020000 0x100>,
> - #phy-cells = <0>;
> + #phy-cells = <1>;
> };
> --
> 2.7.4
>
next prev parent reply other threads:[~2019-08-21 18:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 10:19 [PATCH v2 0/4] Reset xHCI port PHY on disconnect Srinath Mannam
2019-07-31 10:19 ` [PATCH v2 1/5] phy: Add phy ports in attrs Srinath Mannam
2019-07-31 10:19 ` [PATCH v2 2/5] dt-bindings: phy: Modify Stingray USB PHY #phy-cells Srinath Mannam
2019-08-21 18:21 ` Rob Herring [this message]
2019-08-28 5:54 ` Srinath Mannam
2019-07-31 10:19 ` [PATCH v2 3/5] phy: sr-usb: Set phy ports Srinath Mannam
2019-07-31 10:19 ` [PATCH v2 4/5] dt-bindings: usb-xhci: Add platform specific compatible for Stingray xHCI Srinath Mannam
2019-08-21 18:22 ` Rob Herring
2019-07-31 10:19 ` [PATCH v2 5/5] drivers: xhci: Add quirk to reset xHCI port PHY Srinath Mannam
2019-09-03 14:59 ` [PATCH v2 0/4] Reset xHCI port PHY on disconnect Srinath Mannam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190821182119.GA27408@bogus \
--to=robh@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathias.nyman@intel.com \
--cc=srinath.mannam@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).