devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Douglas Anderson <dianders@chromium.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Marco Felsch <m.felsch@pengutronix.de>,
	ckeepax@opensource.cirrus.com, zhang.chunyan@linaro.org,
	devicetree@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH] regulator: Document "regulator-boot-on" binding more thoroughly
Date: Tue, 1 Oct 2019 18:41:04 +0100	[thread overview]
Message-ID: <20191001174104.GD4786@sirena.co.uk> (raw)
In-Reply-To: <20190926124115.1.Ice34ad5970a375c3c03cb15c3859b3ee501561bf@changeid>

[-- Attachment #1: Type: text/plain, Size: 861 bytes --]

On Thu, Sep 26, 2019 at 12:41:18PM -0700, Douglas Anderson wrote:

> -    description: bootloader/firmware enabled regulator
> +    description: bootloader/firmware enabled regulator.
> +      It's expected that this regulator was left on by the bootloader.
> +      If the bootloader didn't leave it on then OS should turn it on
> +      at boot but shouldn't prevent it from being turned off later.

This is good...

> +      This property is intended to only be used for regulators where
> +      Linux cannot read the state of the regulator at bootup.

...but we shouldn't say "Linux" here since the DT binding is for all
OSs, not just Linux.  I'd say "software" instead.  Really the
expectation is that things wouldn't support readback at all, though it's
possible there's some weird hardware out there that will support
readback some of the time I guess.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-10-01 17:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26 19:41 [PATCH] regulator: Document "regulator-boot-on" binding more thoroughly Douglas Anderson
2019-10-01 17:41 ` Mark Brown [this message]
2019-10-01 19:46   ` Doug Anderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191001174104.GD4786@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m.felsch@pengutronix.de \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zhang.chunyan@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).