From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Tudor.Ambarus@microchip.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, robh+dt@kernel.org,
kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
darshak.patel@einfochips.com, prajose.john@einfochips.com,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, marek.vasut@gmail.com,
dwmw2@infradead.org, computersforpeace@gmail.com,
miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw
Date: Fri, 1 Nov 2019 20:28:06 +0530 [thread overview]
Message-ID: <20191101145806.GB13101@Mani-XPS-13-9360> (raw)
In-Reply-To: <87e0b459-8dbf-26cc-611f-1b1b5266aa55@microchip.com>
Hi Tudor,
On Fri, Nov 01, 2019 at 01:48:17PM +0000, Tudor.Ambarus@microchip.com wrote:
>
>
> On 10/30/2019 11:01 AM, Manivannan Sadhasivam wrote:
> > External E-Mail
> >
> >
> > Add MTD support for w25q256jw SPI NOR chip from Winbond. This chip
> > supports dual/quad I/O mode with 512 blocks of memory organized in
> > 64KB sectors. In addition to this, there is also small 4KB sectors
> > available for flexibility. The device has been validated using Thor96
> > board.
> >
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > Cc: Tudor Ambarus <tudor.ambarus@microchip.com>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: Miquel Raynal <miquel.raynal@bootlin.com>
> > Cc: Richard Weinberger <richard@nod.at>
> > Cc: Vignesh Raghavendra <vigneshr@ti.com>
> > Cc: linux-mtd@lists.infradead.org
> > Signed-off-by: Darshak Patel <darshak.patel@einfochips.com>
> > [Mani: cleaned up for upstream]
>
> Can we keep Darshak's authorship? We usually change the author if we feel that
> we made a significant change to what was originally published.
>
> If it's just about cosmetics, cleaning or rebase, you can specify what you did
> after the author's S-o-b tag and then add your S-o-b, as you did above.
>
I'd suggest to keep Darshak's authorship since he did the actual change in
the bsp. I have to clean it up before submitting upstream and I mentioned
the same above.
> The patch looks good.
>
Thanks,
Mani
> Cheers,
> ta
>
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> > ---
> > drivers/mtd/spi-nor/spi-nor.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> > index 1d8621d43160..2c25b371d9f0 100644
> > --- a/drivers/mtd/spi-nor/spi-nor.c
> > +++ b/drivers/mtd/spi-nor/spi-nor.c
> > @@ -2482,6 +2482,8 @@ static const struct flash_info spi_nor_ids[] = {
> > { "w25q256", INFO(0xef4019, 0, 64 * 1024, 512, SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25q256jvm", INFO(0xef7019, 0, 64 * 1024, 512,
> > SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > + { "w25q256jw", INFO(0xef6019, 0, 64 * 1024, 512,
> > + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> > SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> >
> >
next prev parent reply other threads:[~2019-11-01 14:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 9:01 [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 1/4] dt-bindings: leds: Document commonly used LED triggers Manivannan Sadhasivam
2019-11-05 22:04 ` Rob Herring
2019-10-30 9:01 ` [PATCH v2 2/4] dt-bindings: arm: Add devicetree binding for Thor96 Board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 3/4] arm64: dts: freescale: Add devicetree support for Thor96 board Manivannan Sadhasivam
2019-10-30 9:01 ` [PATCH v2 4/4] mtd: spi-nor: Add support for w25q256jw Manivannan Sadhasivam
2019-11-01 13:48 ` Tudor.Ambarus
2019-11-01 14:58 ` Manivannan Sadhasivam [this message]
2019-11-01 15:55 ` Tudor.Ambarus
2019-11-01 16:09 ` Manivannan Sadhasivam
2019-11-07 12:30 ` Tudor.Ambarus
2019-11-07 12:40 ` Manivannan Sadhasivam
2019-11-11 19:31 ` Tudor.Ambarus
2020-01-09 3:33 ` [PATCH v2 0/4] Add support for Thor96 board Manivannan Sadhasivam
2020-01-09 6:39 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101145806.GB13101@Mani-XPS-13-9360 \
--to=manivannan.sadhasivam@linaro.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=computersforpeace@gmail.com \
--cc=darshak.patel@einfochips.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=prajose.john@einfochips.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).