From: kbuild test robot <lkp@intel.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: kbuild-all@lists.01.org, Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, od@zcrc.me,
Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 2/2] power/supply: Add generic USB charger driver
Date: Mon, 4 Nov 2019 06:52:36 +0800 [thread overview]
Message-ID: <201911040607.oYqvDzXW%lkp@intel.com> (raw)
In-Reply-To: <20191103220801.10666-2-paul@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 2493 bytes --]
Hi Paul,
I love your patch! Yet something to improve:
[auto build test ERROR on power-supply/for-next]
[cannot apply to v5.4-rc6 next-20191031]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Paul-Cercueil/dt-bindings-power-supply-Document-generic-USB-charger/20191104-061214
base: https://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.4.0 make.cross ARCH=sh
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All error/warnings (new ones prefixed by >>):
>> drivers/power/supply/generic-usb-charger.c:131:21: error: implicit declaration of function 'of_match_ptr'; did you mean 'usb_match_id'? [-Werror=implicit-function-declaration]
.of_match_table = of_match_ptr(usb_charger_of_match),
^~~~~~~~~~~~
usb_match_id
>> drivers/power/supply/generic-usb-charger.c:131:21: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
drivers/power/supply/generic-usb-charger.c:131:21: note: (near initialization for 'usb_charger_driver.driver.of_match_table')
>> drivers/power/supply/generic-usb-charger.c:131:21: error: initializer element is not constant
drivers/power/supply/generic-usb-charger.c:131:21: note: (near initialization for 'usb_charger_driver.driver.of_match_table')
cc1: some warnings being treated as errors
vim +131 drivers/power/supply/generic-usb-charger.c
127
128 static struct platform_driver usb_charger_driver = {
129 .driver = {
130 .name = "usb-charger",
> 131 .of_match_table = of_match_ptr(usb_charger_of_match),
132 },
133 .probe = usb_charger_probe,
134 .remove = usb_charger_remove,
135 };
136 module_platform_driver(usb_charger_driver);
137
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 52250 bytes --]
next prev parent reply other threads:[~2019-11-03 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-03 22:08 [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger Paul Cercueil
2019-11-03 22:08 ` [PATCH 2/2] power/supply: Add generic USB charger driver Paul Cercueil
2019-11-03 22:52 ` kbuild test robot [this message]
2019-11-29 14:03 ` Sebastian Reichel
2019-11-04 13:52 ` [PATCH 1/2] dt-bindings: power/supply: Document generic USB charger Rob Herring
2019-11-05 9:16 ` Paul Cercueil
2019-11-05 13:48 ` Rob Herring
2019-11-05 23:16 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201911040607.oYqvDzXW%lkp@intel.com \
--to=lkp@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).