From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D456CA9ED3 for ; Tue, 5 Nov 2019 01:58:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 31BA720848 for ; Tue, 5 Nov 2019 01:58:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572919111; bh=1/dwl0HMZv0HXnINUPRcw2ppA3ERAUnWy/O87vieVCs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=yEF1WT6IIPuI22ONbmZ0hOI1OT0TmltsKF3JVDo4MdhPDkekTCSaFca+/3jIIy4zo cXFTjzdqaEfp5fcfzRJvYMZuYaULcm1FZqjzDoSOw2HjX2i/sxfVwdQnBLZJiG5aDd 2RSyTVGOapL0lG40zauFJ/yHLH+O6yAccPNSIWJg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729873AbfKEB6a (ORCPT ); Mon, 4 Nov 2019 20:58:30 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:45505 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729597AbfKEB6a (ORCPT ); Mon, 4 Nov 2019 20:58:30 -0500 Received: by mail-ot1-f65.google.com with SMTP id 77so11838125oti.12; Mon, 04 Nov 2019 17:58:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=gmYraXUwBZGb7SjnYfb7LVvYyu+EbS6Dq6WsiW6ugLQ=; b=W+gLolNegV0kBHweDucIh4cXTdNJN24nGK2Doc2xWFKEPfP4O9lJ36H32wPa+s7qne QOCzejraKrhq4LspATp6iB/6J3GNw+yCu6xGF0QMsdy7xaPYO1zn/nDEorGUG9cBMmlN NyvG1JxsKEjqlVW4tUVBTdXFKyb+LiEA27d8HGog2vpQrf4f8pki788HcTaRQ1lExfJu JQnemhX2RnECz0giB7nvT2YoYHBVU2XPiFvJ3aw4smzdhPFl5QglhFtzgfl3OAIbDP94 P2mJPKNuzcnYSox2exJHoSoi6kSogRsXpn1RxB7TUlXbRQcXHNdsqnmyouka71mVzXje aRzw== X-Gm-Message-State: APjAAAVjSeGhkDs0nuLNRfapBmvF3krFBSAf+TKqpKkctPIgCKG+aecb J4JaohYmxqjMUIS/ipQblw== X-Google-Smtp-Source: APXvYqx9fT0D63eHAknVkyowX+0cfZhjqiWWNlSNjVlzbGr8k08aYwX9ohraNUzyt9RHvzcqojdddQ== X-Received: by 2002:a9d:1c8f:: with SMTP id l15mr16727710ota.313.1572919109034; Mon, 04 Nov 2019 17:58:29 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id q82sm513021oif.11.2019.11.04.17.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 17:58:28 -0800 (PST) Date: Mon, 4 Nov 2019 19:58:27 -0600 From: Rob Herring To: Matheus Castello Cc: sre@kernel.org, krzk@kernel.org, mark.rutland@arm.com, cw00.choi@samsung.com, b.zolnierkie@samsung.com, lee.jones@linaro.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/4] dt-bindings: power: supply: Max17040: Add low level SOC alert threshold Message-ID: <20191105015827.GA332@bogus> References: <20191031184134.30621-1-matheus@castello.eng.br> <20191031184134.30621-3-matheus@castello.eng.br> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191031184134.30621-3-matheus@castello.eng.br> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, Oct 31, 2019 at 03:41:32PM -0300, Matheus Castello wrote: > For configure low level state of charge threshold alert signaled from > max17040 we add "maxim,alert-low-soc-level" property. This doesn't match the change. You're adding a whole new device binding. > Signed-off-by: Matheus Castello > --- > .../power/supply/max17040_battery.txt | 33 +++++++++++++++++++ Part of an MFD? The MFD binding should reference this file then. > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/power/supply/max17040_battery.txt > > diff --git a/Documentation/devicetree/bindings/power/supply/max17040_battery.txt b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt > new file mode 100644 > index 000000000000..f2d0b22b5f79 > --- /dev/null > +++ b/Documentation/devicetree/bindings/power/supply/max17040_battery.txt > @@ -0,0 +1,33 @@ > +max17040_battery > +~~~~~~~~~~~~~~~~ > + > +Required properties : > + - compatible : "maxim,max17040" or "maxim,max77836-battery" > + - reg: i2c slave address > + > +Optional properties : > +- maxim,alert-low-soc-level : The alert threshold that sets the state of > + charge level (%) where an interrupt is > + generated. Can be configured from 1 up to 32 > + (%). If skipped the power up default value of > + 4 (%) will be used. Seems like something that should be a common battery property. > +- interrupts : Interrupt line see Documentation/devicetree/ > + bindings/interrupt-controller/interrupts.txt > +- wakeup-source : This device has wakeup capabilities. Use this > + property to use alert low SOC level interrupt > + as wake up source. > + > +Optional properties support interrupt functionality for alert low state of > +charge level, present in some ICs in the same family, and should be used with > +compatible "maxim,max77836-battery". > + > +Example: > + > + battery-fuel-gauge@36 { > + compatible = "maxim,max77836-battery"; > + reg = <0x36>; > + maxim,alert-low-soc-level = <10>; > + interrupt-parent = <&gpio7>; > + interrupts = <2 IRQ_TYPE_EDGE_FALLING>; > + wakeup-source; > + }; > -- > 2.24.0.rc2 >