From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4F38C43331 for ; Mon, 11 Nov 2019 13:36:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A58F222CF for ; Mon, 11 Nov 2019 13:36:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c6ruehmM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726832AbfKKNgW (ORCPT ); Mon, 11 Nov 2019 08:36:22 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:44755 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726928AbfKKNgV (ORCPT ); Mon, 11 Nov 2019 08:36:21 -0500 Received: by mail-wr1-f66.google.com with SMTP id f2so14615557wrs.11 for ; Mon, 11 Nov 2019 05:36:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=0s9ZynTVj8MKyIhAnnLXh+oQ19lAh04mL6+1frjsEwU=; b=c6ruehmMh/cva0d4uTQ9KOMr4Uf69bUn/3AhPtA/HZmCVJ8H1L0JWTAUrYzMGP/SkY HVvxkQccjvl1SbbGmizCg0YUx/hXIsWM3cCFALBEGEfAsmShHRkA0YuzZbaMXtpZ1SQQ tOA/jBvVAdm/W797X0W1Wj6K7RETkhkTKos+BO/+SCBA4zRVJL1l+bB/nhgeQRbu3Csf zjS8Hg6M2MW9YWOmE2i5vvxe3ANl8o7WrrrbTKZZvgKBhavqI82JAVZKW7Bx1U0/W40U RXZIWXwPCCZEee6oXd1ZR4U6bhQI5pEgWHgZI07HFiMPyUmsyzZvGgMw+tbr6EP4CVvs 9pSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=0s9ZynTVj8MKyIhAnnLXh+oQ19lAh04mL6+1frjsEwU=; b=uR18DOPW1t4pvlDMHTygVe3hCE/wFGNjBqeUNYBwhWF40Ke9SXjf65bT7ms9QV6L+L 04oRpjf+ti774xXeIgjiu07ZaYPSRxE7ls3iCLa8VJd0SfecqTJ81EIPB9DZWi1OM2n8 2tMxzjHxImpureDQtysKde14uVqIZCIqfG9GEHP55Wzo1GGR/Mv9mYo6NUPPfUspXap/ VPBLfvjvcmlpXEGhnICcnDordPnBD22pTv65UA1PLqQodI0Ra692vVdVrrK9ACZ0bVPN AcUd2DHU+977SiLKjORU6HrVpQL4LGivSXpQscbstv513tt4SGXseMlL28JGke3pLnfU dXaA== X-Gm-Message-State: APjAAAVwsciFfhduTQq+pgVWlNvPZo8sCr1Fph/8jKccYraSLtNRGDCe 6MfJqYBvydZr/m9lCR1fC57JgQ== X-Google-Smtp-Source: APXvYqzHgmTe66oXstdgxQO4KmGrIbywCgH/1P35rEMm83LcQyasx1HVyYnWKQ86oUmVQzSdPuzgPg== X-Received: by 2002:adf:9185:: with SMTP id 5mr22081841wri.389.1573479378512; Mon, 11 Nov 2019 05:36:18 -0800 (PST) Received: from dell ([95.147.198.88]) by smtp.gmail.com with ESMTPSA id q5sm13960498wmc.27.2019.11.11.05.36.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Nov 2019 05:36:18 -0800 (PST) Date: Mon, 11 Nov 2019 13:36:10 +0000 From: Lee Jones To: Srinivas Kandagatla Cc: robh@kernel.org, broonie@kernel.org, linus.walleij@linaro.org, vinod.koul@linaro.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, spapothi@codeaurora.org, bgoswami@codeaurora.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH v3 02/11] mfd: wcd934x: add support to wcd9340/wcd9341 codec Message-ID: <20191111133610.GO3218@dell> References: <20191029112700.14548-1-srinivas.kandagatla@linaro.org> <20191029112700.14548-3-srinivas.kandagatla@linaro.org> <20191111111836.GH3218@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org > > > +static void wcd934x_slim_remove(struct slim_device *sdev) > > > +{ > > > + struct wcd934x_ddata *ddata = dev_get_drvdata(&sdev->dev); > > > + > > > + regulator_bulk_disable(WCD934X_MAX_SUPPLY, ddata->supplies); > > > + mfd_remove_devices(&sdev->dev); > > > + kfree(ddata); > > > +} > > > + > > > +static const struct slim_device_id wcd934x_slim_id[] = { > > > + { SLIM_MANF_ID_QCOM, SLIM_PROD_CODE_WCD9340, 0x1, 0x0 }, > > > > What do the last parameters mean? Might be better to define them. > > This is Instance ID and Device ID of SLIMBus enumeration address. Great. Please define them in the same was you did for the product code. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog