From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB46DC43141 for ; Thu, 14 Nov 2019 07:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A0A5F206E6 for ; Thu, 14 Nov 2019 07:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573715757; bh=CdaQJfZeE12NS1/9Gejd29MDaXIfXJWzS072VrL8Xes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=t/hLM9JjNSXwXDtDSXy/wa+vv/gJjdHEhsUxamjJQ9mUyrkPoLO9gBjHhzOpyO2t8 C9BOXg9+wqFlC3dkKbOC/LYyu518Mw/eMv85jUh3MMYwPNNtri0mvDVAKLVj0++ZZK hzS8hUJSV1+cXgyE+QXWjaMKcsq/VrGZHHDm0lCw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725852AbfKNHP5 (ORCPT ); Thu, 14 Nov 2019 02:15:57 -0500 Received: from mail.kernel.org ([198.145.29.99]:44004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbfKNHP5 (ORCPT ); Thu, 14 Nov 2019 02:15:57 -0500 Received: from localhost (unknown [223.226.110.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 539B9206C0; Thu, 14 Nov 2019 07:15:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573715756; bh=CdaQJfZeE12NS1/9Gejd29MDaXIfXJWzS072VrL8Xes=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PhsOCoDGSgOK8ezKmJxaKvTdSHilYh12J6nNN8tFokL7n2P2BHdFFLr3jKRR4wcSB kHkUc5uIaH/d1CCakQKBk9IVDJHVa0Hzz7WHtWGluW3kwSI9Kb0arWaeqG8M6/M0vt /5dpCcS3I4+Zhf/lF6Xke7riMzVuVnG37CmLzPhs= Date: Thu, 14 Nov 2019 12:45:51 +0530 From: Vinod Koul To: Green Wan Cc: Rob Herring , Mark Rutland , Palmer Dabbelt , Paul Walmsley , Albert Ou , Dan Williams , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , "Paul E. McKenney" , Bin Meng , Yash Shah , Sagar Kadam , dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 0/4] dmaengine: sf-pdma: Add platform dma driver Message-ID: <20191114071551.GQ952516@vkoul-mobl> References: <20191107084955.7580-1-green.wan@sifive.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107084955.7580-1-green.wan@sifive.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 07-11-19, 16:49, Green Wan wrote: > Add PDMA driver support for SiFive HiFive Unleashed RevA00 board. Mainly follows > DMAengine controller doc[1] to implement and take other DMA drivers as reference. > Such as > > - drivers/dma/fsl-edma.c > - drivers/dma/dw-edma/ > - drivers/dma/pxa-dma.c > > Using DMA test client[2] to test. Detailed datasheet is doc[3]. Driver supports: > > - 4 physical DMA channels, share same DONE and error interrupt handler. > - Support MEM_TO_MEM > - Tested by DMA test client > - patches include DT Bindgins document and dts for fu450-c000 SoC. Separate dts > patch for easier review and apply to different branch or SoC platform. > - retry 1 time if DMA error occurs. I have applied this expect dt change. I see some warns due to missing kernel-doc style comments with W=1, please fix that and send update on top of these Thanks -- ~Vinod