From: Dan Carpenter <dan.carpenter@oracle.com>
To: Beniamin Bia <beniamin.bia@analog.com>
Cc: jic23@kernel.org, devel@driverdev.osuosl.org,
mark.rutland@arm.com, lars@metafoo.de, biabeniamin@outlook.com,
Michael.Hennerich@analog.com, devicetree@vger.kernel.org,
linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, robh+dt@kernel.org,
pmeerw@pmeerw.net, knaack.h@gmx.de,
Paul Cercueil <paul.cercueil@analog.com>
Subject: Re: [PATCH v4 2/4] iio: adc: ad7091r5: Add scale and external VREF support
Date: Fri, 15 Nov 2019 16:03:59 +0300 [thread overview]
Message-ID: <20191115130359.GE19101@kadam.lan> (raw)
In-Reply-To: <20191115122316.20893-2-beniamin.bia@analog.com>
On Fri, Nov 15, 2019 at 02:23:14PM +0200, Beniamin Bia wrote:
> @@ -216,6 +240,21 @@ int ad7091r_probe(struct device *dev, const char *name,
> return ret;
> }
>
> + st->vref = devm_regulator_get_optional(dev, "vref");
> + if (IS_ERR(st->vref)) {
> + if (PTR_ERR(st->vref) == EPROBE_DEFER)
^^^^^^^^^^^^^^^
Missing - on EPROBE_DEFER.
> + return -EPROBE_DEFER;
> +
> + st->vref = NULL;
> + } else {
> + ret = regulator_enable(st->vref);
> + if (ret)
> + return ret;
> + ret = devm_add_action_or_reset(dev, ad7091r_remove, st);
> + if (ret)
> + return ret;
> + }
Curly brace is indented an extra tab.
regards,
dan carpenter
next prev parent reply other threads:[~2019-11-15 13:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 12:23 [PATCH v4 1/4] iio: adc: Add support for AD7091R5 ADC Beniamin Bia
2019-11-15 12:23 ` [PATCH v4 2/4] iio: adc: ad7091r5: Add scale and external VREF support Beniamin Bia
2019-11-15 13:03 ` Dan Carpenter [this message]
2019-11-15 12:23 ` [PATCH v4 3/4] dt-binding: iio: Add documentation for AD7091R5 Beniamin Bia
2019-11-15 12:23 ` [PATCH v4 4/4] MAINTAINERS: add entry for AD7091R5 driver Beniamin Bia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115130359.GE19101@kadam.lan \
--to=dan.carpenter@oracle.com \
--cc=Michael.Hennerich@analog.com \
--cc=beniamin.bia@analog.com \
--cc=biabeniamin@outlook.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul.cercueil@analog.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).