From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FF72C432C3 for ; Fri, 15 Nov 2019 15:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 64D4520732 for ; Fri, 15 Nov 2019 15:22:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573831346; bh=U/9QfvsYYC8xVBCh+SiGp3vO8P82NI0IaST3A6GJQwQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=QCmzsk94XkSsfGzDVayFbLmljcLWqIkm3MpdLzOUUYruR/0Nmd2EH9RdR93k5MJHg hk3GxkmPKbwQEwk4BDQOMJpkaTxOBQcKrst5zLmjQXp8Nwmk5DdwTCrxXnkbK1V2Gz P09eUeyPhnfsAKjGIFTPIqWes82MkWo7b98F4MiM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727539AbfKOPW0 (ORCPT ); Fri, 15 Nov 2019 10:22:26 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:48674 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727434AbfKOPWZ (ORCPT ); Fri, 15 Nov 2019 10:22:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=yvGphVXhC7kan4yS8OPR8FI6+zg0lqmd5nW8y91qGdI=; b=CRII/5pq9X1slHsMZYuJp1M8h +9sKk2a7XZyUZWPC0vq/InQhtD4PUo+mF14nMIkX0kYfAntqaE5YPK1R5jW7Ped/2aX6cDYHjyo1m bs6tWPoN7XuQF8lwrdvIGodQWANZTEeZYIyJpUq0xNqWZMK1K+LgLzJcXPXp/MwxBCa8Y=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iVdQU-0000bv-LF; Fri, 15 Nov 2019 15:22:22 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 91A9927429D2; Fri, 15 Nov 2019 15:22:21 +0000 (GMT) Date: Fri, 15 Nov 2019 15:22:21 +0000 From: Mark Brown To: Rob Herring Cc: Dmitry Torokhov , lkml , linux-spi , Mark Rutland , DTML Subject: Re: [PATCH 1/2] spi: dt-bindings: spi-controller: add wakeup-source and interrupts Message-ID: <20191115152221.GA4210@sirena.co.uk> References: <20191112055412.192675-1-dmitry.torokhov@gmail.com> <20191112055412.192675-2-dmitry.torokhov@gmail.com> <20191112120307.GB5195@sirena.co.uk> <20191112190328.GA199853@dtor-ws> <20191112191547.GK5195@sirena.co.uk> <20191112193653.GB13374@dtor-ws> <20191114222652.GA7517@bogus> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="RnlQjJ0d97Da+TV1" Content-Disposition: inline In-Reply-To: X-Cookie: Tell me what to think!!! User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --RnlQjJ0d97Da+TV1 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Nov 15, 2019 at 07:52:22AM -0600, Rob Herring wrote: > if: > properties: > interrupt-names: > contains: > const: wakeup > required: > - interrupt-names > then: > required: > - wakeup-source That seems to say that if we have a device that has an interrupt called "wakeup" then it must be a wakeup source. Is that desirable? Being able to wake the system is partly a property of the system as a whole (the wakeup signal needs to be wired somewhere where it can wake things) and a device might have a signal that could be used to wake the system, may even be called "wakeup" by the device but for some reason isn't wired suitably in a given system. --RnlQjJ0d97Da+TV1 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl3OwqoACgkQJNaLcl1U h9AJgQf+JcZQhkga1MGvTU7f3pEsnMjZ9MRBtcDpMdDLrz4o3Vo5OUCODs2E6W0h T6j+P2IInqE4J74dF0jwwkNyOPuDwezdBKKUsZp+ERNYwF3aP4JeMJusN3AiAaCL h4KrVXnaiIi3eJoqhmDU3pq8soeITSYSaZ/pSeKlsRw5j5g/NBzkP6GfjlkBuV6p X1NzocN46iXcB1NRLVVkrbtxx3et1bPGWs0ZJBkVMU07GXY6i4znWUHB5SvEG4mJ 6qWYeNJOCXxsiSLMOYByRSub+xb4c5HvgtMiRMK8nH9x6dzZl0s51tWisJim6O2q 8RSmewbDkUOuvz1SQEVvd/lEqpyAvA== =GLB9 -----END PGP SIGNATURE----- --RnlQjJ0d97Da+TV1--