devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Cooper <alcooperx@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Al Cooper <alcooperx@gmail.com>,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org,
	Florian Fainelli <f.fainelli@gmail.com>,
	Kishon Vijay Abraham I <kishon@ti.com>,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Srinath Mannam <srinath.mannam@broadcom.com>
Subject: [PATCH v2 12/13] phy: usb: USB driver is crashing during S3 resume on 7216
Date: Fri, 15 Nov 2019 13:42:22 -0500	[thread overview]
Message-ID: <20191115184223.41504-13-alcooperx@gmail.com> (raw)
In-Reply-To: <20191115184223.41504-1-alcooperx@gmail.com>

This is a result of the USB 2.0 clocks not being disabled/enabled
during suspend/resume on XHCI only systems.

Signed-off-by: Al Cooper <alcooperx@gmail.com>
---
 drivers/phy/broadcom/phy-brcm-usb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/phy/broadcom/phy-brcm-usb.c b/drivers/phy/broadcom/phy-brcm-usb.c
index cc5763ace3ad..1ab44f54244b 100644
--- a/drivers/phy/broadcom/phy-brcm-usb.c
+++ b/drivers/phy/broadcom/phy-brcm-usb.c
@@ -543,7 +543,7 @@ static int brcm_usb_phy_suspend(struct device *dev)
 		brcm_usb_wake_enable(&priv->ini, true);
 		if (priv->phys[BRCM_USB_PHY_3_0].inited)
 			clk_disable_unprepare(priv->usb_30_clk);
-		if (priv->phys[BRCM_USB_PHY_2_0].inited)
+		if (priv->phys[BRCM_USB_PHY_2_0].inited || !priv->has_eohci)
 			clk_disable_unprepare(priv->usb_20_clk);
 		if (priv->wake_irq >= 0)
 			enable_irq_wake(priv->wake_irq);
-- 
2.17.1


  parent reply	other threads:[~2019-11-15 18:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-15 18:42 [PATCH v2 00/13] phy: usb: Updates to Broadcom STB USB PHY driver Al Cooper
2019-11-15 18:42 ` [PATCH v2 01/13] phy: usb: EHCI DMA may lose a burst of DMA data for 7255xA0 family Al Cooper
2019-11-15 18:42 ` [PATCH v2 02/13] phy: usb: Get all drivers that use USB clks using correct enable/disable Al Cooper
2019-11-15 18:42 ` [PATCH v2 03/13] phy: usb: Put USB phys into IDDQ on suspend to save power in S2 mode Al Cooper
2019-11-15 18:42 ` [PATCH v2 04/13] phy: usb: Add "wake on" functionality Al Cooper
2019-11-15 18:42 ` [PATCH v2 05/13] phy: usb: Restructure in preparation for adding 7216 USB support Al Cooper
2019-11-15 18:42 ` [PATCH v2 06/13] dt-bindings: Add Broadcom STB USB PHY binding document Al Cooper
2019-12-03 19:34   ` Rob Herring
2019-11-15 18:42 ` [PATCH v2 07/13] phy: usb: Add support for new Synopsis USB controller on the 7216 Al Cooper
2019-11-15 18:42 ` [PATCH v2 08/13] phy: usb: Add support for new Synopsis USB controller on the 7211b0 Al Cooper
2019-11-15 18:42 ` [PATCH v2 09/13] phy: usb: fix driver to defer on clk_get defer Al Cooper
2019-11-15 18:42 ` [PATCH v2 10/13] phy: usb: PHY's MDIO registers not accessible without device installed Al Cooper
2019-11-15 18:42 ` [PATCH v2 11/13] phy: usb: bdc: Fix occasional failure with BDC on 7211 Al Cooper
2019-11-15 18:42 ` Al Cooper [this message]
2019-11-15 18:42 ` [PATCH v2 13/13] phy: usb: Add support for wake and USB low power mode for 7211 S2/S5 Al Cooper
2019-12-05 23:46 ` [PATCH v2 00/13] phy: usb: Updates to Broadcom STB USB PHY driver Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115184223.41504-13-alcooperx@gmail.com \
    --to=alcooperx@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=srinath.mannam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).