From: Jonathan Cameron <jic23@kernel.org>
To: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
Cc: "u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"lars@metafoo.de" <lars@metafoo.de>
Subject: Re: [PATCH 1/3] iio: adc: ltc2496: provide device tree binding document
Date: Sat, 16 Nov 2019 15:25:04 +0000 [thread overview]
Message-ID: <20191116152504.499e2a54@archlinux> (raw)
In-Reply-To: <1e1a148095d2ea6c49c62e5fb2e5e741faa9d5f4.camel@analog.com>
On Tue, 12 Nov 2019 11:56:52 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Tue, 2019-11-12 at 08:04 +0100, Uwe Kleine-König wrote:
> > [External]
> >
> > Hello Alexandru,
> >
> > On Tue, Nov 12, 2019 at 06:57:49AM +0000, Ardelean, Alexandru wrote:
> > > On Mon, 2019-11-11 at 22:40 +0100, Uwe Kleine-König wrote:
> > > > The ADC only requires the standard stuff for spi devices and a
> > > > reference
> > > > voltage.
> > >
> > > DT bindings must be in YAML format.
> >
> > Yeah, I noticed this trend. But given that I only saw .txt files for
> > iio, I thought I'd stick to that.
> >
> > > But in this case, you can probably extend the existing
> > > "Documentation/devicetree/bindings/iio/adc/ltc2497.txt".
> >
> > I considered that shortly, but as the ltc2497 is an i2c device and the
> > ltc2496 uses spi I chose to create another simple document instead of
> > complicating the existing one by describing two nearly orthogonal sets
> > of properties.
>
> There are dt-bindings that cover both SPI & I2C.
> I think ADXL372 does that too.
True, but in that case no real choice as the same part does both
bus types. Here it's probably cleaner to just have a second document.
Thanks,
Jonathan
>
>
> >
> > Best regards
> > Uwe
> >
prev parent reply other threads:[~2019-11-16 15:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 21:40 [PATCH 1/3] iio: adc: ltc2496: provide device tree binding document Uwe Kleine-König
2019-11-11 21:40 ` [PATCH 2/3] iio: adc: ltc2497: split channel definition in a separate module Uwe Kleine-König
2019-11-12 7:14 ` Ardelean, Alexandru
2019-11-11 21:40 ` [PATCH 3/3] iio: adc: new driver to support Linear technology's ltc2496 Uwe Kleine-König
2019-11-12 7:54 ` Ardelean, Alexandru
2019-11-12 6:57 ` [PATCH 1/3] iio: adc: ltc2496: provide device tree binding document Ardelean, Alexandru
2019-11-12 7:04 ` Uwe Kleine-König
2019-11-12 11:56 ` Ardelean, Alexandru
2019-11-16 15:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191116152504.499e2a54@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=alexandru.Ardelean@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).