From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E4C7C43215 for ; Mon, 18 Nov 2019 23:57:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0B80922315 for ; Mon, 18 Nov 2019 23:57:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Gx4DUTq4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726813AbfKRX5P (ORCPT ); Mon, 18 Nov 2019 18:57:15 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60484 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbfKRX5P (ORCPT ); Mon, 18 Nov 2019 18:57:15 -0500 Received: from pendragon.ideasonboard.com (unknown [38.98.37.142]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 471A2563; Tue, 19 Nov 2019 00:57:12 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1574121433; bh=aKyNEzCNW4oqanbsWqK2vMzhTfqMSaiIuQ3r2mGPDj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Gx4DUTq4zphwLP3Z2qhO9xaWOGpl1lP/YpXrRTzV7qja/hb6HnRCOvBkEFSV7LqHq OLSaHZPElrzSDDNaxQgIP4wGGcd0D1wXyiXW7fLLZra6LdaMtmgbkZxV5D2UgCJz5R bgBEoGFdcBr9SplSX9zYillzM/XE1vvp+vrJKimE= Date: Tue, 19 Nov 2019 01:56:59 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Geert Uytterhoeven , Magnus Damm , Peter Rosin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v4 03/13] dt-bindings: display: bridge: lvds-transmitter: Absorb ti,ds90c185.txt Message-ID: <20191118235659.GC5171@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-4-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1573660292-10629-4-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Wed, Nov 13, 2019 at 03:51:22PM +0000, Fabrizio Castro wrote: > ti,ds90c185.txt documents LVDS encoders using the same driver > as the one documented by lvds-transmitter.yaml. > Since the properties listed in ti,ds90c185.txt are the same > as the ones listed in lvds-transmitter.yaml, absorb the dt-binding > into lvds-transmitter.yaml. > > Signed-off-by: Fabrizio Castro Reviewed-by: Laurent Pinchart > --- > v3->v4: > * New patch > --- > .../bindings/display/bridge/lvds-transmitter.yaml | 14 +++--- > .../bindings/display/bridge/ti,ds90c185.txt | 55 ---------------------- > 2 files changed, 8 insertions(+), 61 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > index 2484737..a8326ce 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > @@ -31,11 +31,13 @@ description: | > properties: > compatible: > description: | > - Any encoder compatible with this generic binding, but with additional > - properties not listed here, must define its own binding and list a device > - specific compatible first followed by the generic compatible. > - enum: > - - lvds-encoder > + Must list the device specific compatible string first, followed by the > + generic compatible string. > + items: > + - enum: > + - ti,ds90c185 # For the TI DS90C185 FPD-Link Serializer > + - ti,ds90c187 # For the TI DS90C187 FPD-Link Serializer > + - const: lvds-encoder # Generic LVDS encoder compatible fallback > > ports: > type: object > @@ -69,7 +71,7 @@ required: > examples: > - | > lvds-encoder { > - compatible = "lvds-encoder"; > + compatible = "ti,ds90c185", "lvds-encoder"; > > ports { > #address-cells = <1>; > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt b/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > deleted file mode 100644 > index e575f99..0000000 > --- a/Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt > +++ /dev/null > @@ -1,55 +0,0 @@ > -Texas Instruments FPD-Link (LVDS) Serializer > --------------------------------------------- > - > -The DS90C185 and DS90C187 are low-power serializers for portable > -battery-powered applications that reduces the size of the RGB > -interface between the host GPU and the display. > - > -Required properties: > - > -- compatible: Should be > - "ti,ds90c185", "lvds-encoder" for the TI DS90C185 FPD-Link Serializer > - "ti,ds90c187", "lvds-encoder" for the TI DS90C187 FPD-Link Serializer > - > -Optional properties: > - > -- powerdown-gpios: Power down control GPIO (the PDB pin, active-low) > - > -Required nodes: > - > -The devices have two video ports. Their connections are modeled using the OF > -graph bindings specified in Documentation/devicetree/bindings/graph.txt. > - > -- Video port 0 for parallel input > -- Video port 1 for LVDS output > - > - > -Example > -------- > - > -lvds-encoder { > - compatible = "ti,ds90c185", "lvds-encoder"; > - > - powerdown-gpios = <&gpio 17 GPIO_ACTIVE_LOW>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - > - port@0 { > - reg = <0>; > - > - lvds_enc_in: endpoint { > - remote-endpoint = <&lcdc_out_rgb>; > - }; > - }; > - > - port@1 { > - reg = <1>; > - > - lvds_enc_out: endpoint { > - remote-endpoint = <&lvds_panel_in>; > - }; > - }; > - }; > -}; > -- > 2.7.4 > -- Regards, Laurent Pinchart