From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86D21C432C3 for ; Tue, 19 Nov 2019 00:08:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E4B922313 for ; Tue, 19 Nov 2019 00:08:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aRhXhr5V" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbfKSAIJ (ORCPT ); Mon, 18 Nov 2019 19:08:09 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:60734 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726809AbfKSAII (ORCPT ); Mon, 18 Nov 2019 19:08:08 -0500 Received: from pendragon.ideasonboard.com (unknown [38.98.37.142]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id E79E6563; Tue, 19 Nov 2019 01:08:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1574122085; bh=4o/rSf/GdeHzFnL4F36KShc1CwiIGZ1Lq69bdm6pif4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aRhXhr5VAV/xfv4Dc8RiHrZaUcMKVrgJAsXw0wBeHQcxUvs45jttZKzmwbUFoqCyK XVZtD4usMKqGsloofPcT8Ki/ioPkCRXOCd+aIZKauj9nqtdSTCuPMhOlm2GNmNds7P 94FBXvUb4QM2Cw5/KCaBy1jZiCUXS1SPJmD90xb8= Date: Tue, 19 Nov 2019 02:07:52 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Neil Armstrong , David Airlie , Daniel Vetter , Rob Herring , Mark Rutland , Andrzej Hajda , Simon Horman , Geert Uytterhoeven , Magnus Damm , Peter Rosin , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org, Chris Paterson , Biju Das , Kieran Bingham , Jacopo Mondi Subject: Re: [PATCH v4 08/13] dt-bindings: display: bridge: Repurpose lvds-encoder Message-ID: <20191119000752.GH5171@pendragon.ideasonboard.com> References: <1573660292-10629-1-git-send-email-fabrizio.castro@bp.renesas.com> <1573660292-10629-9-git-send-email-fabrizio.castro@bp.renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1573660292-10629-9-git-send-email-fabrizio.castro@bp.renesas.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Wed, Nov 13, 2019 at 03:51:27PM +0000, Fabrizio Castro wrote: > In an effort to repurpose lvds-encoder.c to also serve the > function of LVDS decoders, we ended up defining a new "generic" > compatible string ("lvds-decoder"), therefore adapt the dt schema > to allow for the new compatible string. > > Signed-off-by: Fabrizio Castro > > --- > v3->v4: > * Improved title and description according to Laurent's comments > * Reworked definition of the compatible property > v2->v3: > * Extracted conversion to lvds-codec as per Rob's comment > v1->v2: > * Converted to dt-schema as per Neil's comment > --- > .../{lvds-transmitter.yaml => lvds-codec.yaml} | 54 +++++++++++++++++----- > 1 file changed, 42 insertions(+), 12 deletions(-) > rename Documentation/devicetree/bindings/display/bridge/{lvds-transmitter.yaml => lvds-codec.yaml} (61%) > > diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > similarity index 61% > rename from Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > rename to Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > index 27de616..0ecc8a4 100644 > --- a/Documentation/devicetree/bindings/display/bridge/lvds-transmitter.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml > @@ -1,17 +1,17 @@ > # SPDX-License-Identifier: GPL-2.0 > %YAML 1.2 > --- > -$id: http://devicetree.org/schemas/display/bridge/lvds-transmitter.yaml# > +$id: http://devicetree.org/schemas/display/bridge/lvds-codec.yaml# > $schema: http://devicetree.org/meta-schemas/core.yaml# > > -title: Parallel to LVDS Encoder > +title: Transparent LVDS encoders and decoders > > maintainers: > - Laurent Pinchart > > description: | > - This binding supports the parallel to LVDS encoders that don't require any > - configuration. > + This binding supports transparent LVDS encoders and decoders that don't > + require any configuration. > > LVDS is a physical layer specification defined in ANSI/TIA/EIA-644-A. Multiple > incompatible data link layers have been used over time to transmit image data > @@ -33,12 +33,14 @@ properties: > description: | > Must list the device specific compatible string first, followed by the > generic compatible string. > - items: > - - enum: > - - ti,ds90c185 # For the TI DS90C185 FPD-Link Serializer > - - ti,ds90c187 # For the TI DS90C187 FPD-Link Serializer > - - ti,sn75lvds83 # For the TI SN75LVDS83 FlatLink transmitter > - - const: lvds-encoder # Generic LVDS encoder compatible fallback > + oneOf: > + - items: > + - enum: > + - ti,ds90c185 # For the TI DS90C185 FPD-Link Serializer > + - ti,ds90c187 # For the TI DS90C187 FPD-Link Serializer > + - ti,sn75lvds83 # For the TI SN75LVDS83 FlatLink transmitter > + - const: lvds-encoder # Generic LVDS encoder compatible fallback > + - const: lvds-decoder # Generic LVDS decoders compatible fallback > > ports: > type: object > @@ -49,12 +51,14 @@ properties: > port@0: > type: object > description: | > - Port 0 is for parallel input > + With LVDS encoders port 0 is for parallel input > + With LVDS decoders port 0 is for LVDS input How about For LVDS encoders, port 0 is the parallel input For LVDS decoders, port 0 is the LVDS input > > port@1: > type: object > description: | > - Port 1 is for LVDS output > + With LVDS encoders port 1 is for LVDS output > + With LVDS decoders port 1 is for parallel output And similarly here ? If you're fine with this change there's no need to resubmit, I'll change this when applying, and Reviewed-by: Laurent Pinchart > > required: > - port@0 > @@ -96,4 +100,30 @@ examples: > }; > }; > > + - | > + lvds-decoder { > + compatible = "lvds-decoder"; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + reg = <0>; > + > + lvds_dec_in: endpoint { > + remote-endpoint = <&display_out_lvds>; > + }; > + }; > + > + port@1 { > + reg = <1>; > + > + lvds_dec_out: endpoint { > + remote-endpoint = <&rgb_panel_in>; > + }; > + }; > + }; > + }; > + > ... -- Regards, Laurent Pinchart