From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Clément Péron" <peron.clem@gmail.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Philipp Zabel <pza@pengutronix.de>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
Jernej Skrabec <jernej.skrabec@siol.net>
Subject: Re: [PATCH v7 4/8] pwm: sun4i: Add an optional probe for bus clock
Date: Thu, 21 Nov 2019 08:28:29 +0100 [thread overview]
Message-ID: <20191121072829.vitly7altcvlt4sj@pengutronix.de> (raw)
In-Reply-To: <20191119175319.16561-5-peron.clem@gmail.com>
Hello Clément,
On Tue, Nov 19, 2019 at 06:53:15PM +0100, Clément Péron wrote:
> + /*
> + * We're keeping the bus clock on for the sake of simplicity.
> + * Actually it only needs to be on for hardware register accesses.
> + */
> + ret = clk_prepare_enable(pwm->bus_clk);
> + if (ret) {
> + dev_err(&pdev->dev, "Cannot prepare and enable bus_clk\n");
Maybe add the error code to the message?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2019-11-21 7:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-19 17:53 [PATCH v7 0/8] Add support for H6 PWM Clément Péron
2019-11-19 17:53 ` [PATCH v7 1/8] dt-bindings: pwm: allwinner: Add H6 PWM description Clément Péron
2019-11-19 17:53 ` [PATCH v7 2/8] pwm: sun4i: Add an optional probe for reset line Clément Péron
2019-11-19 17:53 ` [PATCH v7 3/8] pwm: sun4i: Prefer "mod" clock to unnamed Clément Péron
2019-11-21 7:26 ` Uwe Kleine-König
2019-11-19 17:53 ` [PATCH v7 4/8] pwm: sun4i: Add an optional probe for bus clock Clément Péron
2019-11-21 7:28 ` Uwe Kleine-König [this message]
2019-11-21 11:14 ` Clément Péron
2019-11-19 17:53 ` [PATCH v7 5/8] pwm: sun4i: Add support to output source clock directly Clément Péron
2019-11-21 7:36 ` Uwe Kleine-König
2019-11-21 11:38 ` Clément Péron
2019-11-19 17:53 ` [PATCH v7 6/8] pwm: sun4i: Add support for H6 PWM Clément Péron
2019-11-19 17:53 ` [PATCH v7 7/8] arm64: dts: allwinner: h6: Add PWM node Clément Péron
2019-11-19 17:53 ` [PATCH v7 8/8] [DO NOT MERGE] arm64: allwinner: h6: enable Beelink GS1 PWM Clément Péron
2019-11-21 7:24 ` [PATCH v7 0/8] Add support for H6 PWM Maxime Ripard
2019-12-10 16:48 ` Rob Herring
2019-12-10 17:20 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191121072829.vitly7altcvlt4sj@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mark.rutland@arm.com \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=pza@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).