From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96697C432C0 for ; Sat, 30 Nov 2019 17:48:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 563BD2073C for ; Sat, 30 Nov 2019 17:48:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XVHVcEqE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726964AbfK3Rr7 (ORCPT ); Sat, 30 Nov 2019 12:47:59 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:40690 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726799AbfK3Rr7 (ORCPT ); Sat, 30 Nov 2019 12:47:59 -0500 Received: by mail-wm1-f66.google.com with SMTP id t14so741812wmi.5 for ; Sat, 30 Nov 2019 09:47:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=poGibO9qdNshU37AQtEu7PiMmZHvBRxqCoaasj/1GA8=; b=XVHVcEqEaftrXiD8BRTcviTNWANZEUEBU6y9diugyXPcRpwCA4SmSKruP1qqR70iD6 H7hnTWQVHUsqyluMJOQR/SdiOWdVG83vAPeTtxWr8QevOuWcK1OgkTN1LMBGumuxTBkY zFFtI9NqbTVo8X/shcUOzc1wAdIvMqWsWLxe1W7eYBXARjLPlXjSpL9qTYElHQmTKS5z YmfZyXHpV1N72F20PeCOeerXnh8f4CSwlfRclnCsgs0eufU7ophQeSsOIUUiLCslTKm0 jhzRS4XJrUg6YIVEfOReABIH35/YyDjlXxnj+71pq0+h1P0w34o61HMXvVIWfo8aET3o z6zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=poGibO9qdNshU37AQtEu7PiMmZHvBRxqCoaasj/1GA8=; b=IYCPAHj0uMmF1DgQPLK26xYIZR6eOyc96rK12hT9pZBPEInckss/MdXqSXEMST7iRW dvIff8eQqVZd/9jPxu3vdT4CMX6wvz1HbN/pFPDJgqe9SELSlN2rL/vSHERn9e7Bzuop tD3LH/a03xYd1qdduQZNmbbaJwkQ+yvOsMbMJQo/LfSzrGPl3VdhM5qGjpDJVMRagCsV l8pkjx14DS/wAeE4F6Z8dMvFyESMdY1zghESuT+TMsibw2WazX5iPWzYPjcE532XlHFr KryQEsmGkWIevRtHDl7dHr+HUKrrTeOj1s/HsicBL/cq1OCreKBf3ljZkLROjMwYBcRH Dedw== X-Gm-Message-State: APjAAAX5BC7J7BpZM/KUXlSDvLuqg+oOi7FVjeq+GFeHVVoG97/xkWkA 8N4I+g7AfXiRiFX8+SqLcF8= X-Google-Smtp-Source: APXvYqwpTPQRPBMuX6GWtHUmaUx6kn8JGbMcyBT2GtUVHCpmbhmUujHwyBLXCny+bnB0FFZrC/xYVQ== X-Received: by 2002:a05:600c:2283:: with SMTP id 3mr15860652wmf.100.1575136076380; Sat, 30 Nov 2019 09:47:56 -0800 (PST) Received: from localhost ([37.238.188.27]) by smtp.gmail.com with ESMTPSA id v20sm17760305wmj.32.2019.11.30.09.47.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 30 Nov 2019 09:47:55 -0800 (PST) Date: Sat, 30 Nov 2019 20:47:53 +0300 From: Mohammad Rasim To: Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, Rob Herring , Kevin Hilman , Neil Armstrong , Mark Rutland Subject: Re: [PATCH v3 2/2] arm64: dts: meson-gxbb: add support for Message-ID: <20191130174753.6ajv5spl6n3ojhqy@manjaro.localdomain> References: <20191130115824.31778-1-mohammad.rasim96@gmail.com> <20191130115824.31778-3-mohammad.rasim96@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 19/11/30 02:59PM, Martin Blumenstingl wrote: > Hi Mohammad, > > this patch should be third in the series. > the currently missing patch for the dt-bindings should be patch two. > you can take the following commit as an example: > effdd8a6b6ecb30b088f36ed0a1fb67cdc7610a9 ("dt-bindings: arm: amlogic: > add SEI Robotics SEI610 bindings") > > On Sat, Nov 30, 2019 at 12:58 PM Mohammad Rasim > wrote: > > > > This patch adds support for the Videostrong KII Pro tv box which is > > based on the gxbb-p201 reference design > > > > The device tree includes a new compatible for bluetooth "brcm,bcm4335a0" > > which was merged recently into torvalds tree > > > > Signed-off-by: Mohammad Rasim > > --- > > arch/arm64/boot/dts/amlogic/Makefile | 1 + > > .../boot/dts/amlogic/meson-gxbb-kii-pro.dts | 76 +++++++++++++++++++ > > 2 files changed, 77 insertions(+) > > create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts > > > > diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile > > index 84afecba9ec0..a795a170dcab 100644 > > --- a/arch/arm64/boot/dts/amlogic/Makefile > > +++ b/arch/arm64/boot/dts/amlogic/Makefile > > @@ -6,6 +6,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-g12a-x96-max.dtb > > dtb-$(CONFIG_ARCH_MESON) += meson-g12b-a311d-khadas-vim3.dtb > > dtb-$(CONFIG_ARCH_MESON) += meson-g12b-s922x-khadas-vim3.dtb > > dtb-$(CONFIG_ARCH_MESON) += meson-g12b-odroid-n2.dtb > > +dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-kii-pro.dtb > > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nanopi-k2.dtb > > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-nexbox-a95x.dtb > > dtb-$(CONFIG_ARCH_MESON) += meson-gxbb-odroidc2.dtb > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts > > new file mode 100644 > > index 000000000000..5d120e6ca338 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-kii-pro.dts > > @@ -0,0 +1,76 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (c) 2019 Mohammad Rasim > > + */ > > + > > +/dts-v1/; > > + > > +#include "meson-gxbb-p20x.dtsi" > > + > > +#include > > +#include > > +/ { > > + compatible = "videostrong,kii-pro", "amlogic,p201", "amlogic,s905", "amlogic,meson-gxbb"; > > + model = "Videostrong KII Pro"; > > + > > + leds { > > + compatible = "gpio-leds"; > > + red { > > + label = "status"; > this property seems to be deprecated now, see > Documentation/devicetree/bindings/leds/common.txt > but I'm not sure whether Kevin has made a decision yet when to not > accept "label" properties here anymore OK, I will remove the deprecated property but I'm not sure what should I choose as a function, LED_FUNCTION_STATUS or LED_FUNCTION_ACTIVITY ? > > > + gpios = <&gpio_ao GPIOAO_13 GPIO_ACTIVE_LOW>; > > + default-state = "off"; > > + }; > > + }; > > + > > + gpio-keys-polled { > > + compatible = "gpio-keys-polled"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + poll-interval = <20>; > > + > > + button@0 { > please name this button-reset (even though we've done it wrong for > other boards in the past) > @0 indicates a unit-address, but the button has no address Ok, will fix it in the next version > > > + label = "reset"; > > + linux,code = ; > > + gpios = <&gpio_ao GPIOAO_3 GPIO_ACTIVE_HIGH>; > > + }; > > + }; > > + > > +}; > > + > > + > > + > > +&uart_A { > > + status = "okay"; > > + pinctrl-0 = <&uart_a_pins>, <&uart_a_cts_rts_pins>; > > + pinctrl-names = "default"; > > + uart-has-rtscts; > > + > > + bluetooth { > > + compatible = "brcm,bcm4335a0"; > > + }; > > +}; > > + > > + > > + > > +ðmac { > > + status = "okay"; > > + pinctrl-0 = <ð_rmii_pins>; > > + pinctrl-names = "default"; > > + > > + phy-handle = <ð_phy0>; > > + phy-mode = "rmii"; > > + > > + mdio { > > + compatible = "snps,dwmac-mdio"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + eth_phy0: ethernet-phy@0 { > > + /* IC Plus IP101GR (0x02430c54) */ > > + reg = <0>; > > + reset-assert-us = <10000>; > > + reset-deassert-us = <10000>; > > + reset-gpios = <&gpio GPIOZ_14 GPIO_ACTIVE_LOW>; > > + }; > thank you for switching to the new PHY bindings :) > > assuming Kevin still accepts the LED "label" and you rename the button > node then you can add my: > Reviewed-by: Martin Blumenstingl > (don't forget that we still need an additional dt-bindings patch though) > I'm sending a new version anyways so I will remove the lable property Thanks > > Martin